From: Praveenkumar I <quic_ipkumar@quicinc.com>
To: Konrad Dybcio <konrad.dybcio@linaro.org>, <mani@kernel.org>,
<agross@kernel.org>, <andersson@kernel.org>,
<lpieralisi@kernel.org>, <kw@linux.com>, <robh@kernel.org>,
<bhelgaas@google.com>, <linux-pci@vger.kernel.org>,
<linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <quic_varada@quicinc.com>, <quic_devipriy@quicinc.com>
Subject: Re: [PATCH 1/1] PCI: qcom: Add early fixup to set the max payload size for IPQ9574
Date: Mon, 24 Jul 2023 19:21:49 +0530 [thread overview]
Message-ID: <b9424d44-82bf-8863-a269-ab68fde232e7@quicinc.com> (raw)
In-Reply-To: <af7d1db2-8bbe-e078-6b17-7f841fb7f475@linaro.org>
On 7/24/2023 6:23 PM, Konrad Dybcio wrote:
> On 24.07.2023 14:47, Praveenkumar I wrote:
>> Set 256 bytes as payload size for IPQ9574 via early fixup. This allows
>> PCIe RC to use the max payload size when a capable link partner is
>> connected.
>>
>> Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com>
>> ---
> [...]
>
>> +static void qcom_fixup_mps_256(struct pci_dev *dev)
>> +{
>> + pcie_set_mps(dev, 256);
> Looks like setting "dev->pcie_mpss = 1" here would make the PCIe generic
> code take care of this.
Yes, but that is not helping as the generic code pci_configure_mps() has
a check for,
/ if (!bridge || !pci_is_pcie(bridge))/
/ return;/
/Here it is returning and mps is not set to new 256 bytes./
>
> Konrad
--
Thanks,
Praveenkumar
next prev parent reply other threads:[~2023-07-24 13:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 12:47 [PATCH 0/1] Set may " Praveenkumar I
2023-07-24 12:47 ` [PATCH 1/1] PCI: qcom: Add early fixup to set the max " Praveenkumar I
2023-07-24 12:53 ` Konrad Dybcio
2023-07-24 13:08 ` Manivannan Sadhasivam
2023-07-24 14:09 ` Manivannan Sadhasivam
2023-07-25 4:46 ` Praveenkumar I
2023-07-25 6:06 ` Manivannan Sadhasivam
2023-07-26 7:28 ` Praveenkumar I
2023-07-26 9:22 ` Praveenkumar I
2023-07-26 10:49 ` Praveenkumar I
2023-07-24 13:51 ` Praveenkumar I [this message]
2023-07-24 12:50 ` [PATCH 0/1] Set may " Konrad Dybcio
2023-07-25 4:24 ` Praveenkumar I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9424d44-82bf-8863-a269-ab68fde232e7@quicinc.com \
--to=quic_ipkumar@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=konrad.dybcio@linaro.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=quic_devipriy@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®