Re: [PATCH 1/2] dt-bindings: arm: qcom,ids: Add SoC ID for SM7550

[Krzysztof Kozlowski <krzk@kernel.org>]

On 13/11/2026 15:30, Aditya Choudhury wrote:
> On Fri, Nov 13, 2026 at 12:17:35PM +0100, Krzysztof Kozlowski wrote:
>> On Thu, Nov 12, 2026 at 10:30:26AM +0000, Aditya Choudhury wrote:
>>> Add the ID for the Qualcomm SM7550 SoC, whose internal codename is crow.
>>
>> >From where did you get internal codename? Downstream does not use the
>> proper codenames.
>>
> crow is the codename used in downstream sources. I assumed it was the
> internal codename since SM7550 is publicly known as Snapdragon 7 Gen 3.
> I was also unsure about this because SM7635 uses milos upstream instead
> of volcano downstream.

As you can easily check, names in downstream are not codenames and have
no meaning. Don't use them.

> 
>>>
>>> Signed-off-by: Aditya Choudhury <mail@inferno0230.in>
>>> ---
>>>  include/dt-bindings/arm/qcom,ids.h | 1 +
>>>  1 file changed, 1 insertion(+)
>>
>> Where is any user of this? Why do we need such SoC patches separate from
>> the actual new SoC?
>>
> I sent these patches first because I expected a possible codename
> change, just like what happened with SM7635. I wanted to settle the name
> before sending the actual SoC support patches, so it wouldn't need to
> be changed everywhere later.

But this does not settle the name! You only sent SoC ID, without the
actual name. Organize your work in proper chunks, not split without
proper reason. This only limits the view and makes review unnecessarily
difficult.

Best regards,
Krzysztof