mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jessica Zhang <quic_jesszhan@quicinc.com>
To: John Watts <contact@jookia.org>, <dri-devel@lists.freedesktop.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, <devicetree@vger.kernel.org>,
	Sam Ravnborg <sam@ravnborg.org>,
	Chris Morgan <macromorgan@hotmail.com>,
	<linux-kernel@vger.kernel.org>, Jagan Teki <jagan@edgeble.ai>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Shawn Guo <shawnguo@kernel.org>
Subject: Re: [RFC PATCH 2/8] drm/panel: nv3052c: Add SPI device IDs
Date: Fri, 15 Sep 2023 14:50:16 -0700	[thread overview]
Message-ID: <b948d505-3cfd-318d-20eb-9f60a2865d23@quicinc.com> (raw)
In-Reply-To: <20230911090206.3121440-3-contact@jookia.org>



On 9/11/2023 2:02 AM, John Watts wrote:
> SPI drivers needs their own list of compatible device IDs in order
> for automatic module loading to work. Add those for this driver.

Hi John,

Reviewed-by: Jessica Zhang <quic_jesszhan@quicinc.com>

Thanks,

Jessica Zhang

> 
> Signed-off-by: John Watts <contact@jookia.org>
> ---
>   drivers/gpu/drm/panel/panel-newvision-nv3052c.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-newvision-nv3052c.c b/drivers/gpu/drm/panel/panel-newvision-nv3052c.c
> index 589431523ce7..90dea21f9856 100644
> --- a/drivers/gpu/drm/panel/panel-newvision-nv3052c.c
> +++ b/drivers/gpu/drm/panel/panel-newvision-nv3052c.c
> @@ -465,6 +465,12 @@ static const struct nv3052c_panel_info ltk035c5444t_panel_info = {
>   	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE,
>   };
>   
> +static const struct spi_device_id nv3052c_ids[] = {
> +	{ "ltk035c5444t", },
> +	{ /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(spi, nv3052c_ids);
> +
>   static const struct of_device_id nv3052c_of_match[] = {
>   	{ .compatible = "leadtek,ltk035c5444t", .data = &ltk035c5444t_panel_info },
>   	{ /* sentinel */ }
> @@ -476,6 +482,7 @@ static struct spi_driver nv3052c_driver = {
>   		.name = "nv3052c",
>   		.of_match_table = nv3052c_of_match,
>   	},
> +	.id_table = nv3052c_ids,
>   	.probe = nv3052c_probe,
>   	.remove = nv3052c_remove,
>   };
> -- 
> 2.42.0
> 

  reply	other threads:[~2023-09-15 21:52 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-11  9:01 [RFC PATCH 0/8] Add FS035VG158 panel John Watts
2023-09-11  9:01 ` [RFC PATCH 1/8] drm/panel: nv3052c: Document known register names John Watts
2023-09-13 21:43   ` Jessica Zhang
2023-09-14  4:12     ` John Watts
2023-09-14 20:27       ` Jessica Zhang
2023-09-11  9:02 ` [RFC PATCH 2/8] drm/panel: nv3052c: Add SPI device IDs John Watts
2023-09-15 21:50   ` Jessica Zhang [this message]
2023-09-11  9:02 ` [RFC PATCH 3/8] drm/panel: nv3052c: Sleep for 150ms after reset John Watts
2023-09-11  9:02 ` [RFC PATCH 4/8] drm/panel: nv3052c: Wait before entering sleep mode John Watts
2023-09-11  9:02 ` [RFC PATCH 5/8] drm/panel: nv3052c: Allow specifying registers per panel John Watts
2023-09-13 21:34   ` Jessica Zhang
2023-09-14  4:09     ` John Watts
2023-09-14 20:22       ` Jessica Zhang
2023-09-15 21:23   ` Jessica Zhang
2023-09-11  9:02 ` [RFC PATCH 6/8] drm/panel: nv3052c: Add Fascontek FS035VG158 LCD display John Watts
2023-09-11  9:02 ` [RFC PATCH 7/8] dt-bindings: vendor-prefixes: Add fascontek John Watts
2023-09-11  9:41   ` Krzysztof Kozlowski
2023-09-11  9:02 ` [RFC PATCH 8/8] dt-bindings: display: panel: add Fascontek FS035VG158 panel John Watts
2023-09-11  9:41   ` Krzysztof Kozlowski
2023-09-11  9:49     ` John Watts
2023-09-11 11:49       ` Krzysztof Kozlowski
2023-09-11 16:47         ` John Watts
2023-09-12  6:55           ` Krzysztof Kozlowski
2023-09-12  8:56             ` John Watts
2023-09-17 20:24     ` John Watts
2023-09-18 12:06       ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b948d505-3cfd-318d-20eb-9f60a2865d23@quicinc.com \
    --to=quic_jesszhan@quicinc.com \
    --cc=conor+dt@kernel.org \
    --cc=contact@jookia.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jagan@edgeble.ai \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=macromorgan@hotmail.com \
    --cc=neil.armstrong@linaro.org \
    --cc=robh+dt@kernel.org \
    --cc=sam@ravnborg.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®