From: Florian Fainelli <f.fainelli@gmail.com>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
Salvatore Mesoraca <s.mesoraca16@gmail.com>,
linux-kernel@vger.kernel.org
Cc: kernel-hardening@lists.openwall.com, netdev@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Andrew Lunn <andrew@lunn.ch>, Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] net: dsa: drop some VLAs in switch.c
Date: Tue, 13 Mar 2018 13:06:33 -0700 [thread overview]
Message-ID: <b948ef55-8b16-fee4-b22f-4c6d09fea0cf@gmail.com> (raw)
In-Reply-To: <87fu5321du.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>
On 03/13/2018 12:58 PM, Vivien Didelot wrote:
> Hi Salvatore,
>
> Salvatore Mesoraca <s.mesoraca16@gmail.com> writes:
>
>> dsa_switch's num_ports is currently fixed to DSA_MAX_PORTS. So we avoid
>> 2 VLAs[1] by using DSA_MAX_PORTS instead of ds->num_ports.
>>
>> [1] https://lkml.org/lkml/2018/3/7/621
>>
>> Signed-off-by: Salvatore Mesoraca <s.mesoraca16@gmail.com>
>
> NAK.
>
> We are in the process to remove hardcoded limits such as DSA_MAX_PORTS
> and DSA_MAX_SWITCHES, so we have to stick with ds->num_ports.
Then this means that we need to allocate a bitmap from the heap, which
sounds a bit superfluous and could theoretically fail... not sure which
way is better, but bumping the size to DSA_MAX_PORTS definitively does
help people working on enabling -Wvla.
--
Florian
next prev parent reply other threads:[~2018-03-13 20:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 19:50 Salvatore Mesoraca
2018-03-13 19:58 ` Vivien Didelot
2018-03-13 20:06 ` Florian Fainelli [this message]
2018-05-05 10:36 ` Salvatore Mesoraca
2018-05-05 15:39 ` Andrew Lunn
2018-05-05 18:22 ` Kees Cook
2018-05-05 18:51 ` Andrew Lunn
2018-03-13 22:01 ` Salvatore Mesoraca
2018-03-14 11:24 ` David Laight
2018-03-14 12:48 ` Salvatore Mesoraca
2018-03-18 14:08 ` Salvatore Mesoraca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b948ef55-8b16-fee4-b22f-4c6d09fea0cf@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=s.mesoraca16@gmail.com \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome