mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ben Horgan <ben.horgan@arm.com>
To: Zeng Heng <zengheng4@huawei.com>, James Morse <james.morse@arm.com>
Cc: amitsinght@marvell.com, baisheng.gao@unisoc.com,
	baolin.wang@linux.alibaba.com, carl@os.amperecomputing.com,
	dave.martin@arm.com, david@kernel.org, dfustini@baylibre.com,
	fenghuay@nvidia.com, gshan@redhat.com,
	jonathan.cameron@huawei.com, kobak@nvidia.com,
	lcherian@marvell.com, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, peternewman@google.com,
	punit.agrawal@oss.qualcomm.com, quic_jiles@quicinc.com,
	reinette.chatre@intel.com, rohit.mathew@arm.com,
	scott@os.amperecomputing.com, sdonthineni@nvidia.com,
	tan.shaopeng@fujitsu.com, xhao@linux.alibaba.com,
	catalin.marinas@arm.com, will@kernel.org, corbet@lwn.net,
	maz@kernel.org, oupton@kernel.org, joey.gouly@arm.com,
	suzuki.poulose@arm.com, kvmarm@lists.linux.dev,
	linux-doc@vger.kernel.org,
	Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
	Kefeng Wang <wangkefeng.wang@huawei.com>
Subject: Re: [PATCH v5 31/41] arm_mpam: resctrl: Add resctrl_arch_rmid_read() and resctrl_arch_reset_rmid()
Date: Mon, 9 Mar 2026 16:30:08 +0000	[thread overview]
Message-ID: <b95077d7-c036-4a8f-8e42-8f1dc0288075@arm.com> (raw)
In-Reply-To: <96ffc81d-3f37-7f48-f9f4-6a58da3e0f99@huawei.com>

Hi Zeng,

On 3/7/26 09:29, Zeng Heng wrote:
> Hi Ben,
> 
> On 2026/2/25 1:57, Ben Horgan wrote:
>> From: James Morse <james.morse@arm.com>
>>
>> resctrl uses resctrl_arch_rmid_read() to read counters. CDP emulation
>> means
>> the counter may need reading in three different ways. The same goes for
>> reset.
>>
>> The helpers behind the resctrl_arch_ functions will be re-used for the
>> ABMC
>> equivalent functions.
>>
>> Add the rounding helper for checking monitor values while we're here.
>>
>> Tested-by: Gavin Shan <gshan@redhat.com>
>> Tested-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
>> Tested-by: Peter Newman <peternewman@google.com>
>> Tested-by: Zeng Heng <zengheng4@huawei.com>
>> Reviewed-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
>> Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
>> Signed-off-by: James Morse <james.morse@arm.com>
>> Signed-off-by: Ben Horgan <ben.horgan@arm.com>
>> ---
> 
> [...]
> 
>> +
>> +static int read_mon_cdp_safe(struct mpam_resctrl_mon *mon, struct
>> mpam_component *mon_comp,
>> +                 enum mpam_device_features mon_type,
>> +                 int mon_idx, u32 closid, u32 rmid, u64 *val)
>> +{
>> +    if (cdp_enabled) {
> 
> While reviewing the resctrl limbo handling code, I noticed a issue in
> __check_limbo() that could lead to premature RMID release when CDP is
> enabled.
> 
> In __check_limbo(), RMIDs in limbo state undergo L3 occupancy checks
> before being released. This check is performed via
> resctrl_arch_rmid_read(), on arm64 MPAM, which relies on the cdp_enabled
> state to determine to check which PARTID.
> 
> The concern arises in the following scenario: Filesystem is mounted with
> CDP enabled. During normal operation, some RMIDs enter limbo. On umount,
> cdp_enabled is reset to false. __check_limbo() may then run and perform
> L3 checks with cdp_enabled = false. This could cause RMIDs to be
> incorrectly released from limbo while still effectively busy after
> remount.

I think a stale limbo list cause more problems than that. If you mount
with cdp disabled, cause some rmids to be dirty, unmount and then
remount with cdp enabled then you may have some of the entries in upper
half marked as busy but when the limbo code checks them it ends up using
an out of range partid and may trigger an mpam error interrupt.

To avoid a stale list we could disable the limbo checking at unmount and
at remount remake the bitmap. This would involve some resctrl changes
which I will have a further look into. For now, to avoid the dependency
without a lot of patch churn in this series I think we can hide the cdp
enablement behind CONFIG_EXPERT. Does that sound ok to you?

Thanks,

Ben

> 
> Apologies for not providing a ready-made fix in this email. However,
> I would appreciate to hear the community's thoughts on this issue.
> 
> 
>> +        u64 code_val = 0, data_val = 0;
>> +        int err;
>> +
>> +        err = __read_mon(mon, mon_comp, mon_type, mon_idx,
>> +                 CDP_CODE, closid, rmid, &code_val);
>> +        if (err)
>> +            return err;
>> +
>> +        err = __read_mon(mon, mon_comp, mon_type, mon_idx,
>> +                 CDP_DATA, closid, rmid, &data_val);
>> +        if (err)
>> +            return err;
>> +
>> +        *val += code_val + data_val;
>> +        return 0;
>> +    }
>> +
>> +    return __read_mon(mon, mon_comp, mon_type, mon_idx,
>> +              CDP_NONE, closid, rmid, val);
>> +}
>> +
>> +/* MBWU when not in ABMC mode, and CSU counters. */
>> +int resctrl_arch_rmid_read(struct rdt_resource *r, struct
>> rdt_domain_hdr *hdr,
>> +               u32 closid, u32 rmid, enum resctrl_event_id eventid,
>> +               void *arch_priv, u64 *val, void *arch_mon_ctx)
>> +{
>> +    struct mpam_resctrl_dom *l3_dom;
>> +    struct mpam_component *mon_comp;
>> +    u32 mon_idx = *(u32 *)arch_mon_ctx;
>> +    enum mpam_device_features mon_type;
>> +    struct mpam_resctrl_mon *mon = &mpam_resctrl_counters[eventid];
>> +
>> +    resctrl_arch_rmid_read_context_check();
>> +
>> +    if (eventid >= QOS_NUM_EVENTS || !mon->class)
>> +        return -EINVAL;
>> +
>> +    l3_dom = container_of(hdr, struct mpam_resctrl_dom,
>> resctrl_mon_dom.hdr);
>> +    mon_comp = l3_dom->mon_comp[eventid];
>> +
>> +    switch (eventid) {
>> +    case QOS_L3_OCCUP_EVENT_ID:
>> +        mon_type = mpam_feat_msmon_csu;
>> +        break;
>> +    case QOS_L3_MBM_LOCAL_EVENT_ID:
>> +    case QOS_L3_MBM_TOTAL_EVENT_ID:
>> +        mon_type = mpam_feat_msmon_mbwu;
>> +        break;
>> +    default:
>> +        return -EINVAL;
>> +    }
>> +
>> +    return read_mon_cdp_safe(mon, mon_comp, mon_type, mon_idx,
>> +                 closid, rmid, val);
>> +}
>> +
> 
> 
> Best regards,
> Zeng Heng


  reply	other threads:[~2026-03-09 16:30 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-24 17:56 [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code Ben Horgan
2026-02-24 17:56 ` [PATCH v5 01/41] arm64/sysreg: Add MPAMSM_EL1 register Ben Horgan
2026-02-24 17:56 ` [PATCH v5 02/41] KVM: arm64: Preserve host MPAM configuration when changing traps Ben Horgan
2026-03-02 17:52   ` Marc Zyngier
2026-02-24 17:56 ` [PATCH v5 03/41] KVM: arm64: Make MPAMSM_EL1 accesses UNDEF Ben Horgan
2026-03-02 17:54   ` Marc Zyngier
2026-02-24 17:56 ` [PATCH v5 04/41] arm64: mpam: Context switch the MPAM registers Ben Horgan
2026-02-24 17:56 ` [PATCH v5 05/41] arm64: mpam: Re-initialise MPAM regs when CPU comes online Ben Horgan
2026-02-24 17:56 ` [PATCH v5 06/41] arm64: mpam: Drop the CONFIG_EXPERT restriction Ben Horgan
2026-03-09  6:42   ` Gavin Shan
2026-02-24 17:56 ` [PATCH v5 07/41] arm64: mpam: Advertise the CPUs MPAM limits to the driver Ben Horgan
2026-03-09  6:43   ` Gavin Shan
2026-02-24 17:56 ` [PATCH v5 08/41] arm64: mpam: Add cpu_pm notifier to restore MPAM sysregs Ben Horgan
2026-02-24 17:56 ` [PATCH v5 09/41] arm64: mpam: Initialise and context switch the MPAMSM_EL1 register Ben Horgan
2026-02-24 17:56 ` [PATCH v5 10/41] arm64: mpam: Add helpers to change a task or cpu's MPAM PARTID/PMG values Ben Horgan
2026-03-09  6:44   ` Gavin Shan
2026-02-24 17:56 ` [PATCH v5 11/41] KVM: arm64: Force guest EL1 to use user-space's partid configuration Ben Horgan
2026-03-02 17:58   ` Marc Zyngier
2026-03-09  6:45   ` Gavin Shan
2026-02-24 17:56 ` [PATCH v5 12/41] KVM: arm64: Use kernel-space partid configuration for hypercalls Ben Horgan
2026-03-02 18:15   ` Marc Zyngier
2026-03-03 16:33     ` Ben Horgan
2026-03-13  9:43       ` Ben Horgan
2026-02-24 17:56 ` [PATCH v5 13/41] arm_mpam: resctrl: Add boilerplate cpuhp and domain allocation Ben Horgan
2026-03-10  6:17   ` Gavin Shan
2026-03-10 10:34     ` Ben Horgan
2026-02-24 17:56 ` [PATCH v5 14/41] arm_mpam: resctrl: Pick the caches we will use as resctrl resources Ben Horgan
2026-02-24 17:56 ` [PATCH v5 15/41] arm_mpam: resctrl: Implement resctrl_arch_reset_all_ctrls() Ben Horgan
2026-02-25 11:03   ` Jonathan Cameron
2026-02-24 17:56 ` [PATCH v5 16/41] arm_mpam: resctrl: Add resctrl_arch_get_config() Ben Horgan
2026-02-24 17:56 ` [PATCH v5 17/41] arm_mpam: resctrl: Implement helpers to update configuration Ben Horgan
2026-02-24 17:56 ` [PATCH v5 18/41] arm_mpam: resctrl: Add plumbing against arm64 task and cpu hooks Ben Horgan
2026-02-24 17:56 ` [PATCH v5 19/41] arm_mpam: resctrl: Add CDP emulation Ben Horgan
2026-02-25  6:25   ` Zeng Heng
2026-02-24 17:56 ` [PATCH v5 20/41] arm_mpam: resctrl: Convert to/from MPAMs fixed-point formats Ben Horgan
2026-02-24 17:57 ` [PATCH v5 21/41] arm_mpam: resctrl: Add kunit test for control format conversions Ben Horgan
2026-02-24 17:57 ` [PATCH v5 22/41] arm_mpam: resctrl: Add rmid index helpers Ben Horgan
2026-02-24 17:57 ` [PATCH v5 23/41] arm_mpam: resctrl: Add kunit test for rmid idx conversions Ben Horgan
2026-02-24 17:57 ` [PATCH v5 24/41] arm_mpam: resctrl: Wait for cacheinfo to be ready Ben Horgan
2026-02-24 17:57 ` [PATCH v5 25/41] arm_mpam: resctrl: Add support for 'MB' resource Ben Horgan
2026-02-24 17:57 ` [PATCH v5 26/41] arm_mpam: resctrl: Add monitor initialisation and domain boilerplate Ben Horgan
2026-02-25 11:14   ` Jonathan Cameron
2026-02-26  3:47   ` Zeng Heng
2026-02-26 10:26     ` Ben Horgan
2026-02-27  3:01       ` Zeng Heng
2026-02-24 17:57 ` [PATCH v5 27/41] arm_mpam: resctrl: Add support for csu counters Ben Horgan
2026-02-24 17:57 ` [PATCH v5 28/41] arm_mpam: resctrl: Pick classes for use as mbm counters Ben Horgan
2026-02-24 17:57 ` [PATCH v5 29/41] arm_mpam: resctrl: Pre-allocate free running monitors Ben Horgan
2026-02-24 17:57 ` [PATCH v5 30/41] arm_mpam: resctrl: Allow resctrl to allocate monitors Ben Horgan
2026-02-24 17:57 ` [PATCH v5 31/41] arm_mpam: resctrl: Add resctrl_arch_rmid_read() and resctrl_arch_reset_rmid() Ben Horgan
2026-03-07  9:29   ` Zeng Heng
2026-03-09 16:30     ` Ben Horgan [this message]
2026-03-10  3:23       ` Zeng Heng
2026-02-24 17:57 ` [PATCH v5 32/41] arm_mpam: resctrl: Update the rmid reallocation limit Ben Horgan
2026-02-24 17:57 ` [PATCH v5 33/41] arm_mpam: resctrl: Add empty definitions for assorted resctrl functions Ben Horgan
2026-02-24 17:57 ` [PATCH v5 34/41] arm64: mpam: Select ARCH_HAS_CPU_RESCTRL Ben Horgan
2026-02-24 17:57 ` [PATCH v5 35/41] arm_mpam: resctrl: Call resctrl_init() on platforms that can support resctrl Ben Horgan
2026-02-24 17:57 ` [PATCH v5 36/41] arm_mpam: Add quirk framework Ben Horgan
2026-02-24 17:57 ` [PATCH v5 37/41] arm_mpam: Add workaround for T241-MPAM-1 Ben Horgan
2026-02-24 17:57 ` [PATCH v5 38/41] arm_mpam: Add workaround for T241-MPAM-4 Ben Horgan
2026-03-01 17:28   ` Fenghua Yu
2026-03-02 17:11     ` Ben Horgan
2026-03-09 17:39       ` Fenghua Yu
2026-03-10 11:26         ` Ben Horgan
2026-02-24 17:57 ` [PATCH v5 39/41] arm_mpam: Add workaround for T241-MPAM-6 Ben Horgan
2026-02-24 17:57 ` [PATCH v5 40/41] arm_mpam: Quirk CMN-650's CSU NRDY behaviour Ben Horgan
2026-02-24 17:57 ` [PATCH v5 41/41] arm64: mpam: Add initial MPAM documentation Ben Horgan
2026-02-25 11:01   ` Jonathan Cameron
2026-02-25 21:10 ` [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code Ben Horgan
2026-02-27 17:04   ` Catalin Marinas
2026-02-26  7:34 ` Zeng Heng
2026-03-03 20:18 ` Punit Agrawal
2026-03-04  9:42   ` Ben Horgan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b95077d7-c036-4a8f-8e42-8f1dc0288075@arm.com \
    --to=ben.horgan@arm.com \
    --cc=amitsinght@marvell.com \
    --cc=baisheng.gao@unisoc.com \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=carl@os.amperecomputing.com \
    --cc=catalin.marinas@arm.com \
    --cc=corbet@lwn.net \
    --cc=dave.martin@arm.com \
    --cc=david@kernel.org \
    --cc=dfustini@baylibre.com \
    --cc=fenghuay@nvidia.com \
    --cc=gshan@redhat.com \
    --cc=james.morse@arm.com \
    --cc=joey.gouly@arm.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=kobak@nvidia.com \
    --cc=kvmarm@lists.linux.dev \
    --cc=lcherian@marvell.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=oupton@kernel.org \
    --cc=peternewman@google.com \
    --cc=punit.agrawal@oss.qualcomm.com \
    --cc=quic_jiles@quicinc.com \
    --cc=reinette.chatre@intel.com \
    --cc=rohit.mathew@arm.com \
    --cc=scott@os.amperecomputing.com \
    --cc=sdonthineni@nvidia.com \
    --cc=suzuki.poulose@arm.com \
    --cc=tan.shaopeng@fujitsu.com \
    --cc=tan.shaopeng@jp.fujitsu.com \
    --cc=wangkefeng.wang@huawei.com \
    --cc=will@kernel.org \
    --cc=xhao@linux.alibaba.com \
    --cc=zengheng4@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®