From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8969514D43D for ; Tue, 23 Jul 2024 10:48:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721731686; cv=none; b=h7xkiXaZCF6X128OhXmr6mYTXAEyKsK8zt4H5zdMoWqgXoRBeWUlwiEiUsV3oco9nq3WqXx2WsrHNtY0VXaGhFMc6cW/6d3zQorgPLon3fUldeZPcnBFTapykbiVUsd9ZbDor1LiUef+JFCJCXlxej1fSOhd5ZkZjh84asrDCoQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721731686; c=relaxed/simple; bh=RY7EnsG1MTgKyezKOtin+mxYZEjmtS8rBOlTFH5iXWg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cJkjrRduJ1v9hUnq/xIzVdA8u4Zz4j+h6Hr1YISLJj83unC+2Kyo187xvk3FDVeZ3X9LeTOo794GU4o5v9nfrCnGqmDKYQYpVTWRudlPuDXko0QTM9CX8E7uOgpskppN63YQGATldR1mae8j+zT+czOGF+Z499V+oYETvmgpGWg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=X24l/kxe; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="X24l/kxe" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721731683; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=is9xWIZrvGL56gb6eZbS8C1QxeZEh2O1wu5yRn9CgAE=; b=X24l/kxeg/RdlXJ0dsgX9ztzX/wqzipTQunTHuMZBLohc2k+OPmb+ANwMlXhOZbBxFrOAP IYDX7uhEdoovWbndO08FMo9zaL0X2vvFGWSs3Vt4FketUujJlQWXQfvIVGhxnIrvmGU3fT I42lEw3qW/gDG5mn9gp9hVKIfaIz9wg= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-647-FDUQlksAOoSyiTja5m8iXA-1; Tue, 23 Jul 2024 06:48:02 -0400 X-MC-Unique: FDUQlksAOoSyiTja5m8iXA-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4266a5c50fcso3384875e9.0 for ; Tue, 23 Jul 2024 03:48:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721731681; x=1722336481; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=is9xWIZrvGL56gb6eZbS8C1QxeZEh2O1wu5yRn9CgAE=; b=voLjrbNSlI7oDNo9V7ukVQPALjybSuzM4i2977/0gplBWMtlMjq+wEN4EjofDZIydP JAAWH/0zTPwRDaY1uX0PEnWUMXjaKAPkvS3u92IWur0GEGx1baDqBFxOTX+CGVgM3Ic4 Q2YueiwjAIynwI6GNqpSMftSCZCQecDGXxQeS7tH8SROWX2rfpNvc596hR1wXagnwQlq +smsEq8OraWxQl6wL+PiWW1zRwwbg5rdh9VE9aRtcZBAiMCHUZ82mdZlF4mdjk9Vsc9B NCtR864MQkq9rg7CR/hlwvGIRP9X+vPqDlkOtV/b8br9ZM8O4RwqeYfMcl7MY0M//TFU RP8g== X-Forwarded-Encrypted: i=1; AJvYcCW1jEPFADPP8lKjpIbdtwM0esVC7hWukTXOijS2BkKNM9LO8HkkBcRdEuX6/Y12fnojeqmitp7ckfBCYdw=@vger.kernel.org X-Gm-Message-State: AOJu0YxH+DR1RJlI8zOIFiBZuvfOstiBjf3BD0hRaDl76ahnXoVAf2IF DgrioFe2GqckW2/sQMHRgcNV716zrm2fJbm7AoOCJDPiYe6R8f5kDxE4GyHElN/5uwwJd2qegCe D1mx0ZX0e8+NmiL/Y/TaqDes8MNR6ViRHz3XZdESe/VbxeIx5BeWBtLVbRPK3UQ== X-Received: by 2002:a5d:64aa:0:b0:35f:1edb:4695 with SMTP id ffacd0b85a97d-369b69b281cmr4252140f8f.6.1721731680712; Tue, 23 Jul 2024 03:48:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE94TBZ+l9LWmG3AlUC+F3co0i3kwynKDwsEMBfPu08pu42j4GyNtxN5Bczw3XZRNRFgmnKqA== X-Received: by 2002:a5d:64aa:0:b0:35f:1edb:4695 with SMTP id ffacd0b85a97d-369b69b281cmr4252128f8f.6.1721731680185; Tue, 23 Jul 2024 03:48:00 -0700 (PDT) Received: from ?IPV6:2a0d:3344:173f:4f10::f71? ([2a0d:3344:173f:4f10::f71]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36878684225sm11265579f8f.9.2024.07.23.03.47.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jul 2024 03:47:59 -0700 (PDT) Message-ID: Date: Tue, 23 Jul 2024 12:47:57 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net: stmmac: fix the mistake of the device tree property string of reset gpio in stmmac_mdio_reset To: Zhouyi Zhou , alexandre.torgue@foss.st.com, joabreu@synopsys.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, mcoquelin.stm32@gmail.com, andrew@lunn.ch, linus.walleij@linaro.org, martin.blumenstingl@googlemail.com, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: "zhili.liu" , wangzhiqiang References: <20240720040027.734420-1-zhouzhouyi@gmail.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20240720040027.734420-1-zhouzhouyi@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/20/24 06:00, Zhouyi Zhou wrote: > From: "zhili.liu" > > According to Documentation/devicetree/bindings/net/snps,dwmac.yaml, > the device tree property of PHY Reset GPIO should be "snps,reset-gpio". > > Use string "snps,reset-gpio" instead of "snps,reset" in stmmac_mdio_reset > when invoking devm_gpiod_get_optional. > > Fixes: 7c86f20d15b7 ("net: stmmac: use GPIO descriptors in stmmac_mdio_reset") > > Signed-off-by: Zhouyi Zhou > Signed-off-by: wangzhiqiang > Signed-off-by: zhili.liu Apart from the more relevant concern raised from Andrew, please note that you should avoid empty lines in the tag area, between the 'fixes' tag and the SoB tag. Thanks, Paolo