Re: [PATCH net 04/12] net: systemport: Fix missing phy-handle parsing for non-fixed PHYs

[Florian Fainelli <florian.fainelli@broadcom.com>]

On 9/22/26 01:50, Nicolai Buchwitz wrote:
> Hi Florian
> 
> On 22.9.2026 01:12, Florian Fainelli wrote:
>> In bcm_sysport_probe(), priv->phy_dn is only initialized if the device
>> tree node has a fixed-link configuration (of_phy_is_fixed_link). When
>> connecting to a discrete MDIO-attached PHY referenced via 'phy-handle',
>> priv->phy_dn remains NULL. This causes of_phy_connect() during
>> bcm_sysport_open() to fail with -ENODEV since of_phy_find_device(NULL)
>> returns NULL.
>>
>> Fix this by parsing 'phy-handle' via of_parse_phandle() and falling back
>> to of_phy_is_fixed_link(). Ensure proper of_node_get() and of_node_put()
>> refcounting lifecycle on both error unwinding and module remove paths.
>>
>> Fixes: 186534a3f832 ("net: systemport: use the new fixed PHY helpers")
>> Assisted-by: LLM
>> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
>> ---
> 
>> [...]
> 
> Not sure this qualifies as a fix, the driver never parsed phy-handle. 
> Maybe net-next material?

Good point, we've only ever used fixed-link so this is clearly not a bug 
fix.
-- 
Florian