From: Gao Xiang <gaoxiang25@huawei.com>
To: Tejun Heo <tj@kernel.org>, Andrew Morton <akpm@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
"Peter Zijlstra" <peterz@infradead.org>, <stable@vger.kernel.org>,
Miao Xie <miaoxie@huawei.com>, <koujilong@huawei.com>
Subject: Re: [PATCH] sched/core: add __sched tag for io_schedule()
Date: Mon, 3 Jun 2019 12:25:02 +0800 [thread overview]
Message-ID: <b95526a4-33cc-12df-020c-011d67ca797b@huawei.com> (raw)
In-Reply-To: <20190531143759.GD374014@devbig004.ftw2.facebook.com>
On 2019/5/31 22:37, Tejun Heo wrote:
> On Fri, May 31, 2019 at 04:29:12PM +0800, Gao Xiang wrote:
>> non-inline io_schedule() was introduced in
>> commit 10ab56434f2f ("sched/core: Separate out io_schedule_prepare() and io_schedule_finish()")
>> Keep in line with io_schedule_timeout, Otherwise
>> "/proc/<pid>/wchan" will report io_schedule()
>> rather than its callers when waiting io.
>>
>> Reported-by: Jilong Kou <koujilong@huawei.com>
>> Cc: Tejun Heo <tj@kernel.org>
>> Cc: Ingo Molnar <mingo@redhat.com>
>> Cc: Peter Zijlstra <peterz@infradead.org>
>> Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>
>
> Acked-by: Tejun Heo <tj@kernel.org>
Cc: <stable@vger.kernel.org> # 4.11+
Thanks Tejun. This patch will be needed for io performance analysis
since we found that Android systrace tool cannot show the callers of
iowait raised from io_schedule() on linux-4.14 LTS kernel.
Hi Andrew, could you kindly take this patch?
Thanks,
Gao Xiang
>
> Thanks.
>
next prev parent reply other threads:[~2019-06-03 4:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 8:29 Gao Xiang
2019-05-31 14:37 ` Tejun Heo
2019-06-03 4:25 ` Gao Xiang [this message]
2019-06-03 8:58 ` Peter Zijlstra
2019-06-03 9:00 ` Gao Xiang
2019-06-03 9:13 ` [PATCH v2] " Gao Xiang
2019-06-03 9:44 ` Peter Zijlstra
2019-06-12 11:34 ` Gao Xiang
2019-06-17 14:20 ` [tip:sched/core] sched/core: Add " tip-bot for Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b95526a4-33cc-12df-020c-011d67ca797b@huawei.com \
--to=gaoxiang25@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=koujilong@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miaoxie@huawei.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®