From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E62CC433F5 for ; Wed, 6 Apr 2022 21:24:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230057AbiDFV0B (ORCPT ); Wed, 6 Apr 2022 17:26:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235209AbiDFVZn (ORCPT ); Wed, 6 Apr 2022 17:25:43 -0400 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFD35B6; Wed, 6 Apr 2022 13:21:01 -0700 (PDT) Received: by mail-pl1-f176.google.com with SMTP id j8so2951085pll.11; Wed, 06 Apr 2022 13:21:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=3mCDtib46azYhoHX+oJIxgCRBmS2BXiXfAVoUab2E94=; b=G/IakRoTiAI0cvScoaTKDrEAtYKZlUYKKy1nKDsjiU+2JCkytRwqvIhWSlYkzzu2UP /pC8bSSOL9fXe1mntksjHBwt4/qDkr49OyaQdYurlfKhU3iB2T/LWCxGviFSxYqzktns ditxD6t8mR2QT/2g+Fo8NsvnUD09JKot3+3tJduNVRminyvWw0sJOk1f9rVLyXdRp+MV 1/15Ra1zkLd3GyrzmeT6KWROsuFtBZHjRg9lxjDh8oCfzNz3Cu0YPBb5VJreliZquwsc W6RMZtepyu6DRTxXOL3LTjjtSUCu6iQpJ+SHUQwm9vsnnG2NJyT2+EYtYR7xsj+dOfNn zjIA== X-Gm-Message-State: AOAM530LnSArg00wUxm7sZxts/G5W1SBNK0/D9KLfDwYH8QwHnDDOYjV EDW5zrt6ihIYJiiNOpEBRps= X-Google-Smtp-Source: ABdhPJxMJ3dzw7N9XtYfZUeTBt4fqiJFyiCzT9SQ10HzjeqEzZaDG86sXBMGiVqyHmM+u0AmHyV3iQ== X-Received: by 2002:a17:90b:3a81:b0:1c6:834e:cd61 with SMTP id om1-20020a17090b3a8100b001c6834ecd61mr11840281pjb.149.1649276461210; Wed, 06 Apr 2022 13:21:01 -0700 (PDT) Received: from ?IPV6:2601:647:4000:d7:feaa:14ff:fe9d:6dbd? ([2601:647:4000:d7:feaa:14ff:fe9d:6dbd]) by smtp.gmail.com with ESMTPSA id y12-20020a17090a784c00b001c6bdafc995sm5468971pjl.3.2022.04.06.13.20.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Apr 2022 13:21:00 -0700 (PDT) Message-ID: Date: Wed, 6 Apr 2022 13:20:58 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2 0/4] rpmb subsystem, uapi and virtio-rpmb driver Content-Language: en-US To: Bean Huo , =?UTF-8?Q?Alex_Benn=c3=a9e?= Cc: linux-kernel@vger.kernel.org, maxim.uvarov@linaro.org, joakim.bech@linaro.org, ulf.hansson@linaro.org, ilias.apalodimas@linaro.org, arnd@linaro.org, ruchika.gupta@linaro.org, tomas.winkler@intel.com, yang.huang@intel.com, bing.zhu@intel.com, Matti.Moell@opensynergy.com, hmo@opensynergy.com, linux-mmc@vger.kernel.org, linux-scsi@vger.kernel.org References: <20220405093759.1126835-1-alex.bennee@linaro.org> <8b3ce88f65fd11523a4d2daab3c617f7089eb1ce.camel@gmail.com> <87r16bk013.fsf@linaro.org> <87ee2ajuky.fsf@linaro.org> <310d20a04bdaf40672592d9ffa950606d2ceaff7.camel@gmail.com> From: Bart Van Assche In-Reply-To: <310d20a04bdaf40672592d9ffa950606d2ceaff7.camel@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/6/22 11:12, Bean Huo wrote: > It is from the ufs-utils. > > So, do you vote to add the UFS RPMB driver based on this new framework > to resolve this conflict? Are any applications using the RPMB code from ufs-utils? It seems to me that the ufs-utils code doe not handle SCSI unit attentions correctly. If a POWER ON unit attention is received as reply to a SECURITY PROTOCOL OUT transaction, the write counter should be reread instead of retrying the SECURITY PROTOCOL OUT command with the same write counter. Regarding adding a UFS RPMB driver: that seems useful to me since multiple applications make use of the UFS RPMB functionality. My understanding is that currently storageproxyd multiplexes UFS RPMB accesses in Android. Thanks, Bart.