From: Erikas Bitovtas <xerikasxx@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Peter Meerwald" <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: iio: light: vcnl4000: add Capella CM36686 and CM36672P
Date: Wed, 11 Feb 2026 12:07:45 +0200 [thread overview]
Message-ID: <b95d7a49-6191-4d85-b725-4a941505b40d@gmail.com> (raw)
In-Reply-To: <20260211-sceptical-frog-of-revolution-fc3cf4@quoll>
On 2/11/26 8:49 AM, Krzysztof Kozlowski wrote:
>
> There was CM36686 v1 and v2, so I do not understand versioning here.
> Also, lack of any changelog.
>
> And how is it supposed to work for us? Try yourself:
>
> $ b4 diff 20260210-cm36686-v1-1-aef68dd46ad4@gmail.com
> Could not find lower series to compare against.
>
> Please implement previous feedback.
>
> Best regards,
> Krzysztof
>
Since I am making changes to the existing driver instead of creating a new one,
I introduced a new patch series. As I mentioned in the cover letter, cm36686 is
fully compatible with vcnl4040, so instead of creating a new binding, I create a
fallback compatible for the device. I probably should have named this patch
series something else.
As for the previous feedback, I added the subject prefix and removed the
redundant phrasing.
next prev parent reply other threads:[~2026-02-11 10:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 20:46 [PATCH 0/2] iio: light: vcnl4000: Add support for " Erikas Bitovtas
2026-02-10 20:46 ` [PATCH 1/2] dt-bindings: iio: light: vcnl4000: add " Erikas Bitovtas
2026-02-11 6:49 ` Krzysztof Kozlowski
2026-02-11 10:07 ` Erikas Bitovtas [this message]
2026-02-11 10:10 ` Krzysztof Kozlowski
2026-02-11 13:32 ` Erikas Bitovtas
2026-02-11 13:37 ` Andy Shevchenko
2026-02-11 13:44 ` Erikas Bitovtas
2026-02-11 13:59 ` Andy Shevchenko
2026-02-10 20:46 ` [PATCH 2/2] iio: light: vcnl4000: add support for " Erikas Bitovtas
2026-02-10 20:53 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b95d7a49-6191-4d85-b725-4a941505b40d@gmail.com \
--to=xerikasxx@gmail.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=phone-devel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=robh@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome