From: "Yang, Weijiang" <weijiang.yang@intel.com>
To: Dapeng Mi <dapeng1.mi@linux.intel.com>
Cc: Jim Mattson <jmattson@google.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Sean Christopherson <seanjc@google.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Zhenyu Wang <zhenyuw@linux.intel.com>,
"Zhang, Xiong Y" <xiong.y.zhang@intel.com>,
Mingwei Zhang <mizhang@google.com>,
Like Xu <like.xu.linux@gmail.com>,
Jinrong Liang <cloudliang@tencent.com>,
"Mi, Dapeng1" <dapeng1.mi@intel.com>
Subject: Re: [kvm-unit-tests Patch v3 01/11] x86: pmu: Remove duplicate code in pmu_init()
Date: Thu, 28 Mar 2024 09:19:52 +0800 [thread overview]
Message-ID: <b961254e-f556-4186-91e2-76f312604e53@intel.com> (raw)
In-Reply-To: <20240103031409.2504051-2-dapeng1.mi@linux.intel.com>
On 1/3/2024 11:13 AM, Dapeng Mi wrote:
> From: Xiong Zhang <xiong.y.zhang@intel.com>
>
> There are totally same code in pmu_init() helper, remove the duplicate
> code.
>
> Signed-off-by: Xiong Zhang <xiong.y.zhang@intel.com>
> Signed-off-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
Jim has already added RB tag for this patch in v2, you may add it here.
> ---
> lib/x86/pmu.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/lib/x86/pmu.c b/lib/x86/pmu.c
> index 0f2afd650bc9..d06e94553024 100644
> --- a/lib/x86/pmu.c
> +++ b/lib/x86/pmu.c
> @@ -16,11 +16,6 @@ void pmu_init(void)
> pmu.fixed_counter_width = (cpuid_10.d >> 5) & 0xff;
> }
>
> - if (pmu.version > 1) {
> - pmu.nr_fixed_counters = cpuid_10.d & 0x1f;
> - pmu.fixed_counter_width = (cpuid_10.d >> 5) & 0xff;
> - }
> -
> pmu.nr_gp_counters = (cpuid_10.a >> 8) & 0xff;
> pmu.gp_counter_width = (cpuid_10.a >> 16) & 0xff;
> pmu.gp_counter_mask_length = (cpuid_10.a >> 24) & 0xff;
next prev parent reply other threads:[~2024-03-28 1:22 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-03 3:13 [kvm-unit-tests Patch v3 00/11] pmu test bugs fix and improvements Dapeng Mi
2024-01-03 3:13 ` [kvm-unit-tests Patch v3 01/11] x86: pmu: Remove duplicate code in pmu_init() Dapeng Mi
2024-03-28 1:19 ` Yang, Weijiang [this message]
2024-03-28 1:21 ` Mi, Dapeng
2024-01-03 3:14 ` [kvm-unit-tests Patch v3 02/11] x86: pmu: Enlarge cnt[] length to 64 in check_counters_many() Dapeng Mi
2024-03-25 21:41 ` Jim Mattson
2024-03-27 6:40 ` Mi, Dapeng
2024-01-03 3:14 ` [kvm-unit-tests Patch v3 03/11] x86: pmu: Add asserts to warn inconsistent fixed events and counters Dapeng Mi
2024-03-27 5:30 ` Mingwei Zhang
2024-03-27 6:43 ` Mi, Dapeng
2024-03-27 13:11 ` Jim Mattson
2024-03-28 9:29 ` Mi, Dapeng
2024-01-03 3:14 ` [kvm-unit-tests Patch v3 04/11] x86: pmu: Switch instructions and core cycles events sequence Dapeng Mi
2024-03-27 5:36 ` Mingwei Zhang
2024-03-27 8:54 ` Mi, Dapeng
2024-03-27 17:06 ` Mingwei Zhang
2024-03-28 10:09 ` Mi, Dapeng
2024-01-03 3:14 ` [kvm-unit-tests Patch v3 05/11] x86: pmu: Refine fixed_events[] names Dapeng Mi
2024-03-27 5:38 ` Mingwei Zhang
2024-01-03 3:14 ` [kvm-unit-tests Patch v3 06/11] x86: pmu: Remove blank line and redundant space Dapeng Mi
2024-03-27 5:38 ` Mingwei Zhang
2024-03-28 1:23 ` Yang, Weijiang
2024-03-28 10:12 ` Mi, Dapeng
2024-01-03 3:14 ` [kvm-unit-tests Patch v3 07/11] x86: pmu: Enable and disable PMCs in loop() asm blob Dapeng Mi
2024-03-27 6:07 ` Mingwei Zhang
2024-03-27 8:55 ` Mi, Dapeng
2024-04-08 23:17 ` Mingwei Zhang
2024-04-09 0:28 ` Mi, Dapeng
2024-01-03 3:14 ` [kvm-unit-tests Patch v3 08/11] x86: pmu: Improve instruction and branches events verification Dapeng Mi
2024-03-27 6:14 ` Mingwei Zhang
2024-03-27 8:59 ` Mi, Dapeng
2024-01-03 3:14 ` [kvm-unit-tests Patch v3 09/11] x86: pmu: Improve LLC misses event verification Dapeng Mi
2024-03-27 6:23 ` Mingwei Zhang
2024-03-27 9:18 ` Mi, Dapeng
2024-03-27 15:20 ` Yang, Weijiang
2024-01-03 3:14 ` [kvm-unit-tests Patch v3 10/11] x86: pmu: Add IBPB indirect jump asm blob Dapeng Mi
2024-01-03 3:14 ` [kvm-unit-tests Patch v3 11/11] x86: pmu: Improve branch misses event verification Dapeng Mi
2024-01-24 8:18 ` [kvm-unit-tests Patch v3 00/11] pmu test bugs fix and improvements Mi, Dapeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b961254e-f556-4186-91e2-76f312604e53@intel.com \
--to=weijiang.yang@intel.com \
--cc=cloudliang@tencent.com \
--cc=dapeng1.mi@intel.com \
--cc=dapeng1.mi@linux.intel.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=like.xu.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mizhang@google.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=xiong.y.zhang@intel.com \
--cc=zhenyuw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®