From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5A063403E1 for ; Thu, 30 Jul 2026 08:38:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.20 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785400724; cv=none; b=bqGRRGV0UkIMjKFlx6qgXWpfIJIr3k4BlBCAREA5RgegC8f5zyXNNLxeOQsUM1p/BU/c4iyLIpwzKq3Y3/Zjq8TgNMgxYA9667OHJNrrWKETIYYl9QEb1zqc/erIf0fFgCrtUK9dCIvJEFglbKcC3TBDCRKP89CVU3LXKGodn2s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785400724; c=relaxed/simple; bh=ymVu4xx50BgWNM0vGJbFCoGjLrqx4ktDs+kmUwAWAtg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=Gg+ihU4UI9c/iG1C/+ukRDnGIhGU3ezjOiyqGKD/PUW1Su2pktwmCEcB5mVBM9kxaNgAc/2adSsgYkN8GavLMHEj9ZV5XLAawJXarj5UItqQzg4oJ7ocYCEE3CNleV60wA+ZzdGVkXVpwVY7DCp5QEI/baODZi0SKMTgjG7QZgo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=HEuiXn1/; arc=none smtp.client-ip=198.175.65.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="HEuiXn1/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1785400722; x=1816936722; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=ymVu4xx50BgWNM0vGJbFCoGjLrqx4ktDs+kmUwAWAtg=; b=HEuiXn1/DQzrvQ7BhHnyllYW27WNTin7ABIAP2IcBnk+8haP8t25H2XR oJtPiHN7MuKDm96lPx4sDaF1GG08SkhypyP11Q9LnFzBoDWiHmZgXNm6d jY25gNE2c3IAyB+TFldZywWa7u+9eZyOoZWGRzCeHb7jNWCzymafWUJ6Q kwey2xDI+OYDlWjI0m7rJgBj/Yu9xPvne0jNwk3If4Ur1dRP/rqn7QeAi olPQ7J+Bj8xbJ5G0X+RrbjoKLXfOgMc5P0F93LIGY7DuDHVj53avgjbow xBBOcpJS4JP00K5j0dmY7//Hn2VIKlJZ/JM9+5iLfiIdsHWt8bTWmCbxa g==; X-CSE-ConnectionGUID: bCSLP9JHR0eGK2TVnT3Z7g== X-CSE-MsgGUID: TNx8M3myQQC9bmEjQES4Ig== X-IronPort-AV: E=McAfee;i="6800,10657,11859"; a="85778210" X-IronPort-AV: E=Sophos;i="6.25,194,1779174000"; d="scan'208";a="85778210" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jul 2026 01:38:41 -0700 X-CSE-ConnectionGUID: vzuzgr2ZSiKF3WiWYj6b4A== X-CSE-MsgGUID: EZvh6iSqRtqTB/7gSgDRGg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,194,1779174000"; d="scan'208";a="264513009" Received: from fpallare-mobl4.ger.corp.intel.com (HELO localhost) ([10.245.245.160]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jul 2026 01:38:37 -0700 From: Jani Nikula To: Doug Anderson Cc: Pengpeng Hou , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] drm/bridge: ps8640: propagate AUX transfer register errors In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland References: <20260723103509.2-ps8640-v2-pengpeng@iscas.ac.cn> Date: Thu, 30 Jul 2026 11:38:33 +0300 Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Wed, 29 Jul 2026, Doug Anderson wrote: > Hi, > > On Mon, Jul 27, 2026 at 4:40=E2=80=AFAM Jani Nikula wrote: >> >> On Thu, 23 Jul 2026, Pengpeng Hou wrote: >> > ps8640_aux_transfer_msg() programs the AUX address registers, starts t= he >> > AUX transfer, waits for SWAUX_SEND to clear, and reads the AUX status >> > register. Several of those regmap operations have return values, but t= he >> > function only checks a stale ret after the status read. >> > >> > Propagate failures from the address write, transfer start, completion >> > poll, and status read. This avoids returning a transfer length when the >> > bridge register transaction or AUX completion wait failed. >> > >> > Fixes: 13afcdd7277e ("drm/bridge: parade-ps8640: Add support for AUX c= hannel") >> > Signed-off-by: Pengpeng Hou >> > --- >> > Changes since v1: https://lore.kernel.org/all/20260623060635.16064-1-p= engpeng@iscas.ac.cn/ >> > - include the AUX address and length in the address-write diagnostic >> > - describe poll failures without assuming that every error is a timeout >> > - add the Fixes tag suggested by Doug >> > - rebase onto the current drm-misc-next tree >> > >> > drivers/gpu/drm/bridge/parade-ps8640.c | 27 +++++++++++++++++++++----= -- >> > 1 file changed, 21 insertions(+), 6 deletions(-) >> > >> > diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/= bridge/parade-ps8640.c >> > index 96332721cb69..56b48f8feab6 100644 >> > --- a/drivers/gpu/drm/bridge/parade-ps8640.c >> > +++ b/drivers/gpu/drm/bridge/parade-ps8640.c >> > @@ -257,8 +257,14 @@ static ssize_t ps8640_aux_transfer_msg(struct drm= _dp_aux *aux, >> > addr_len[PAGE0_SWAUX_LENGTH - base] =3D (len =3D=3D 0) ? SWAUX_N= O_PAYLOAD : >> > ((len - 1) & SWAUX_LENGTH_= MASK); >> > >> > - regmap_bulk_write(map, PAGE0_SWAUX_ADDR_7_0, addr_len, >> > - ARRAY_SIZE(addr_len)); >> > + ret =3D regmap_bulk_write(map, PAGE0_SWAUX_ADDR_7_0, addr_len, >> > + ARRAY_SIZE(addr_len)); >> > + if (ret) { >> > + DRM_DEV_ERROR(dev, >> >> DRM_DEV_ERROR() is deprecated in favour of drm_err() or dev_err(). > > Good point. I'm inclined to land this anyway, though, since this is > nominally a bugfix and it matches the error printing in the rest of > the function. Any objections? It would be a nice future cleanup to fix > the error printing in this driver overall to use the non-deprecated > functions... Up to you. BR, Jani. --=20 Jani Nikula, Intel