From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55E88241CB7 for ; Mon, 13 Jul 2026 10:37:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783939062; cv=none; b=RDcK9ulpZ6gMyTJTmhXo+c9T80JGHMvwMOCcK+x0mK4yfIH5HV1ANDT9WrLxjjdOl5gkpxLqlPb9XIoudHHY3S4ASyxf3/OmxqZ4P81LH8f0XkNRsRgfB82m26vB5ey1eIoj+B6IK/R5oVzqn2ElKtDzCG+sFQKiKaSLuq7Bo70= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783939062; c=relaxed/simple; bh=3m6DR4cSmxHyJCDJk9YiqjcbJJEkVqxy+iN4N4Qm6Z8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nj3OVi8cmutJzPjxFmG6BQnF6xmZ1JMr5GJfs/fQb9KCdwzHCMVai4JA3K6pkrT9Z1WDe3MDSZaSE1qf6zSZuyMKE1RhjUMRUSt37AB4jauh05YKlKuGgLGQHX8XuZjFjtmJIsv3ezVPqR9iSZ4AwB6/7qrKNi3SFrGEoa4Okos= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Jiya2In7; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TSNxYNdT; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Jiya2In7"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TSNxYNdT" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66D6NhCj507010 for ; Mon, 13 Jul 2026 10:37:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= hLzz6wWDeeMpdSkdKzw84YBlgDHYl4DWCf56D/vBLUE=; b=Jiya2In7+lIR6dpl kG//M8VFJ7nKNSNW8ngMtqL4nfi5kxEluD68zBDUE3n4Kh2hYVmTP0rUSZik+bSG WDDiEaErEJVm6emkVMLSdBs/kOi1DY01r+3KcFZixIHj0OEOQssxEYRFlJguRmLk Vs8UAGGHofJd3JFxeYwhjOQIibRPJbjsml0M0K+LVAFtntHiDDrcWZqT4w/eA60j JgCetDfe9deXFLANAY5LdWv9ei58d1rLvv14l4YHNIVhQzUKyLPUuHhOu0c8mmky LjavLWnqGniUWHU7kgtG3sFPcXgFEfvumdWZpMbWggAY4lwqyhDEMFFsNe5xIdKz EztttQ== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fctc8h30y-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 13 Jul 2026 10:37:40 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-51c1e777a15so6149541cf.2 for ; Mon, 13 Jul 2026 03:37:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783939059; x=1784543859; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=hLzz6wWDeeMpdSkdKzw84YBlgDHYl4DWCf56D/vBLUE=; b=TSNxYNdT3wM1NnOmaa3TrGC5oQBfBcxQgHxVxQhdumGN39ocJPcs7JYr5umNMi/MQy 1zTXHYQt4CQvxtalMEH5NJxLweK7MsJ8qkEkA56SKpoYOWtwSRmjJ9Nm+DfzRpvgEa3l FieAINTzGhOARt3nmA2Z+jodpJn9ALyKNx7twc38/sgmiHTuAP1qHv8CIDC+Wpoiw+Ep bqHnUApWPnAVSBjGBPz5fyy9aoNUWMmnzD7PkOwCUAvuCwqH15LI+exqHMLxqbTa2lUC ET91g5XJTpOMuHnos/X/zQ2ZRA++Y/Zx7zoQZDpIRDb+oWeTv5k6UGLjHVzbAIZOcr4W mhQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783939059; x=1784543859; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=hLzz6wWDeeMpdSkdKzw84YBlgDHYl4DWCf56D/vBLUE=; b=Raa62nLV/q/64UmLiFMbaPtjoOJjw6N3jXWFYIUw8+TxqRRXqp46XKIzlIGgigBqNY nFpIBjT6dKwHy+rg3w7gVW9SVj5+2irrAiCD+afzFrCShfbMzvUF1S9nFYPZ1ZPDBbQt dvjQjqZfkQ9zfYyx89e0QHEc0dTTbjoFVWSvL7sDJ8wjNnKQL+X6iJ2a4r45VNLdo+Er kDdY5Fs+MxsYgyPgU8i/Ef1Ys2dEOGuKm11fJzhw8t3q/pAXeV9DwdPdln8e9iqwGbDI vBUscHVtALXtmuHaiy3oRG54EeA4oQ9RCqYrmUwcmwruW/VoeWTgVYLXgjOgfZwaMzTS NGgA== X-Forwarded-Encrypted: i=1; AHgh+RqdMzbjVyK4dGIc7yDI587TUep+MAz7UDyz9aWumVH9wMdaXU0yRvrR5Pqm/f0ha7ryRebye21i7wcVOiA=@vger.kernel.org X-Gm-Message-State: AOJu0YzaLeL2bHBC7OYPao77AW0dK9RCaH7brxmCJ6ktHHbZQIcCiCv1 VOxZ7tNnmOHZ3rClFJx5S7O2F8X8+eqFQQWPoC+2+/9twDWCb0VUW9qHvPTUHy0FWRJU7whYXRa WDBJqGIa4RBtAVlgt2m6eQbMmg8U3Dp46mPygQf6N3WTYrBieN83d2tNGkH68ZsSb9Lo= X-Gm-Gg: AfdE7cnoDIXRHIiElZvjnSSAMddvZhK0pHVm8RuzkvjqyOky6FBocXKJpjE9AgUBt+Q 0mTEJcBcVw81Mbi7uOYyjIY0WLjLZPeXHHTVnIBF23Mk8uyTVKvnJPKmIxIqJNlAL/eeYUt6en1 +5b1hVgS2udc0z/uGwiYOBQynPodX3DsTJIwClT6Or+j6a4TdTbFbtam8v65wKROzpppD/SfYQV DU5sW5WsklTD3mieT9J/COS5uKyLzTFNCDF6HSRxVbMUiQgKqRegT9SYkgFEhw0gw6eHz28R1zG XbMojxlPrE4g7r8u5+rbX94blBQ+Fic0TfAfk2qSKFuRxfS7FEntPdR6dWt001mQhLqEoWefl7g /wJpWOvGv9ZnxVlwOuzrwdKxZ+nvSDGHEeWU= X-Received: by 2002:ac8:7dc7:0:b0:51c:857f:9c1c with SMTP id d75a77b69052e-51cbf3aeda3mr70349261cf.11.1783939059554; Mon, 13 Jul 2026 03:37:39 -0700 (PDT) X-Received: by 2002:ac8:7dc7:0:b0:51c:857f:9c1c with SMTP id d75a77b69052e-51cbf3aeda3mr70349131cf.11.1783939059035; Mon, 13 Jul 2026 03:37:39 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c15d5de95e6sm722744166b.39.2026.07.13.03.37.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jul 2026 03:37:38 -0700 (PDT) Message-ID: Date: Mon, 13 Jul 2026 12:37:35 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] firmware: qcom: scm: fold tzmem into the qcom-scm module To: Sumit Garg , linux-arm-msm@vger.kernel.org Cc: andersson@kernel.org, konradybcio@kernel.org, linux-kernel@vger.kernel.org, bartosz.golaszewski@oss.qualcomm.com, harshal.dev@oss.qualcomm.com, Sumit Garg , kernel test robot References: <20260713045811.484554-1-sumit.garg@kernel.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260713045811.484554-1-sumit.garg@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: _NUpdkugedrbXfZVFn7UTYbwb7iMjB8F X-Proofpoint-ORIG-GUID: _NUpdkugedrbXfZVFn7UTYbwb7iMjB8F X-Authority-Analysis: v=2.4 cv=UtRT8ewB c=1 sm=1 tr=0 ts=6a54bff4 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=VwQbUJbxAAAA:8 a=QyXUC8HyAAAA:8 a=EUspDBNiAAAA:8 a=TyXpd46oalzF_ysv1t8A:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEzMDEwOSBTYWx0ZWRfX63MW8Bm+kFde IoWzfsYF0VDv0P9+rSo83hGZGKmbifeI+Qz81PLbkmapg7PKuqLylZddKa8odycNTw8ZSU5dZsh wvm7n1rd1GrHUfa7cN7ZBaTaPNN1QBI= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEzMDEwOSBTYWx0ZWRfX31eJflIIQkhc 5h+y7+ttronOrVGBpc5zN/hAD2jSAsCj8ipIS878D/wzpHMhg7XIsTWi8uVsrWum07ZL4zO/vkZ +4SZXTdJJ9NVQWZgvRdtc86kJaJwxDkwoN2a5ofGKEBwyf6YcKywx0rWYNDv7Xo75pZdtxcUmMb QfkcOwkrkbxsbSSG7GrqaCcge/GAqVec5GGKbYUUnXbq3sxvf3NKBd6zA9T/0GhKf9aVe19Pp8m oKwKmyMapF+PlyO1dyC6jYK66qb3pSyBWzJ99sXc0SwYQPfpYJbOtRGztp9LW6SqlDAmxwfVzRc Oau0GlQkLmmkhLag7oXTNsi2e+tBkkE1PMsGh8fZGJjTodxHpf3sdUpkI6i4ozbxq25s1b7kS2j DO4q7Tz/ysQ3aqICzSPQNnFmRnMBKc6XjdhK7KOER5pw1kXSYePhMGqJRu2RV1vdf+kOwVzKnz3 n3N51DI4MqFGmXyBWbQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-13_02,2026-07-10_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 suspectscore=0 bulkscore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607130109 On 7/13/26 6:58 AM, Sumit Garg wrote: > From: Sumit Garg > > qcom_scm and qcom_tzmem have a mutual symbol dependency: qcom_tzmem > calls qcom_scm_shm_bridge_{enable,create,delete}() while qcom_scm > calls qcom_tzmem_{alloc,free,to_phys}() and qcom_scm_get_tzmem_pool(). > When both are built as modules this results in a circular module > dependency and depmod fails: > > depmod: ERROR: Cycle detected: qcom_scm -> qcom_tzmem -> qcom_scm > > QCOM_TZMEM is an invisible tristate that is only ever selected by > QCOM_SCM, so the two are always enabled together. Build qcom_tzmem.o > as part of the qcom-scm composite module instead of as a separate > module. This breaks the cycle since the mutual symbol references > become intra-module. > > With tzmem now internal to qcom-scm, the shm_bridge helpers are no > longer used outside the module, so drop their EXPORT_SYMBOL_GPL() and > move the declarations from the public header to the private one, > alongside qcom_scm_shm_bridge_enable(). > > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202607122327.3zkZCUaB-lkp@intel.com/ > Assisted-by: Copilot:claude-opus-4.8 > Signed-off-by: Sumit Garg > --- > drivers/firmware/qcom/Makefile | 2 +- > drivers/firmware/qcom/qcom_scm.c | 3 --- > drivers/firmware/qcom/qcom_scm.h | 4 ++++ > include/linux/firmware/qcom/qcom_scm.h | 5 ----- > 4 files changed, 5 insertions(+), 9 deletions(-) > > diff --git a/drivers/firmware/qcom/Makefile b/drivers/firmware/qcom/Makefile > index 48801d18f37b..55751d282689 100644 > --- a/drivers/firmware/qcom/Makefile > +++ b/drivers/firmware/qcom/Makefile > @@ -5,7 +5,7 @@ > > obj-$(CONFIG_QCOM_SCM) += qcom-scm.o > qcom-scm-objs += qcom_scm.o qcom_scm-smc.o qcom_scm-legacy.o > -obj-$(CONFIG_QCOM_TZMEM) += qcom_tzmem.o > +qcom-scm-$(CONFIG_QCOM_TZMEM) += qcom_tzmem.o Does it make sense to squash the kconfig entries too now? Konrad