From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1761339AbdJQW7D (ORCPT <rfc822;w@1wt.eu>);
        Tue, 17 Oct 2017 18:59:03 -0400
Received: from mout.gmx.net ([212.227.17.21]:54794 "EHLO mout.gmx.net"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753744AbdJQW7A (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 17 Oct 2017 18:59:00 -0400
Subject: Re: scripts/checkpatch: Concatenated strings should use spaces
 between elements
To: Joe Perches <joe@perches.com>, Andy Whitcroft <apw@canonical.com>
Cc: linux-kernel@vger.kernel.org
References: <20171017211751.31343-1-xypron.glpk@gmx.de>
 <1508280192.6530.31.camel@perches.com>
From: Heinrich Schuchardt <xypron.glpk@gmx.de>
Message-ID: <b96a64ab-326e-3b7e-21df-3a3487f02342@gmx.de>
Date: Wed, 18 Oct 2017 00:58:53 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <1508280192.6530.31.camel@perches.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:vcRmR7qoxr0+0K6ofJFkfSDmIpVBkixYogdGgF1GjueHmKRjTkD
 l7y4VvWYYe5MESWXZwu6igNnzW5TkrE2mFP9Q2uo6gRT/zCpWQqjEBVNZE90LzJBmAlyQZS
 J0/2zR+viGZX84UxflMUY6mdSYObfDswfcCeoQUULY0oEkE7WeIfP/Ebc2IY4CLwpIcsHB+
 snVDlEq+cDuyyNDp+zLLg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:ENzumPb34nM=:v7Mx0hc8NgaeZAMPF5MCUo
 DQIlRBWjkkkBThhkD8GfGC4FR40a6lLGS4duTOOk7iJoNEyPIHyzrtbX7Ao3uuL7YPy1B9s60
 YKQfsIIcW6iUVejKWDC+sqn2dy3gMaHUdiqCEyb034f+qHM+gc/ZAZo0BwmtfJcL9+9H6kDUn
 lVbX2e1GDUYSXRhZXGGD84hFTyn5WUkO4n51hAgVcjByxHOzaQSRfKPKJVF6BJaKUTFVYbXH7
 dmIVrzcgPXIdX0E/JYTLoTeE2xt0bVtzf2ZPZn/+3IOX4354EW/YAblhFZBhseIDDJQFNS0Vq
 LAkvLeCcYn9x8U2vMqAZlgT5l4hVljc38cJUCH1nmvN9huaBFtHsM4FqVXiCl3tVOljKSCv44
 uGk2y4MmfVX4rd6kj9Wu5+yf8pRM3ml/I9WbqlYKovAd4YW/j0cnc93QagLVsaQInvSJmvSzi
 21JVz8RmxWmmiDAFywgs+TrQFUKGQBu24lAVzEyJkcuP0DwJPKfl7NuosxXrQHQWooKUWeVBJ
 JlvmJtUin/R7pKj8QPuI2o7hK7AXn6L7hOWJhsWABDykPmhNfTw8VGiYf2ZWniTBjzj12jpLp
 X+38V6ZNsUTcnFeaYlcriZjiO8LIkYecFTAue7Xo9WqL2g8Ee+uRK33kh3yv1rNpyO4sTPeFL
 7D3kEFeGJXRuk71FdxBpo+B/9Mjyx1lZwHPYX9n9WvzdXr2UqnFwyUTXqakaMynjQvlqJNNPC
 tAFBTtL+yh2IWFuSr33LUd4w2jj6UwMOpB9vLLhJfZSR/kDNLNSnXVNYDIPSAkxj04cp1csMG
 7JXG/2V4eM0hjl9LgnpdpCmHk3mcnb01oqqIrqjlVf9kSLlMrE=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/18/2017 12:43 AM, Joe Perches wrote:
> On Tue, 2017-10-17 at 23:17 +0200, Heinrich Schuchardt wrote:
>> This patch creates a warning (CHECK)
>> "Concatenated strings should use spaces between elements"
>>
>> There are no concatenated strings here.
> 
> Yes, there are.
> 
>> (checkpatch is also used in the U-Boot project where wide strings
>> occur in the EFI implementation.)
>>
>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>> ---
>>  test.c | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>  create mode 100644 test.c
>>
>> diff --git a/test.c b/test.c
>> new file mode 100644
>> index 0000000000..dfd33cd765
>> --- /dev/null
>> +++ b/test.c
>> @@ -0,0 +1,6 @@
>> +#include <foo.h>
>> +
>> +void foo(void)
>> +{
>> +	test(L"\"");
> 
> In this case, L must be a constant string and you
> are concatenating L and "\""
> 
> 
See ISO/IEC 9899:1999

6.4.5 String literals

<cite>
A character string literal is a sequence of zero or more multibyte
characters enclosed in double-quotes, as in "xyz"
A wide  string  literal is  the  same, except prefixed by the
letter L.
</cite>

L"foo" is a literal of type wchar_t * and not two strings.
L is a qualifier and not a constant string.

Just like ULL in 10ULL.

Regards

Heinrich