From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32E903009F6 for ; Wed, 18 Feb 2026 10:42:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771411332; cv=none; b=ncr97wCrLakLvqVCKbRjmVzTopzdVBUyuNsuEF8gKiC94g5ippPOfK+qe1Jsbhhj4OhS/laryDVmh+9w3YyMgeFEl0WRAdkciZtNlpOT54fkYiUEPqBVYCiy5oTn00QFulREOVpjeC6IqYzunusHk19mqhJYeINroaKLg/kjZFs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771411332; c=relaxed/simple; bh=j05/cxfltucXRwON8QSfjH8144PoGhffNAKPXlMCtjw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AubiH+BfIid6PbLzxKKO8YTsQ//S/1OJZTZ7ic2a8tAGTdC6e0Pb885ifrUBCaXe8T1ssQDDMh2MhSgOViEvV3z9VJqFw8GATpf8iqucqUikj/SIvFmXaq3XHVVVrDIltYLgQladaN6Vxq7anQtW6/7epiPn5ZWGphxKr/SFI9M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HOCrC2tk; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Is7JdY86; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HOCrC2tk"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Is7JdY86" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61HN6KWZ413923 for ; Wed, 18 Feb 2026 10:42:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 50M2aZYa0M5or/awTAHouzvOMiiz02HpR0Cx2PU+naE=; b=HOCrC2tkGG1ZYOe6 HcTDt/NxHg+C+q40RhtuyEMR4htzanaDOvS0TmE+6C+329+7zJaLMz5Rj03kJeUt gn3QiqoR+N5lzFpqWffPx7hVigKzjPhXjbqdyKWZtapUHfJhGjEBUJGOHrQCDdjx Nn55OJK4ajp1uEQH8Ayg6zOqSarnTqk1iCCw694m/apy11YDdds9wO58WjOt7bQ2 QE0Z/sugrrfjJrdPF6wlZYNdL9/4fdWQVU3DiJU2hqn6ZsnZSW9E9JoA514DOngS RpKaD+vZf34hd+z8VFFEuhSCPgvyMYIJwjxJcxkToOg5ycjWQlRM3sfdWgJYMLzF USrYdA== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cd1q6sfbb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 18 Feb 2026 10:42:08 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-8960257db65so39490836d6.3 for ; Wed, 18 Feb 2026 02:42:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771411327; x=1772016127; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=50M2aZYa0M5or/awTAHouzvOMiiz02HpR0Cx2PU+naE=; b=Is7JdY868+ymInNH88zQ8rJdWpjC/5tKZH/ca+LXNRZGHorimOCg8fa1jEjI8jd8Z6 3GmqN6GPOJsH0ITx75rbcWTSqe7fBEqIITMVb691g6fH6rCOdDjTm6PJN5BCgFEAHMtN y2U5Osu3JRgjBjmF08KyxRB3NYFE3XFzjFq5Eoh+HnolhH0qKERTjeW9OB7C1SpxfyoT Zf3YRCDj57UK8lPkf3cxuZXnHnqqsL1JAMtmZIcp5eGXK8i1/1AIjBIz9pfo98HGBKWc KWu/tmhJpHJq9UNZDBGb+hB9tkbgO0F5tGL6yKmPv5IF1xmodG8gNRIWSUXkRfTvZFXV osLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771411327; x=1772016127; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=50M2aZYa0M5or/awTAHouzvOMiiz02HpR0Cx2PU+naE=; b=EulhKHfKAxPgnHx/PL3CSwdixA9dEfX0o8EKXKIn9QCAX2ANW2ORrivcRpE7B4mOYz n3FgjSpqWqgZUio5eIySGcCJg5k5rmkWFJoxMamOVviznXto4T4mENYwvebfB+7Ct9Nw XHseWLRUKN47NK80SAk3ZnoUtOh9CZBT3/XK1tXTWaIjV+/o8/lqoxhxMSRZmBZ8R2sL 9LUpUJZ5F62kNylySgxUlyj1tR9zNmjBnrIrT5dLs0Htpf/Q88yQ8YeHqoZ2ug56kF6p KTpUOrQYAuaaeFjzSFr89RllfM8y4oFEYoGV/8GQIcvaa1WPJuY6lE3k0rnARUj8n7dn 4DoQ== X-Forwarded-Encrypted: i=1; AJvYcCVoZHFmbL3U6mGXBZIMLC+9eZ/DL66N8r5Elwjdcej32zFUK4dGnTZ2OIJHpEGseD2oHYbkx6GyA+wv2p0=@vger.kernel.org X-Gm-Message-State: AOJu0YxBY2XU+npvumqqWCdf+BMzwSAlDsfihlwb/dwsJlzSddoiaQD4 l6KrnShRcmGTC1l/R/A8CGV7J5VvK9K4BbdXgn81r6p0NmCDx8Cz1G62Zs12jxG5XlpKJldR4wJ NIIAn3JYQJ45k0pRoZfPjPAgTdhcVVHeZIhIzpjPE+xLB4WiaGq4igSQ4RJ5Fg86ZtSU= X-Gm-Gg: AZuq6aLTonlnxp/zDGtdrmBfACh/8w0RHSRFXzdOkcIiksJ80okBf88+AWSYtHAvZjj 6jLGSwRwPOikoFo3T/ZmUg19fWUumFb4OFirUy+QEmglXsl0YsAt+1WdRDSbtj+tZBLUOtb6Vnn L+r0TYizlB9RGp+fWjbbeGgr2XBM/T+niWj48hf17CYzaOMSLr5hIz2+GzUISZ5S9Ot3PpflfHk RE0ZazImLkq0ehAkX+o4l8iPR+HOExoJDXTbtPw9FGHdQ9tAbEsEzgQoW8IYbifPdgxkb+TArz2 nYgtqV5sCrjo8yCDYjxNOXMzsFlK57AxejzjAZa/Vi3lUnRNs72OUUfzS65mRTKh/bogwuCyobU 2Q2/enzPOcLZcA0OOWFQiojXT/zvKOZ0FOK6sj383gB+yh5+V0oSALwv61/x5cNnTyHx4IA4vSL iOaHI= X-Received: by 2002:a0c:e002:0:b0:895:3b2c:7708 with SMTP id 6a1803df08f44-897346241b8mr173741596d6.0.1771411327308; Wed, 18 Feb 2026 02:42:07 -0800 (PST) X-Received: by 2002:a0c:e002:0:b0:895:3b2c:7708 with SMTP id 6a1803df08f44-897346241b8mr173741416d6.0.1771411326901; Wed, 18 Feb 2026 02:42:06 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-65bad3e390bsm2923880a12.17.2026.02.18.02.42.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Feb 2026 02:42:06 -0800 (PST) Message-ID: Date: Wed, 18 Feb 2026 11:42:04 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] arm64: dts: qcom: add device tree for SDM845-HDK To: Dmitry Baryshkov , Bjorn Andersson , Michael Turquette , Stephen Boyd , Ulf Hansson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20260217-sdm845-hdk-v1-0-866f1965fef7@oss.qualcomm.com> <20260217-sdm845-hdk-v1-4-866f1965fef7@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260217-sdm845-hdk-v1-4-866f1965fef7@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=K60v3iWI c=1 sm=1 tr=0 ts=69959780 cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=-UWIQ00ppj3yYQeD8CsA:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-GUID: NDUoxzdxCAMyTGu3nsDWIlGpST5bDMP9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE4MDA5NSBTYWx0ZWRfXyqb5sWTlPQdc B3ibLFlryAQw4Y2dP4CeNkqGEQkEwnY6mfEbaQfKSFYKNiE8lKwAuAyCxs9CEAQvU4j1QX15o9P qXmLTDAhHI3ddUZUk+iO7KZU7XRmBxuJ10yRQp5V3vhhRFVUvRwnBOQa2NzhMNS01DY2ijNU0n9 lG7oyj3TiLxrBETVgk5C26ibyPHL2u7vFqBthKW9h8HhsU5XGjG7XZCtCkg9SL60qmxN6WIJsJP XQv8mLSGYmKfZK3M39Ch8/7b4gRgI3YmHnHAW+q6quKKbsOS+xvSXgL5V2FvfUd+GiQ9Hj53z/1 r7nGPt+m8C9HQg2x03/cYYvFvuVqJWu7kGdslEk8JP9UM1tAFzCD050N2nNfv3JOpXdX6NDUDij VCKULEzFdxeEeIgeo1dJCKUtNZyNhvZmUZ6W2cBPxqjqOnV945S9KYDECJXAy1oELm9yIgf1nSl T4hhBAxF9fbDVfGvElQ== X-Proofpoint-ORIG-GUID: NDUoxzdxCAMyTGu3nsDWIlGpST5bDMP9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-18_01,2026-02-16_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 priorityscore=1501 spamscore=0 impostorscore=0 bulkscore=0 suspectscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602180095 On 2/17/26 10:20 PM, Dmitry Baryshkov wrote: > Add device tree for the Qualcomm / Lantronix SDM845 HDK. It is the > development platform using the modem-less (SDA845) SoC, optional onboard > DSI panel and a rich set of connectors. > > Working: > - HDMI display > - uSD, UFS, USB > - DSPs, WiFi, BT > - Buttons, LEDs > > Not working or not tested: > - DisplayPort - TCPM not supported for this PMIC > - WiGig - requires power sequencing driver, doesn't work with the > current in-kernel driver > - Audio > - FingerPrint > - USIM > > Signed-off-by: Dmitry Baryshkov > --- [...] > + gpio-keys { > + compatible = "gpio-keys"; > + autorepeat; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&home_pin_a>, <&vol_up_pin_a>; property-n property-names in this order, file-wide, please [...] > +&cluster_sleep_0 { > + /* default, 0x4100c244, kills the board */ > + arm,psci-suspend-param = <0x41008244>; > +}; Does crashdump say anything interesting? [...] > +&mdss_dsi1_phy { > + vdds-supply = <&vreg_s6a_0p8>; > + status = "okay"; Let's uniformly keep a \n above 'status' [...] > +&pm8998_gpios { > + home_pin_a: home-active-state { > + pins = "gpio6"; gpio5 here [...] > +&pmi8998_lpg { > + status = "okay"; > + > + qcom,power-source = <1>; > + > + led@3 { > + reg = <3>; > + color = ; > + function = LED_FUNCTION_BLUETOOTH; > + linux,default-trigger = "bluetooth-power"; > + }; > + > + led@4 { > + reg = <4>; > + color = ; > + function = LED_FUNCTION_HEARTBEAT; > + linux,default-trigger = "heartbeat"; > + function-enumerator = <2>; function-enumerators only seem necessary when the same color&func combo is registered multiple times > + }; > + > + led@5 { > + reg = <5>; > + color = ; > + function = LED_FUNCTION_INDICATOR; > + function-enumerator = <1>; panic-indicator? > + }; > +}; > + > +&pmi8998_wled { > + status = "disabled"; > +}; It's already disabled > + > +&qupv3_id_0 { > + status = "okay"; > +}; > + > +&qupv3_id_1 { > + status = "okay"; > +}; > + > +&sdhc_2 { > + status = "okay"; last, please (there's more occurences below) > + pcie0_default_state: pcie0-default-state { > + clkreq-pins { > + pins = "gpio36"; > + function = "pci_e0"; > + bias-pull-up; > + }; > + > + perst-n-pins { > + pins = "gpio35"; > + function = "gpio"; > + drive-strength = <2>; > + bias-pull-down; bias-disable? Konrad