From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753052AbdGSBr3 (ORCPT ); Tue, 18 Jul 2017 21:47:29 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:48048 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753039AbdGSBrY (ORCPT ); Tue, 18 Jul 2017 21:47:24 -0400 Subject: Re: [PATCH] hwmon: Convert to using %pOF instead of full_name To: Rob Herring Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Dirk Eibach , Jean Delvare , linux-hwmon@vger.kernel.org References: <20170718214339.7774-25-robh@kernel.org> From: Guenter Roeck Message-ID: Date: Tue, 18 Jul 2017 18:47:20 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170718214339.7774-25-robh@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/18/2017 02:43 PM, Rob Herring wrote: > Now that we have a custom printf format specifier, convert users of > full_name to use %pOF instead. This is preparation to remove storing > of the full path string for each node. > > Signed-off-by: Rob Herring > Cc: Dirk Eibach > Cc: Jean Delvare > Cc: Guenter Roeck > Cc: linux-hwmon@vger.kernel.org Applied to hwmon-next. Thanks, Guenter > --- > drivers/hwmon/ads1015.c | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/drivers/hwmon/ads1015.c b/drivers/hwmon/ads1015.c > index 357b42607164..98c704d3366a 100644 > --- a/drivers/hwmon/ads1015.c > +++ b/drivers/hwmon/ads1015.c > @@ -191,24 +191,23 @@ static int ads1015_get_channels_config_of(struct i2c_client *client) > unsigned int data_rate = ADS1015_DEFAULT_DATA_RATE; > > if (of_property_read_u32(node, "reg", &pval)) { > - dev_err(&client->dev, "invalid reg on %s\n", > - node->full_name); > + dev_err(&client->dev, "invalid reg on %pOF\n", node); > continue; > } > > channel = pval; > if (channel >= ADS1015_CHANNELS) { > dev_err(&client->dev, > - "invalid channel index %d on %s\n", > - channel, node->full_name); > + "invalid channel index %d on %pOF\n", > + channel, node); > continue; > } > > if (!of_property_read_u32(node, "ti,gain", &pval)) { > pga = pval; > if (pga > 6) { > - dev_err(&client->dev, "invalid gain on %s\n", > - node->full_name); > + dev_err(&client->dev, "invalid gain on %pOF\n", > + node); > return -EINVAL; > } > } > @@ -217,8 +216,7 @@ static int ads1015_get_channels_config_of(struct i2c_client *client) > data_rate = pval; > if (data_rate > 7) { > dev_err(&client->dev, > - "invalid data_rate on %s\n", > - node->full_name); > + "invalid data_rate on %pOF\n", node); > return -EINVAL; > } > } > -- > 2.11.0 > >