From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69D673F0AB1 for ; Fri, 10 Jul 2026 08:31:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783672313; cv=none; b=ugX/PyskE/zVJ6a2nKx1+qz3Z7EU37byMHZGMC3INBCPIf8LRYzybZAlfE6hH54FLib812l4baKXQ0Z/f4VDxQkPxwfAGB4ZD7Sw6Zkalj+4U9nhId1Qprfv+1o74UPmLgixBFsofZ/cqXnARm3O/A5xgB0oQRMShg5I8FylNV8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783672313; c=relaxed/simple; bh=B82fUdr3FIRmXEGo5N2knauT/Vi17F2UJb4hCihO1wk=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=tk5aZFN/UF4NJbmOaNxI/jAm/09YjiWLe4ggmCePgJZDPxkr0awY6VsRybEIhrDXEH/KblTOhOai2skrs+GzN1JqWgnkC5sak5g3ksRvN7PjVgYqTunuYJr4HFAHHRXlWouRnuefm6aAWh+JaNIu5l1wRG06p8jdT2UPj0EJ0hs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=NMATRv//; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=fvcip7TD; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NMATRv//"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="fvcip7TD" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783672308; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=4kQemOIUwz1M/CXyOgmbczAyLfNUg0B0dvAv2SyUZZs=; b=NMATRv//FWTkxn2zsi9T/EzUO2+/tkROZDJ+ODLc0syn5Cni4WDPn7uXiuvoYgc/U73aq3 dcbltKtX+fCIhGvgAbnRnv9wDlRIYPKM5JQjHO+6q0+JW2qXZuLFTbNgWQ1Tv+I8/XBily jwpEiz7+GkLvEXwG21IRlQYscmGwbws= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-606-Hf7j1gAaMreT7ijd7oMJqA-1; Fri, 10 Jul 2026 04:31:44 -0400 X-MC-Unique: Hf7j1gAaMreT7ijd7oMJqA-1 X-Mimecast-MFC-AGG-ID: Hf7j1gAaMreT7ijd7oMJqA_1783672304 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-493bdf90adaso5931555e9.2 for ; Fri, 10 Jul 2026 01:31:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1783672303; x=1784277103; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:content-type :autocrypt:references:in-reply-to:date:cc:to:from:subject:message-id :from:to:cc:subject:date:message-id:reply-to:content-type; bh=4kQemOIUwz1M/CXyOgmbczAyLfNUg0B0dvAv2SyUZZs=; b=fvcip7TDOjyOF+FhvhhUCr6OoTn1DRV0vSnCUjid+Gg+Z3NyKdtR/5tMc8ycumGg+J U61+kigE+yZayyGc5EZcTsnKuEmlMgbjKhIdpNNQfnlv78e89bmbtuia3yv3KVTHt2NN ahK9Y0xQX3Ecw69ikoLxzWmXexnNdfgksmmQaD5MaDbHtnbviCakgUk/Uc7biZTxb9k8 WaQvlrsf5q8tYx8pcVHlUGw5x8PCEu9wFP0fyzhv1vQxICU/edijIsFTTaAiCrguvyRC gMTJ9tOQ5UVVOwHhBfaiFBOa5mKfzqOKnvjHZRLfqckND+QBki8SLS4iaB5malGFNE7T SEtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783672303; x=1784277103; h=mime-version:user-agent:content-transfer-encoding:content-type :autocrypt:references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=4kQemOIUwz1M/CXyOgmbczAyLfNUg0B0dvAv2SyUZZs=; b=bJz4Drknl3RnZwEKSnHDW+oyRhf4bICURS/d5u9h5iAigyV1sf5u13D/PB/PNWmOPg O8Ij8noPoCpzwni8vHWdeZ8sPO1SXiQm18yZrmM/Xxl6yE0AJDmfVa4gnHwBe+H5UnTl jC9oPVwZEo5ICFi2pvgqGMPCFDLZpKvd5RzTZy7+DRk+ZUVn4Nj0p8Xmj1aFX46zKTrX wNnIfR840HhvIJPkE6NqLhKMKRrF2kNM+fWm6KQvYPFi7y+fosx5dlg0wdbWldkYMe6j 6I/Hs7gzEDsgmfpqeVHsm1cj6Wx5eZwWKuEx09nDZm2IWW9FnX98m8kF0txcLZ7SmXq6 3mIQ== X-Forwarded-Encrypted: i=1; AHgh+RrD/Fa5lpAs4jwkRcwl0sAHVKqkaZoLkChvpTcADJeKcs/IzjNYt49sfobmpCOkasTSjC/mhZKITWluKzk=@vger.kernel.org X-Gm-Message-State: AOJu0YxTbsHqTuveFwckCaigvkb7TxSDOMmV3wzwblg7oBL/k/U/4LPo dD2YfQQCQ5wU5RpOuG+/h3AOm9tv5fLMR8+qx88mbq6rf652RWHuRRGQuDGyFGHjHPGIYi4zryY ePnXo7akII7Jve/Kd6nOCJNQgg2XDh8rSyDGzq1D7tciSP+hNNckDtvgRXv544LOYfw== X-Gm-Gg: AfdE7cnVfRVT775Q05amBN51onIFJQPi2Qq/YgiSWqvLbrILZVXBlDOv1FcgRK8Zz1G F64iqSW+vqA6H2OrLkmeXCo16lgK/G/q3/T8S+w3h30hPfTfmpjFcnrequnsTum9+ld0tPld2gn B7xsSa+IF0BvyGEuSlhNLsiWoKERCrFzqDhjnkVNGYGF/TdUb9revN4rkBbggJV481cpmILngWt aF3c60C8d4+QB77gsVujHkmbZMy4T3FqHFqAGDjYxpTV312CCoTy8B8PnvsZxLggEl5zkwPP36p k7x8GzJNBsShm6iwkG8/qOquVhRmamzrVMXJfyAA6EIfnwAvCJMf+ghqSSWwhT5KJ+BbOjDDkt/ UBvhpyJtKPm1tBB8lWAbm8bquJY8eBaRB8nLtUyGgc2jW46d4w2tcYMQYT216MDFU0xOES15JUE p8/YpC X-Received: by 2002:a05:600c:4e0d:b0:493:c14a:a1ca with SMTP id 5b1f17b1804b1-493f3a5de04mr20017235e9.3.1783672303655; Fri, 10 Jul 2026 01:31:43 -0700 (PDT) X-Received: by 2002:a05:600c:4e0d:b0:493:c14a:a1ca with SMTP id 5b1f17b1804b1-493f3a5de04mr20016645e9.3.1783672303123; Fri, 10 Jul 2026 01:31:43 -0700 (PDT) Received: from gmonaco-thinkpadt14gen3.rmtit.csb (212-8-243-115.hosted-by-worldstream.net. [212.8.243.115]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47df6a31dd5sm12792241f8f.16.2026.07.10.01.31.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2026 01:31:42 -0700 (PDT) Message-ID: Subject: Re: [PATCH v3 16/17] selftests/verification: Rearrange the wwnr_printk test From: Gabriele Monaco To: Wen Yang , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Nam Cao , Thomas Weissschuh , Tomas Glozar , John Kacur , Steven Rostedt , Shuah Khan , linux-kselftest@vger.kernel.org Date: Fri, 10 Jul 2026 10:31:40 +0200 In-Reply-To: References: <20260625121440.116317-1-gmonaco@redhat.com> <20260625121440.116317-17-gmonaco@redhat.com> Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0BrZXJuZWwub3JnPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmjKX2MCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfIQuAD+JulczTN6l7oJjyroySU55Fbjdvo52xiYYlMjPG7dCTsBAMFI7dSL5zg98I+8 cXY1J7kyNsY6/dcipqBM4RMaxXsOtCRHYWJyaWVsZSBNb25hY28gPGdtb25hY29AcmVkaGF0LmNvb T6InAQTFgoARAIbAwUJBaOagAULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBMrKEfgLgd0WcK eo9u9KbElYeE3yBQJoymCyAhkBAAoJEO9KbElYeE3yjX4BAJ/ETNnlHn8OjZPT77xGmal9kbT1bC1 7DfrYVISWV2Y1AP9HdAMhWNAvtCtN2S1beYjNybuK6IzWYcFfeOV+OBWRDQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.2 (3.60.2-1.fc44) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Fri, 2026-07-10 at 01:08 +0800, Wen Yang wrote: > > =C2=A0 load() { # returns true if there was a reaction > > - local lines_before num > > + local lines_before num load_pid ret > > =C2=A0=C2=A0 num=3D$((($(nproc) + 1) / 2)) > > =C2=A0=C2=A0 lines_before=3D$(dmesg | wc -l) > > - stress-ng --cpu-sched "$num" --timer "$num" -t 5 -q > > - dmesg | tail -n $((lines_before + 1)) | grep -q "rv: monitor wwnr > > does not allow event" > > + stress-ng --cpu-sched "$num" --timer "$num" -t 5 -q & > > + load_pid=3D$! > > + timeout 5 dmesg -w | tail -n +$((lines_before + 1)) | grep -m 1 -q > > "rv: monitor wwnr does not allow event" >=20 >=20 > Minor nit: could we add a small delay (e.g., sleep 0.1) before dmesg? I don't get what the benefit would be. The intent of that line is to run a continuous dmesg (-w) for up to 5s (tim= eout) but stopping if an occurrence is found (grep -m 1 would close the pipe). Do you see a case in which this wouldn't happen? >=20 > Reviewed-by: Wen Yang >=20 > > + ret=3D$? > > + kill "$load_pid" > > + wait "$load_pid" > > + return $ret > > =C2=A0 } > > =C2=A0=20 > > =C2=A0 echo 1 > monitors/wwnr/enable > > =C2=A0 echo printk > monitors/wwnr/reactors > > =C2=A0=20 > > -load > > - > > =C2=A0 echo 0 > monitoring_on > > =C2=A0 ! load || false > > =C2=A0 echo 1 > monitoring_on > > =C2=A0=20 > > -load > > - > > =C2=A0 echo 0 > reacting_on > > =C2=A0 ! load || false > > =C2=A0 echo 1 > reacting_on > > =C2=A0=20 > > +load > > + > > =C2=A0 echo nop > monitors/wwnr/reactors > > =C2=A0 echo 0 > monitors/wwnr/enable