From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f97.google.com (mail-yx1-f97.google.com [74.125.224.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AC832581 for ; Thu, 29 Jan 2026 20:02:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.97 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769716958; cv=none; b=I7uUoiy0+fS9OeOdAUAeM7hz7z5UsYgKxLcDSUiFNmjUer4wOKfKWpJ4MfI5lfendWa3rOey7FegszSlsUYki6O3go1QDrYBqWkf3JbfvZv0i7vSUnB2WXEV5+0IvneHwkx1o+nXTCILf4O4kQF2FqmfDG9R3Cfj4NjaMcuRtuk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769716958; c=relaxed/simple; bh=SsBF9PaGeW67il2cCRkLQnQdEDVzxDmXtRsTZBSoC5k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cfJht3WN2VEFmYmUsm3jIhgmw24qm6pz+vXS1nCaylzcAxbPThfB68A1ppFbVYCXfdREqppKkkzdwMH+6LWoywrD6XRTTX0trJERIGYY1YYlhOAoKzx3wSIbHXuQU8XuckAzDm+R2CwhEPFd4eMUDeVIhlXTJ/GHAY+ev+TVraw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=NrDPrZnG; arc=none smtp.client-ip=74.125.224.97 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="NrDPrZnG" Received: by mail-yx1-f97.google.com with SMTP id 956f58d0204a3-649523de91fso1258667d50.2 for ; Thu, 29 Jan 2026 12:02:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769716956; x=1770321756; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=7ioB3D6BXyeLcWD9XhvHoJBhn3PqyGRuLvXy6++BvIU=; b=T6DOZjRDCL5737riL2/mnX4Pijprke+7H4JIL7+HqCfbfVF36at8SlRA9OU0HaKtt4 6jhoU8IaTUqo6uSFTo+wtjBg+5+svRKx9fagNHU/hpAS+dxWGwY0FUnm15SSUejYg+I1 mi1UAvYB7IwftDcsJ1iqM8nwXiQ9U8Wd9pw2vElwzuHFGvM09E6Se926Nc+x6wU7ZYNQ diysuWe3rA8SxyQEXisfQdBYjjotwlxL3sKf+VLn5t6z3UTAmXXFwVXwSsKAnJ6qNpiy OrelLMNp3SwBZpqP8f+Ucm5VMAUhECKHd06ue/ZyYZP81zEjA6VeGrmfnUZjKLbdF5S0 WSuQ== X-Gm-Message-State: AOJu0Yy2/zMPuzf7VHZMTx/HL9bQVolVzkJjHyR2TFC/c2oIbgLTJG/Q tvFZu6Rkr8WIZLiJgZeQ8W83kFMk35u0hQJ/7FGdNcWbGG6RVvCNiNec8mGU7C6V97wHHIKANy8 eheMj4wbBWb4fr+MWPy41kcTsHtjazdbpZqnzNcY3o0IKGKcFM7J9EZ5YZ+1Gv9vIXnGzCxflLn GJrn6gZAiVEqFOhFsm2pESZKgexxwUWznylo/0zIGddGKvPSCQMn71PUNwnkiUEjEZaIUayhmKM H/xjc79giSUXDx2wvFR3FwQ X-Gm-Gg: AZuq6aIoWyf9qxiyvalTTvImQLL6/W04JQqd4q36xJ21rPKEkXTiXzo1hJRIQVab5cl 0OVlMWAndIoTYQKMg3ock6HwXIJOcSEF0j61vXpPUqpqDmyM4tBwACPqPLIgkoON8vNcQqW3+dJ itQxdzip0SGAN3M6KKy5s6A/0QYHSoc/sGaYfDvsEp6tD5MScKY65T/Ii5FdWcSvYL4gKtsCaWj tyxwyX3bBVN+SKkWXfZzzNEBmlh5gLjtkqsvk15AJ3BZCy587iKrdFHXMuy0I4Drbb3wysAK0ev A7rKgPrbCd+Xk2gk4w100OsEtfWdKPWFBXQc5u7KoOQBfMaH6covfvvgrA8vz6bs3UhLeOt1jnW pFZMbEF8yyX0TWbNbSNGFMOkg4ZascVmg1N+UA/SOO+ZCK0E1apG/LuBR8OeQaljLEokoTuhN06 a5xfiYqptVuLQ0WcVCxT2f3EghrFgULlvMeMfkjbFa5wv/g/QmYg== X-Received: by 2002:a05:690e:4092:b0:649:4255:c74 with SMTP id 956f58d0204a3-649a84fc5demr510307d50.79.1769716956279; Thu, 29 Jan 2026 12:02:36 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-20.dlp.protect.broadcom.com. [144.49.247.20]) by smtp-relay.gmail.com with ESMTPS id 956f58d0204a3-649960ef2b4sm593831d50.9.2026.01.29.12.02.36 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Jan 2026 12:02:36 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-ot1-f72.google.com with SMTP id 46e09a7af769-7d11af6fecbso3679619a34.1 for ; Thu, 29 Jan 2026 12:02:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1769716955; x=1770321755; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=7ioB3D6BXyeLcWD9XhvHoJBhn3PqyGRuLvXy6++BvIU=; b=NrDPrZnGvykIQYCuLc8/MXSb0njszQopoePP23dZgHQ/kTVh8MmA0zBX8L/lp6idYL pcR7tRkt5NCWOGPtVC5R7nmMRtAP8abpC7aZ9qAwXZPIoOYFKEI3NG1Z0i+y/SzhDOzq /y2nZR+RKKGwG5OwiinIKk4GEmq9jxUEja2BU= X-Received: by 2002:a05:6820:178d:b0:663:389:6acc with SMTP id 006d021491bc7-6630f3850e2mr356027eaf.44.1769716955279; Thu, 29 Jan 2026 12:02:35 -0800 (PST) X-Received: by 2002:a05:6820:178d:b0:663:389:6acc with SMTP id 006d021491bc7-6630f3850e2mr356010eaf.44.1769716954859; Thu, 29 Jan 2026 12:02:34 -0800 (PST) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-662f994388fsm3657258eaf.4.2026.01.29.12.02.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jan 2026 12:02:34 -0800 (PST) Message-ID: Date: Thu, 29 Jan 2026 12:02:32 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] gpio: brcmstb: allow parent_irq to wake To: Andy Shevchenko Cc: linux-kernel@vger.kernel.org, Doug Berger , Broadcom internal kernel review list , Linus Walleij , Bartosz Golaszewski , Christophe Leroy , "open list:GPIO SUBSYSTEM" , "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" References: <20260127214656.447333-1-florian.fainelli@broadcom.com> <20260127214656.447333-4-florian.fainelli@broadcom.com> Content-Language: en-US, fr-FR From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 1/29/26 06:23, Andy Shevchenko wrote: > On Tue, Jan 27, 2026 at 11:47 PM Florian Fainelli > wrote: > >> The classic parent_wake_irq can only occur after the system has >> been placed into a hardware managed power management state. This >> prevents its use for waking from software managed suspend states >> like s2idle. >> >> By allowing the parent_irq to be enabled for wake enabled GPIO >> during suspend, these GPIO can now be used to wake from these >> states. The 'suspended' boolean is introduced to support wake >> event accounting. > > ... > >> if (of_property_read_bool(np, "wakeup-source")) { >> + /* >> + * Set wakeup capability so we can process boot-time >> + * "wakeups" (e.g., from S5 cold boot) > > While at it, add a period at the end. > >> + */ >> + device_set_wakeup_capable(dev, true); >> + device_wakeup_enable(dev); > >> } > > ... > >> + /* disable interrupts */ > > Still the comment is useless. > >> + if (priv->parent_irq > 0) >> + disable_irq(priv->parent_irq); > > And looking more at this, I don't see why we even need the check. Does > the code WARNs or so when there is no parent_irq available? > > *Yes, I saw this is the original code, perhaps can be addressed in a follow up. > > ... > >> + /* disable interrupts while we save the masks */ > >> + if (priv->parent_irq > 0) > > Ditto. > >> + disable_irq(priv->parent_irq); > > ... > >> + /* disable interrupts while we restore the masks */ >> + if (priv->parent_wake_irq) > > Ditto. > >> + disable_irq(priv->parent_irq); > > ... > >> + /* re-enable interrupts */ >> + if (priv->parent_irq > 0) > > Same here. > >> enable_irq(priv->parent_irq); > > ... > > All we are diving into is the 2 questions: > - is 0 on the particular platform an IRQ number and there is no sparse > tree enabled? > - is maple tree implementation clever enough to not crash (or have > side effects) when we ask for a non-existing index? > > Anyway, this can be done later on. OK, I will remove the superfluous comments, add punctuation where necessary and respin (removing patch #1 since it was applied already). Thank you! -- Florian