Re: [PATCH v2 3/3] platform/x86: dell_rbu: Stop overwriting data buffer

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

On Thu, 22 May 2025, Stuart Hayes wrote:

> The dell_rbu driver will use memset to clear the data held by each packet

Please add () after function names.

> when it is no longer needed (when the driver is unloaded, the packet size
> is changed, etc).
> 
> The amount of memory that is cleared is (currently) the normal packet
> size.  However, the last packet in the list may be smaller.  Fix this to

One space is enough after .

> only clear the memory actually used by each packet, to prevent it from
> writing past the end of data buffer.
> 
> Signed-off-by: Stuart Hayes <stuart.w.hayes@gmail.com>

Fixes tag?

> ---
>  drivers/platform/x86/dell/dell_rbu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/dell/dell_rbu.c b/drivers/platform/x86/dell/dell_rbu.c
> index c03d4d55fcc1..7d5b26735a20 100644
> --- a/drivers/platform/x86/dell/dell_rbu.c
> +++ b/drivers/platform/x86/dell/dell_rbu.c
> @@ -322,7 +322,7 @@ static void packet_empty_list(void)
>  		 * zero out the RBU packet memory before freeing
>  		 * to make sure there are no stale RBU packets left in memory
>  		 */
> -		memset(newpacket->data, 0, rbu_data.packetsize);
> +		memset(newpacket->data, 0, newpacket->length);
>  		set_memory_wb((unsigned long)newpacket->data,
>  			1 << newpacket->ordernum);
>  		free_pages((unsigned long) newpacket->data,
> 

-- 
 i.