From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E381C433F5 for ; Thu, 3 Mar 2022 21:39:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236589AbiCCVk1 (ORCPT ); Thu, 3 Mar 2022 16:40:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232842AbiCCVkZ (ORCPT ); Thu, 3 Mar 2022 16:40:25 -0500 Received: from mail-il1-x12d.google.com (mail-il1-x12d.google.com [IPv6:2607:f8b0:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 024B3E1B49 for ; Thu, 3 Mar 2022 13:39:39 -0800 (PST) Received: by mail-il1-x12d.google.com with SMTP id i1so5104515ilu.6 for ; Thu, 03 Mar 2022 13:39:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=GrVA4wCtJ9ZZHjn3qb/7bEScChq15mZGv+SPu/mtxIM=; b=VCCqrS+5HnBr+1wxFMQSWauFi4Qp22D2JmhF5xNptWdbB+RRGVsOw0hr43SMv8QQSA FvZ+O4XYQKizNzZzSiTG6DT1LKtSG1W1CjmvdyiW4yNigLzrBVqP0UZvQuGRu9juEqcV N78vuK7UANHhsr7DbY+xfl5U00+fswtNYm4jo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GrVA4wCtJ9ZZHjn3qb/7bEScChq15mZGv+SPu/mtxIM=; b=c9qrsJrNACKKAf91piYwtSroS6R9T/df8Etc0Zm4m3lV6m5jTsyCI/awMxCXwbffwd f2Smh71XAn5ER5cyLWq3N4b/nM4L9Qk/a6mSGW5r+54MlqK62g00Yz0aAGIFd+h+mfOY v/28UYKURy2CNiV9tWRcl/i9WZHi9tcalSpI0lYuhj4alvNeRlqv0F2QAgWRBDNQQycG hyb/RE/22mfWKC9lR7CYp7zKDZpYAT7hY7IUVAHU3/+pPUSjtYcUO+kH2gCrFX+iE14s yxXs16fkghGcDEhUdl+46dX+kog8Zn/7YrOQ8MZ82juuVQin9QD/+tyJDc9EGwM1RbvQ cZXg== X-Gm-Message-State: AOAM531kjvl1OGrcg98Rinxu9YkOtBpkmXZGvIeUf36yIcHBt3ilKCYA DYhA0BZ1wdS51ONO1fMIY0K/7A== X-Google-Smtp-Source: ABdhPJzbbv3ggQn9TAbpL4V/TQDXEGyuOp2p0inmz8pxdQifa0sBXO4Vk4R6ADVOl5MwgFyzP/zxzw== X-Received: by 2002:a92:c5aa:0:b0:2c5:f753:9069 with SMTP id r10-20020a92c5aa000000b002c5f7539069mr6683520ilt.71.1646343578331; Thu, 03 Mar 2022 13:39:38 -0800 (PST) Received: from [192.168.1.128] ([71.205.29.0]) by smtp.gmail.com with ESMTPSA id f4-20020a92b504000000b002c21ef70a81sm3233325ile.7.2022.03.03.13.39.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Mar 2022 13:39:37 -0800 (PST) Subject: Re: [PATCH] selftests/interpreter: fix separate directory build To: Muhammad Usama Anjum , Shuah Khan Cc: kernel@collabora.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20220303110629.2072927-1-usama.anjum@collabora.com> From: Shuah Khan Message-ID: Date: Thu, 3 Mar 2022 14:39:37 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20220303110629.2072927-1-usama.anjum@collabora.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/3/22 4:06 AM, Muhammad Usama Anjum wrote: > Separate directory build fails of this test as headers include path isn't > set correctly in that case. Fix it by including KHDR_INCLUDES. > > make -C tools/testing/selftests O=build1 > gcc -Wall -O2 -I../../../../usr/include trust_policy_test.c -lcap -o /linux_mainline/build1/kselftest/interpreter/trust_policy_test > trust_policy_test.c:14:10: fatal error: linux/trusted-for.h: No such file or directory > 14 | #include > | ^~~~~~~~~~~~~~~~~~~~~ > compilation terminated. > > Signed-off-by: Muhammad Usama Anjum > --- > tools/testing/selftests/interpreter/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/interpreter/Makefile b/tools/testing/selftests/interpreter/Makefile > index 7402fdb6533f..51dde8e01e32 100644 > --- a/tools/testing/selftests/interpreter/Makefile > +++ b/tools/testing/selftests/interpreter/Makefile > @@ -1,6 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0 > > -CFLAGS += -Wall -O2 -I$(khdr_dir) > +CFLAGS += -Wall -O2 -I$(khdr_dir) $(KHDR_INCLUDES) > LDLIBS += -lcap > Change looks fine to me. > src_test := $(wildcard *_test.c) > I am not seeing this test in linux-kselftest next for sure. Which tree is this patch based on? Please add the repo info to the patch subject line in the future. Either way I don't have the patch that added in liunx-kselftest repo: Reviewed-by: Shuah Khan thanks, -- Shuah