mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jia-Ju Bai <baijiaju1990@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: aelior@marvell.com, manishc@marvell.com, davem@davemloft.net,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: qlogic: check the return value of dma_alloc_coherent() in qed_vf_hw_prepare()
Date: Sat, 5 Mar 2022 16:37:21 +0800	[thread overview]
Message-ID: <b9805786-d322-23b6-6a19-0e331b8957fe@gmail.com> (raw)
In-Reply-To: <20220303211953.7d937dfc@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>



On 2022/3/4 13:19, Jakub Kicinski wrote:
> On Wed,  2 Mar 2022 19:34:50 -0800 Jia-Ju Bai wrote:
>> --- a/drivers/net/ethernet/qlogic/qed/qed_vf.c
>> +++ b/drivers/net/ethernet/qlogic/qed/qed_vf.c
>> @@ -513,6 +513,9 @@ int qed_vf_hw_prepare(struct qed_hwfn *p_hwfn)
>>   						    p_iov->bulletin.size,
>>   						    &p_iov->bulletin.phys,
>>   						    GFP_KERNEL);
>> +	if (!p_iov->bulletin.p_virt)
>> +		goto free_vf2pf_request;
> leaking the reply buffer

Hi Jakub,

Thanks for pointing out this problem.
I will send a V2 patch.


Best wishes,
Jia-Ju Bai

      reply	other threads:[~2022-03-05  8:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-03  3:34 Jia-Ju Bai
2022-03-04  5:19 ` Jakub Kicinski
2022-03-05  8:37   ` Jia-Ju Bai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b9805786-d322-23b6-6a19-0e331b8957fe@gmail.com \
    --to=baijiaju1990@gmail.com \
    --cc=aelior@marvell.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manishc@marvell.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®