From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sphereful.davidgow.net (sphereful.davidgow.net [203.29.242.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AEED284690 for ; Tue, 21 Apr 2026 06:50:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.29.242.92 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776754251; cv=none; b=Lh2k4+2UqT9fuZUTmZLbwIVRYKyxRcrd/6owtiImrxh2dMK1p2HWektQ4OjB2QbUFSv6V60t7pkZ/ijd/OeZc7PYfM5/eBg95cogXYbHCtRPdLstCEJLCW8EC9b+cmIgDy/s9773gjgZ8z1D11L0z6UWkByqE7lNBWMpzIjRYbE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776754251; c=relaxed/simple; bh=cYzHbW2BW4IAxOdiDLnFgEkVu7s58J7KCCwAWVVvV0Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=STDMDjJQ7DZvy/vN3o1btlWeibNMoGbFX0E8nljrY8xzF95IA4bZhVLYjhAVnf7KD2EBYrDZMWDxB/rBoD5+/I0ym8ZSw209qAw4TiQq28drkqRotFn09WrRTGwHvVDd/bHZZOmN+5MPysUjaOa8ZpJ9HmsiJkGYGiZZWpA2o+Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=davidgow.net; spf=pass smtp.mailfrom=davidgow.net; dkim=pass (4096-bit key) header.d=davidgow.net header.i=@davidgow.net header.b=Y9517ejb; dkim=pass (4096-bit key) header.d=davidgow.net header.i=@davidgow.net header.b=NB//AZ++; arc=none smtp.client-ip=203.29.242.92 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=davidgow.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=davidgow.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=davidgow.net header.i=@davidgow.net header.b="Y9517ejb"; dkim=pass (4096-bit key) header.d=davidgow.net header.i=@davidgow.net header.b="NB//AZ++" DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=davidgow.net; s=201606; t=1776754246; bh=cYzHbW2BW4IAxOdiDLnFgEkVu7s58J7KCCwAWVVvV0Q=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Y9517ejbDcIUk+IXXjfhXvzPtr5XC8DpLIpD9Lb5z9iUQ0LoqmSJWUxaHDkjCpSxd Gd5fBEP11bOcsvVGBbuAvJfM1XQkt9Rqwx+zDZZp0NHEwK76E2hvn3yqJx2MQNK4DI VvdNDp9YUl8bkqSgdfkGiQT/m0rB234iswBhlJN5cY91jD/51Rh891I32h0NhmagYz QS69lvS+fMBHSPn36i5oJ7aB9ePJqybfWH3tC7W/s5CKemoJyZQ24Q3cJEb4vq6Rc+ E08ZiKLZ7o8Be4XtA02k/NJnegchmTfgX+7t9kk/iSbFsYK8G8qURpoN1jNQGOYW0b TOQDh1mZ3cWJHSHVfH8cTuGyN1fc9+nDTrUWXjnt9PkkdjBSJ2TyFmwzWogtRw/9tv F6rj/LJMFS5LHCRpTW2JErFjMtKbQl5vX8J2QCbMSDQQKI5y6TflAvbwRwvxnuHiZD K0DT1L9UR6w7+El8E3ogW7VSoOW6XxK7DV/cSPw1g8pyI202T46lBM2igBtr7a4NVg JB4p5x4drcUI5m30BPqVQYKuWPpXnjSFuKDh9cnBVwQECAb0Ds++ehp7zpzWXOgYn3 nrmmsIC5gSTCfsrU9o/0YsuM71DweeiTR5vXoq8bCJTjgR4tiTOKoCiT2LTcwfvjol xL1wPBr6tOXYdQSIxYoWKOC4= Received: by sphereful.davidgow.net (Postfix, from userid 119) id 8B5431E8CBA; Tue, 21 Apr 2026 14:50:46 +0800 (AWST) X-Spam-Level: DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=davidgow.net; s=201606; t=1776754200; bh=cYzHbW2BW4IAxOdiDLnFgEkVu7s58J7KCCwAWVVvV0Q=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=NB//AZ++OvDddFwS17f9KOCpKlQ872wWBM2U/jLuLAea/xNHVJvEF5dx13RgbMgna tJ+Yl00XQYmFhkdXZXFBn/2JMstNiDmzX+XidLrtjV9GH2Ev962pbgCfPbx6dv842K 4lEuFUMpNuH23MSiUuidSdB9ld9BwpOGPqRKIFhjhLn/htpdCvH0JXSw6XKNP69m7x 8vIqzD4S9/0uRRDrY6PjmN73Z0XpumVy6gGp5MPJ2wbbuXIHYr1ZPSF98BeLRuOt8v wzL/bL4A8pzP+ISw+vpHTUqWBK8xpuv9dlNeTe2X4D1mM+ORZkIcVIUTEzqgthc/82 MFVJTWn3UmHfZMRdmuSnUiSuoWOLgYhgInSjNcmbn6615ei6aZWVqZ5b6KbkQH12fq i3l0tApAFR08jaL8KgeAOJyPmVqWvcDjQhrUQVoRyD0fdoX9NbzL4iSYzWmxTFPMzp yr0NsTI/KiZIf+QR5PYsmLP2YPG76TyxaLijVGmsSGphx2aWfKVa4jdjBps6PtAq13 iRo9IIyNgycfi9ex+7xXFk6UyEwlmYK7cW4WO3jwvLFl1WbuLVzgcQzd7GUIjqE4e5 JY48PyTq1SfKf7225+O9AffBLu8UXkwLuDin2vM5vxrJzHrwhA9yRiqfo3UOSgARWM WGdoF6QeQ4bYHoaxwu8X7zFE= Received: from [IPV6:2001:8003:8810:ea00:615:932a:cdfa:179c] (unknown [IPv6:2001:8003:8810:ea00:615:932a:cdfa:179c]) by sphereful.davidgow.net (Postfix) with ESMTPSA id DEA1D1E8CAD; Tue, 21 Apr 2026 14:50:00 +0800 (AWST) Message-ID: Date: Tue, 21 Apr 2026 14:49:56 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 5/5] lib: kunit_iov_iter: Add tests for extract_iter_to_sg To: "Christian A. Ehrhardt" Cc: David Howells , Andrew Morton , linux-kernel@vger.kernel.org, Kees Cook , Petr Mladek References: <20260326214905.818170-1-lk@c--e.de> <20260326214905.818170-6-lk@c--e.de> <34a81ec2-af84-465d-9b5e-7bb5bf01680f@davidgow.net> Content-Language: en-US From: David Gow In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Le 21/04/2026 à 14:30, Christian A. Ehrhardt a écrit : > > Hi David, > > On Tue, Apr 21, 2026 at 01:45:33PM +0800, David Gow wrote: >> Le 27/03/2026 à 05:49, Christian A. Ehrhardt a écrit : >>> Add test cases that test extract_iter_to_sg. >>> >>> For each iterator type an iterator is loaded with a suitable >>> buffer. The iterator is then extracted to a scatterlist with >>> multiple calls to extract_iter_to_sg. The final scatterlist >>> is copied into a scratch buffer. >>> >>> The test passes if the scratch buffer contains the same data >>> as the original buffer. >>> >>> The new tests demonstrate bugs in extract_iter_to_sg >>> for kvec and user iterators that are fixed by the previous >>> commits. >>> >>> Cc: David Howells >>> Cc: Andrew Morton >>> Signed-off-by: Christian A. Ehrhardt >>> --- >> >> Hmm... this is failing on powerpc, where PAGE_SIZE is 64k: >> >> [13:20:40] # iov_kunit_iter_to_sg_kvec: ASSERTION FAILED at > > Sorry about that! I wasn't aware of the large page size on powerpc. > This should fix it. I will prepare a proper patch but it would > be cool if you could verify that it actually helps. > > Best regards, > Christian > Works here, thanks. Sorry I didn't pick it before it went in. I tested with: ./tools/testing/kunit/kunit.py run --arch powerpc --cross_compile powerpc64-suse-linux- (But it'll obviously need some minor tweaks for non-SUSE distros…) Cheers, -- David