From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C5F21EA7D; Mon, 5 Feb 2024 21:53:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.19.142 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707169986; cv=none; b=CX0bu4ITBn5yE+cBTAkRmM/Squ3dLEFBwY0H5+MJ9BUMQgXAilwr9/g3+QP6dr1rvLSObv7TIDeLuJvha3HmNcxX70KkllWPKSTlQuxRJIx7HskFXVnJlwWopUPQhX5HtGhk3IfnKaiVynheIL+egdRUtyKTBUOazm/mVpA8myE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707169986; c=relaxed/simple; bh=PNopHqJ7BsKVIDJVHx0hCpN6klK/RINUZrRYUaJJg1U=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=NKdv76r76yOTW4E7tHdUxHceur2zHrsHlW8fR4nfvu4NKJATyXIkO6Uvg1fuVPltsJIRSC5vq3E3FcNM+o+i5gdkhNbfL/a1QLMjotq8kAX+FlXyMHP2DBxxq7p2XEyYgkfpVInTj2NVJiYbT4nlBVteq6SzGuVS/5hKixULjRw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=ZbPz6v7D; arc=none smtp.client-ip=198.47.19.142 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="ZbPz6v7D" Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 415LqtVi049477; Mon, 5 Feb 2024 15:52:55 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1707169975; bh=01gEcfbuvE/0tYmOwUOr4jJrPonp7KaFK31nM2E1vKk=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=ZbPz6v7DRM9EiRH2MrErSnoj9FRCj7xd01s1WeW33zHLm353hdrCsflL5ngwW1Q/a 6NZk4ueUiJgHFTIpQVDBEdqGQer4Y/+FZpst8GFQwxtbMs3P4qUVLTK3AU8zuXO8Hh FsBvY/wFIB1HwSBVs05TvqqbWAJzGtebKrRHtIzk= Received: from DLEE108.ent.ti.com (dlee108.ent.ti.com [157.170.170.38]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 415Lqt33070036 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 5 Feb 2024 15:52:55 -0600 Received: from DLEE115.ent.ti.com (157.170.170.26) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Mon, 5 Feb 2024 15:52:55 -0600 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Mon, 5 Feb 2024 15:52:55 -0600 Received: from [10.249.42.149] ([10.249.42.149]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 415LqsL6087347; Mon, 5 Feb 2024 15:52:54 -0600 Message-ID: Date: Mon, 5 Feb 2024 15:52:54 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/3] media: dt-bindings: Add Imagination E5010 JPEG Encoder Content-Language: en-US To: Devarsh Thakkar , , , , , , , , CC: , , , , , , , , , , , References: <20240205114239.924697-1-devarsht@ti.com> <20240205114239.924697-2-devarsht@ti.com> From: Andrew Davis In-Reply-To: <20240205114239.924697-2-devarsht@ti.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 On 2/5/24 5:42 AM, Devarsh Thakkar wrote: > Add dt-bindings for Imagination E5010 JPEG Encoder [1] which is implemented > as stateful V4L2 M2M driver. > > The device supports baseline encoding with two different quantization > tables and compression ratio as demanded. > > Minimum resolution supported is 64x64 and Maximum resolution supported is > 8192x8192. > > [1]: AM62A TRM (Section 7.6 is for JPEG Encoder) > Link: https://www.ti.com/lit/pdf/spruj16 > > Co-developed-by: David Huang > Signed-off-by: David Huang > Signed-off-by: Devarsh Thakkar > --- > V2: No change > V3: > - Add vendor specific compatible > - Update reg names > - Update clocks to 1 > - Fix dts example with proper naming > V4: > - Use ti-specific compatible ti,am62a-jpeg-enc as secondary one > - Update commit message and title > - Remove clock-names as only single clock > > Link to previous commit: > https://lore.kernel.org/all/20230816152210.4080779-2-devarsht@ti.com/ > --- > .../bindings/media/img,e5010-jpeg-enc.yaml | 75 +++++++++++++++++++ > MAINTAINERS | 5 ++ > 2 files changed, 80 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml > > diff --git a/Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml b/Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml > new file mode 100644 > index 000000000000..085020cb9e61 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml > @@ -0,0 +1,75 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/img,e5010-jpeg-enc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Imagination E5010 JPEG Encoder > + > +maintainers: > + - Devarsh Thakkar > + > +description: | > + The E5010 is a JPEG encoder from Imagination Technologies implemented on > + TI's AM62A SoC. It is capable of real time encoding of YUV420 and YUV422 > + inputs to JPEG and M-JPEG. It supports baseline JPEG Encoding up to > + 8Kx8K resolution. > + > +properties: > + compatible: > + oneOf: > + - items: > + - const: ti,am62a-jpeg-enc > + - const: img,e5010-jpeg-enc > + - const: img,e5010-jpeg-enc > + > + reg: > + items: > + - description: The E5010 core register region > + - description: The E5010 mmu register region > + > + reg-names: > + items: > + - const: core > + - const: mmu > + > + power-domains: > + maxItems: 1 > + > + resets: > + maxItems: 1 "resets" seems unused. Andrew > + > + clocks: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - reg-names > + - interrupts > + - clocks > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + jpeg-encoder@fd20000 { > + compatible = "img,e5010-jpeg-enc"; > + reg = <0x00 0xfd20000 0x00 0x100>, > + <0x00 0xfd20200 0x00 0x200>; > + reg-names = "core", "mmu"; > + clocks = <&k3_clks 201 0>; > + power-domains = <&k3_pds 201 TI_SCI_PD_EXCLUSIVE>; > + interrupts = ; > + }; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index 8999497011a2..d0f8c46d3ce9 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -10461,6 +10461,11 @@ S: Maintained > F: Documentation/devicetree/bindings/auxdisplay/img,ascii-lcd.yaml > F: drivers/auxdisplay/img-ascii-lcd.c > > +IMGTEC JPEG ENCODER DRIVER > +M: Devarsh Thakkar > +S: Supported > +F: Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml > + > IMGTEC IR DECODER DRIVER > S: Orphan > F: drivers/media/rc/img-ir/