From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3A2D3B8130 for ; Wed, 29 Jul 2026 10:23:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785320594; cv=none; b=X/lOs72Fn6IOI/FnWlXnhovKuChBjdhUASAQoQJ5h/hSdqxA9jHTvj67r6MeWyCq7NR+oLUARslVUmZZCQP1Qf17hGZd4quVcbvcEty/c/WCXiapRi0lkAL0i8Q/MDSQlh1Gb9KaylJaXyvCBqowZRO27iZ13idu8k8zgr+q8A8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785320594; c=relaxed/simple; bh=jUn3Km5tEcwWRPT+p8Z4osC9Hs+/VTDsSUrhoqXOEd4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NdW95zlEFenEpkfaIxRS8k0tRPUi2QNYGfayMlX7/8j59jw4YwJ3jehiCN4nOI3dvLkRVSFTnooKtRoM8HqDefGwSBeHVeyGvoM9IWyd05xVxiKjBC+h7QwbfGkGApdYFSitw68xSdsX5O0RN3yohY3S/M8UhX+cPxDyWEB1hA0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=WgmSa8yY; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WgmSa8yY" Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-c1c52d920b8so109898666b.2 for ; Wed, 29 Jul 2026 03:23:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1785320591; x=1785925391; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=6X0anmnWBHgte5uXpHd51yoFKqkB+eCKd0+unp4Egcg=; b=WgmSa8yY9mHwuBRCc9IkAdIIJ5aZtBdwuZaKFUschVxbX8N2iXAURfC+CC+yo4Mifn tGyAWvVD5IDBSUzVYq4KhT50ZdDpHdBLnDJMtDUSkwW+FlYuSbaPby+bXivEo6HPtnOo 4uBqtlzvm2lCH9ZHDa6YtJafIq0GYSKU+c/mcSWJo6hwEUUF6H+TmoSPixDSJZvmpBKO 2dv/edXXqax7HExTfd8BI4uStUVEV5ny6yS8xzc4JLAWX6SXDlrz0ji0RYGtFU7RSIdW Pek9p9Z3NH/MI/x2HWhh9Lxo1zDb/eYKGw+AclLZMc9zWmjsql3uDpVXyUh1TPWmlYvB n7gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785320591; x=1785925391; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6X0anmnWBHgte5uXpHd51yoFKqkB+eCKd0+unp4Egcg=; b=aDRSqS2ZnKGGMOrFMN1D4pk1mkkCPkt4Z9utjS6T1NX0txxKNGHYPc8vCe0IPW7jLl fBk4eCcDx7QfwzmOqRT5xu5gnzsAA/HQYMNTvAMn0pl6wbQO0f+O+Rgec7XxAFq0eJIK U51CGYDSnJxIgk8y5WhcDKsVlGdi6FrwJ1TC1sL634kPfGKOwVgL4Cj+x2t01j6+BrIW lnNcD37wizHYEiYGc1VDIzH4rAwUQN16ZS8djXbJYEQvzuamy8pAW19pI/Qr4To+q5RK 1ccqhakuHbOLEBr6qRMBYpQSO/P8PUsLTrBxlFM8p5nSyFS9Kmzantj/Yig1LlXYF6cq O9TA== X-Forwarded-Encrypted: i=1; AHgh+Rpdr4i1QvxmoPNM1W4JtqoHtnVajT97miL+z3upM8ZibWUNr8gc/SyZc6o4OpiCB57l0cX3ppiUv78Da5c=@vger.kernel.org X-Gm-Message-State: AOJu0YxlGPSk3LF7Mvya6SxE3P7wuLWjltXGL5BWoO4zuXFpmZr8B14e TZN6xDNHA9xxQJu+IARPXwpPvJjgIdJZRH0qREg93NIW/8eSJ5VSyABOObue4m2Pfcs= X-Gm-Gg: AR+sD13dmX4y+Q+tXE2Gd16vvUyyQTZySHgMv9822gz+iMIBSl3G8pLx8Sz0D7KEcOt IAF52+eDNiRG1xvEluNB7sNj1w3zz8JRr8tfyuAcxErzDP5HASi1cfOLg8rBS0JNnC68MQXHIG4 XTsc8PNcRClVClxb64oqUqUPsF8ZMDrUvsngNeqYYMYPupFEndiP9l0dZHmWluvulEXNImcTziV rpNMbBEF5RBsWSg4WNP6XuF5BTKDeJrpwGsoFBcPL9KyivAbSZipVFQVFHC5FVQAOoAtwq+KQ2G /aROTB4NqHKZVaPxa27xK/plGoWHBEazTizctGoXN4T7B+IyexmDuUqpHJ0j+09/R5Z70AyFLMV M5e3JYEvys/seNyaRKpwDmimSqr+YwvavJUZ5QMd/nRFfXYcABA2u42+Ft8z3Tz7JAquJgjSKt/ 4SeGTJssXzw8RCYW5MnyrvESxxD2jvWJC2cQzmCmAB/olknMYgzqnNBQxpFsU5cYz106vtF++d X-Received: by 2002:a17:907:c08d:b0:c16:8461:e308 with SMTP id a640c23a62f3a-c1f721f0d5dmr349830366b.20.1785320590999; Wed, 29 Jul 2026 03:23:10 -0700 (PDT) Received: from [192.168.0.101] ([109.77.24.32]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1f83c6860esm95620466b.1.2026.07.29.03.23.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jul 2026 03:23:10 -0700 (PDT) Message-ID: Date: Wed, 29 Jul 2026 11:23:09 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] platform: arm64: qcom-hamoa-ec: reject incomplete responses To: Anvesh Jain P , Linmao Li , Sibi Sankar Cc: Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Maya Matuszczyk , Dmitry Baryshkov , Konrad Dybcio , linux-arm-msm@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260728111924.4106898-1-lilinmao@kylinos.cn> From: Bryan O'Donoghue Content-Language: en-GB In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 29/07/2026 11:08, Anvesh Jain P wrote: >> - if (resp[0] >= resp_len) >> + if (resp[0] != resp_len - 1) >> return -EINVAL; >> >> return 0; > Thanks for catching this — nice find. > > This is independently fixed in an in-flight series that reworks > qcom_ec_read() to use raw i2c_transfer() instead of > i2c_smbus_read_i2c_block_data(), removing the partial-read case > entirely, and it already has the same resp[0] != resp_len - 1 check. > That series just hasn't landed yet, so your report stands on its own — > happy to add a Reported-by: Linmao Li tag on that > commit when it's re-posted, if that works for you. What about -stable ? Seems like we should take this fix and your series should rebase on top of the fix instead of the corollary. That's the way this should work Fixes > New stuff. Can you add your Review-by/Tested-by and then rebase yourself ? --- bod