mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: William Breathitt Gray <vilhelm.gray@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
	Tom Rix <trix@redhat.com>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	William Breathitt Gray <vilhelm.gray@gmail.com>
Subject: [RESEND PATCH 6/6] counter: add defaults to switch-statements
Date: Tue, 15 Mar 2022 15:38:57 -0400	[thread overview]
Message-ID: <b98d1a3ed4b0b324b261b23defd1bdddddba4d44.1647373009.git.vilhelm.gray@gmail.com> (raw)
In-Reply-To: <cover.1647373009.git.vilhelm.gray@gmail.com>

From: Tom Rix <trix@redhat.com>

Clang static analysis reports this representative problem
counter-chrdev.c:482:3: warning: Undefined or garbage value
  returned to caller
  return ret;
  ^~~~~~~~~~

counter_get_data() has a multilevel switches, some without
defaults, so ret is sometimes not set.
Add returning -EINVAL similar to other defaults.

Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Link: https://lore.kernel.org/r/20220227161746.82776-1-trix@redhat.com
Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
---
 drivers/counter/counter-chrdev.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/counter/counter-chrdev.c b/drivers/counter/counter-chrdev.c
index b7c62f957a6a..69d340be9c93 100644
--- a/drivers/counter/counter-chrdev.c
+++ b/drivers/counter/counter-chrdev.c
@@ -477,6 +477,8 @@ static int counter_get_data(struct counter_device *const counter,
 		case COUNTER_SCOPE_COUNT:
 			ret = comp->count_u8_read(counter, parent, &value_u8);
 			break;
+		default:
+			return -EINVAL;
 		}
 		*value = value_u8;
 		return ret;
@@ -496,6 +498,8 @@ static int counter_get_data(struct counter_device *const counter,
 		case COUNTER_SCOPE_COUNT:
 			ret = comp->count_u32_read(counter, parent, &value_u32);
 			break;
+		default:
+			return -EINVAL;
 		}
 		*value = value_u32;
 		return ret;
-- 
2.35.1


  parent reply	other threads:[~2022-03-15 19:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-15 19:38 [RESEND PATCH 0/6] Counter updates, cleanups, and features for 5.18 William Breathitt Gray
2022-03-15 19:38 ` [RESEND PATCH 1/6] counter: 104-quad-8: Add COMPILE_TEST depends William Breathitt Gray
2022-03-16  7:39   ` Syed Nayyar Waris
2022-03-15 19:38 ` [RESEND PATCH 2/6] counter: Set counter device name William Breathitt Gray
2022-03-15 19:38 ` [RESEND PATCH 3/6] counter: add new COUNTER_EVENT_CHANGE_OF_STATE William Breathitt Gray
2022-03-15 19:38 ` [RESEND PATCH 4/6] counter: interrupt-cnt: add counter_push_event() William Breathitt Gray
2022-03-15 19:38 ` [RESEND PATCH 5/6] MAINTAINERS: Add Counter subsystem git tree William Breathitt Gray
2022-03-15 19:38 ` William Breathitt Gray [this message]
2022-03-16  7:37   ` [RESEND PATCH 6/6] counter: add defaults to switch-statements Syed Nayyar Waris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b98d1a3ed4b0b324b261b23defd1bdddddba4d44.1647373009.git.vilhelm.gray@gmail.com \
    --to=vilhelm.gray@gmail.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trix@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®