From: Steev Klimaszewski <steev@kali.org>
To: kalyan_t@codeaurora.org
Cc: y@qualcomm.com, dri-devel@lists.freedesktop.org,
linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
devicetree@vger.kernel.org, mkrishn@codeaurora.org,
hywu@google.com, dianders@chromium.org,
linux-kernel@vger.kernel.org, mka@google.com,
robdclark@gmail.com, midean@google.com
Subject: Re: [Freedreno] [v1] drm/msm/disp/dpu1: icc path needs to be set before dpu runtime resume
Date: Wed, 31 Mar 2021 12:39:17 -0500 [thread overview]
Message-ID: <b98d5a32-1776-6ae1-69ec-e06bc7143695@kali.org> (raw)
In-Reply-To: <9847b4af5331f86641eb7be5a932078b@codeaurora.org>
On 3/31/21 7:34 AM, kalyan_t@codeaurora.org wrote:
> On 2021-03-31 00:04, Steev Klimaszewski wrote:
>> On 3/22/21 4:17 AM, Kalyan Thota wrote:
>>> From: Kalyan Thota <kalyant@codeaurora.org>
>>>
>>> DPU runtime resume will request for a min vote on the AXI bus as
>>> it is a necessary step before turning ON the AXI clock.
>>>
> Hi Steev,
>
> The WARN_ON is true only for the device with compatible
> "qcom,sc7180-mdss". For other devices its a
> false alarm. Can you please try with the below change ?
>
> https://patchwork.kernel.org/project/linux-arm-msm/patch/1617190020-7931-1-git-send-email-kalyan_t@codeaurora.org/
>
>
> Thanks,
> Kalyan
>
Hi Kalyan,
Tested here, and it does get rid of the warning. I'll keep a copy of
the patch locally, since this is going to hit stable too at some point
it seems, at least until another version comes out addressing the other
comments from people way smarter than me.
-- steev
prev parent reply other threads:[~2021-03-31 17:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 9:17 Kalyan Thota
2021-03-23 0:44 ` Matthias Kaehlcke
2021-03-23 1:58 ` Rob Clark
2021-03-30 18:34 ` Steev Klimaszewski
2021-03-31 12:34 ` [Freedreno] " kalyan_t
2021-03-31 17:39 ` Steev Klimaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b98d5a32-1776-6ae1-69ec-e06bc7143695@kali.org \
--to=steev@kali.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=hywu@google.com \
--cc=kalyan_t@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=midean@google.com \
--cc=mka@google.com \
--cc=mkrishn@codeaurora.org \
--cc=robdclark@gmail.com \
--cc=y@qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®