mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: mvpp2: debugfs: fix incorrect bitwise operator
Date: Wed, 18 Jul 2018 09:32:00 -0500	[thread overview]
Message-ID: <b98ef9be-5a3d-4365-ba66-d3ba8f97a963@embeddedor.com> (raw)
In-Reply-To: <20180718160939.5650559b@bootlin.com>

Hey Maxime,

On 07/18/2018 09:09 AM, Maxime Chevallier wrote:
> Hi Gustavo,
> 
> On Wed, 18 Jul 2018 08:08:46 -0500
> "Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote:
> 
>> The use of the | operator always leads to true, which looks rather
>> suspect in this case.
>>
>> Fix this by using & instead.
>>
> 
> Acked-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
> 
> Good catch, thanks.
> 

Glad to help. :)

Thanks
--
Gustavo

  reply	other threads:[~2018-07-18 14:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-18 13:08 Gustavo A. R. Silva
2018-07-18 14:09 ` Maxime Chevallier
2018-07-18 14:32   ` Gustavo A. R. Silva [this message]
2018-07-18 17:56 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b98ef9be-5a3d-4365-ba66-d3ba8f97a963@embeddedor.com \
    --to=gustavo@embeddedor.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.chevallier@bootlin.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®