mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Youn <johnyoun@synopsys.com>
To: linux-usb@vger.kernel.org
To: Doug Anderson <dianders@chromium.org>
Cc: johnyoun@synopsys.com
Cc: Felipe Balbi <balbi@ti.com>
Cc: Stefan Wahren <stefan.wahren@i2se.com>
Cc: Michael Niewoehner <linux@mniewoehner.de>
Cc: Tao Huang <huangtao@rock-chips.com>
Cc: Julius Werner <jwerner@chromium.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org
Cc: linux-usb@vger.kernel.org
Cc: Caesar Wang <caesar.upstream@gmail.com>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: Felipe Balbi <balbi@kernel.org>
Cc: Remi Pommarel <repk@triplefau.lt>
Cc: Kever Yang <kever.yang@rock-chips.com>
Cc: Przemek Rudy <prudy1@o2.pl>
Subject: [RFT PATCH 2/4] usb: dwc2: gadget: Only initialize device if in device mode
Date: Mon, 28 Mar 2016 19:36:32 -0700	[thread overview]
Message-ID: <b990cdf90aaed1c5ffd1c89b9599c8f18c653be0.1459211397.git.johnyoun@synopsys.com> (raw)
In-Reply-To: <cover.1459211397.git.johnyoun@synopsys.com>

In dwc2_hsotg_udc_start(), don't initialize the controller for device
mode unless we are actually in device mode.

Signed-off-by: John Youn <johnyoun@synopsys.com>
---
 drivers/usb/dwc2/gadget.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
index 818f158..181080b 100644
--- a/drivers/usb/dwc2/gadget.c
+++ b/drivers/usb/dwc2/gadget.c
@@ -3127,8 +3127,11 @@ static int dwc2_hsotg_udc_start(struct usb_gadget *gadget,
 		otg_set_peripheral(hsotg->uphy->otg, &hsotg->gadget);
 
 	spin_lock_irqsave(&hsotg->lock, flags);
-	dwc2_hsotg_init(hsotg);
-	dwc2_hsotg_core_init_disconnected(hsotg, false);
+	if (dwc2_hw_is_device(hsotg)) {
+		dwc2_hsotg_init(hsotg);
+		dwc2_hsotg_core_init_disconnected(hsotg, false);
+	}
+
 	hsotg->enabled = 0;
 	spin_unlock_irqrestore(&hsotg->lock, flags);
 
-- 
2.7.4

  parent reply	other threads:[~2016-03-29  2:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-29  2:36 [RFT PATCH 0/4] usb: dwc2: Fix core reset and force mode delay problems John Youn
2016-03-29  2:36 ` [RFT PATCH 1/4] usb: dwc2: do not override forced dr_mode in gadget setup John Youn
2016-03-29  2:36 ` John Youn [this message]
2016-03-29  2:36 ` [RFT PATCH 3/4] usb: dwc2: Add delay to core soft reset John Youn
2016-03-29  2:36 ` [RFT PATCH 4/4] usb: dwc2: Properly account for the force mode delays John Youn
2016-03-31  8:52 ` [RFT PATCH 0/4] usb: dwc2: Fix core reset and force mode delay problems Stefan Wahren
2016-03-31 20:45 ` Michael Niewoehner
2016-03-31 21:43 ` Michael Niewoehner
2016-04-07 18:41   ` John Youn
2016-04-07 20:36     ` Michael Niewoehner
2016-04-07 22:12       ` John Youn
2016-04-08 10:25         ` Michael Niewoehner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b990cdf90aaed1c5ffd1c89b9599c8f18c653be0.1459211397.git.johnyoun@synopsys.com \
    --to=johnyoun@synopsys.com \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®