From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Yang Jialong 杨佳龙" <jialong.yang@shingroup.cn>,
will <will@kernel.org>, "mark.rutland" <mark.rutland@arm.com>
Cc: shenghui.qu@shingroup.cn, 赵可 <ke.zhao@shingroup.cn>,
zhijie.ren@shingroup.cn, linux-kernel@vger.kernel.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2] dt-bingdings: perf: Support uncore ARM NI-700 PMU
Date: Wed, 31 Jan 2024 11:16:01 +0100 [thread overview]
Message-ID: <b99efbd4-7c12-485d-8688-a4ec606f0cf5@linaro.org> (raw)
In-Reply-To: <873A6CC450C1D0E6+75a39d6c-4fbf-4e30-8630-3226bd725901@shingroup.cn>
On 31/01/2024 11:13, Yang Jialong 杨佳龙 wrote:
>
>
> 在 2024/1/31 17:30, Krzysztof Kozlowski 写道:
>> On 31/01/2024 10:26, Yang Jialong 杨佳龙 wrote:
>>>
>>>
>>> 在 2024/1/31 15:49, Krzysztof Kozlowski 写道:
>>>> On 31/01/2024 07:59, JiaLong.Yang wrote:
>>>>> Add file corresponding to hx_arm_ni.c introducing ARM NI-700 PMU driver
>>>>> for HX.
>>>>>
>>>>> Signed-off-by: JiaLong.Yang <jialong.yang@shingroup.cn>
>>>>> ---
>>>>> v1 --> v2:
>>>>> 1. Submit dt-bindings file Seperately.
>>>>
>>>> Where is the driver?
>>>>
>>>> Please read:
>>>> https://elixir.bootlin.com/linux/v6.8-rc2/source/Documentation/process/submitting-patches.rst
>>>> before posting.
>>>>
>>
>> Keep all discussions public.
>
> Get.
>
>>
>>
>>>>> + pccs-id:
>>>>> + $ref: /schemas/types.yaml#/definitions/uint32
>>>>> + description: Used to identify NIs in system which has more than
>>>>> + one NI.
>>>>
>>>> No, reg does it. Drop the property. Anyway you miss here vendor prefix
>>>> and proper explanation.
>>>>
>>>
>>> reg will tell phy address. Phy address is too long. I just want a id.
>>> example: perf stat -a -e ni_pmu_${pccs-id}/cycles/
>>> I will use it in user space. Not only in driver.
>>
>> Custom vendor property is not for that purpose. Use for example IDR, DT
>> aliases or something else.
>>
>>
>
> I have considered TD aliases. It's not very easy. Two places...
> IDR.. I have tested. But it chouldn't correspond to the HWs.
> I need it to identify NIs.
> DT aliases is reachable. But no very easy.
Except that "you want" I did not see any rationale, any argument
explaining why this is needed and why this has to be present.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-01-31 10:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 6:59 JiaLong.Yang
2024-01-31 7:49 ` Krzysztof Kozlowski
[not found] ` <02B995F774AB7A9D+adfd0934-00cb-4dc3-8bf8-058b83dc2fbb@shingroup.cn>
[not found] ` <ebbc9d73-9be2-49ae-98f3-0d71ce624ee4@linaro.org>
2024-01-31 10:13 ` Yang Jialong 杨佳龙
2024-01-31 10:16 ` Krzysztof Kozlowski [this message]
2024-01-31 10:18 ` Yang Jialong 杨佳龙
2024-01-31 16:59 ` Robin Murphy
2024-02-01 2:24 ` Yang Jialong 杨佳龙
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b99efbd4-7c12-485d-8688-a4ec606f0cf5@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=jialong.yang@shingroup.cn \
--cc=ke.zhao@shingroup.cn \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=shenghui.qu@shingroup.cn \
--cc=will@kernel.org \
--cc=zhijie.ren@shingroup.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®