From: Gladyshev Ilya <foxido@foxido.dev>
To: Armin Wolf <W_Armin@gmx.de>
Cc: "Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
"Nikita Krasnov" <nikita.nikita.krasnov@gmail.com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"open list:INPUT (KEYBOARD, MOUSE, JOYSTICK,
TOUCHSCREEN)..." <linux-input@vger.kernel.org>
Subject: Re: [PATCH 1/1] Add WMI driver for Redmibook keyboard.
Date: Tue, 29 Jul 2025 11:37:47 +0300 [thread overview]
Message-ID: <b9a06c17-c18d-4ff1-b020-9eea505a6f41@foxido.dev> (raw)
In-Reply-To: <2aa477f3-526e-4b06-826a-83f95633c040@gmx.de>
On 7/29/25 00:47, Armin Wolf wrote:
> Am 28.07.25 um 00:34 schrieb Gladyshev Ilya:
>
>> This driver implements support for various Fn keys (like Cut) and Xiaomi
>> specific AI button.
>
> Interesting, i was just talking with another person about implementing a
> WMI event
> driver for the exact same WMI event device. I CCed the person involved
> in the discussion
> so that he can test this driver on his device as well.
> All in all the driver looks promising, but there are still things that
> need to be improved
> before we can include this driver in the mainline kernel. For details
> see below.
Thanks for your feedback, will fix in v2. However, I have small
question: do I still need a mutex for linearizability if I implement
driver via sparse-keymap? I've copied mutex from xiaomi-wmi, but as I
looked up not all WMI keyboard drivers use it (fujitsu-laptop, acer-wmi).
--
Gladyshev Ilya
next prev parent reply other threads:[~2025-07-29 8:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-27 22:34 Gladyshev Ilya
2025-07-27 22:38 ` foxido
2025-07-28 21:26 ` Armin Wolf
2025-07-28 21:47 ` Armin Wolf
2025-07-29 8:37 ` Gladyshev Ilya [this message]
2025-07-30 16:35 ` Armin Wolf
2025-07-29 13:10 ` Nikita Krasnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9a06c17-c18d-4ff1-b020-9eea505a6f41@foxido.dev \
--to=foxido@foxido.dev \
--cc=W_Armin@gmx.de \
--cc=dmitry.torokhov@gmail.com \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikita.nikita.krasnov@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®