mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Li,Rongqing(ACG CCN)" <lirongqing@baidu.com>
To: Sean Christopherson <seanjc@google.com>
Cc: "pbonzini@redhat.com" <pbonzini@redhat.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: 答复: [????] Re: [PATCH] KVM: eventfd: Remove redundant synchronize_srcu_expedited from irqfd assignment
Date: Tue, 10 Mar 2026 01:37:26 +0000	[thread overview]
Message-ID: <b9a1319e93b6445f87ae87a6c419a07f@baidu.com> (raw)
In-Reply-To: <aa7o-4eHAfTikGec@google.com>



> On Mon, Mar 09, 2026, lirongqing wrote:
> > From: Li RongQing <lirongqing@baidu.com>
> >
> > The synchronize_srcu_expedited() call in kvm_irqfd_assign() is
> > unnecessary when adding a new irqfd to the resampler list. The list
> > insertion is already RCU-safe, and existing readers will either see
> > the old or the updated list without inconsistency.
> 
> It's not required for kernel safety, but I do think it's required for KVM's ABI, e.g.
> to ensure the resampler is visible to readers before KVM_IRQFD returns to
> userspace.
> 

Thanks for explanation, It would be best if a comment could be added.

> > Removing this call reduces latency during resampling irqfd setup.
> 
> May I ask why you're micro-optimizing VMst with an in-kernel I/O APIC?

Few devices use it anymore; I just think the kernel ABI shouldn't require synchronize_srcu_expedited.

Thanks

[Li,Rongqing] 

  reply	other threads:[~2026-03-10  1:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-09  9:21 lirongqing
2026-03-09 15:36 ` Sean Christopherson
2026-03-10  1:37   ` Li,Rongqing(ACG CCN) [this message]
2026-03-10 14:12     ` 答复: [????] " Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b9a1319e93b6445f87ae87a6c419a07f@baidu.com \
    --to=lirongqing@baidu.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®