From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2F3FC7EE2C for ; Tue, 6 Jun 2023 09:12:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233354AbjFFJMt (ORCPT ); Tue, 6 Jun 2023 05:12:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232560AbjFFJMb (ORCPT ); Tue, 6 Jun 2023 05:12:31 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63B95E4F for ; Tue, 6 Jun 2023 02:12:23 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-977cc662f62so402220666b.3 for ; Tue, 06 Jun 2023 02:12:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686042742; x=1688634742; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=r4AmdVwg4gjTsAxfk42+ya/xr1mTSRxxbVKQ3XrFUpQ=; b=PnGKM47mpj3Ddc0oSOEllxLh+oOxYtyvpANv4U3kMcbOr/jE0l0k2q4H0SonOqThMB 1bWpcUnZ2cJQns1go/rFdSkU6JyA5wm0uZzXtAS65t/BrkvGuymnrxqB9y7RbQwwzrwB RtGRMJSHvh4A7hK5EjmNlOApop0WmF30BooHT/TlzYGVLJqPYAriWOIiw4OVNtFRGYGf u8qbcP8YNWTx5oSLaswmdNiyc8inJh6ERiE7Oi03fWtjan0YPRaPagyBzA0iyBuTdnDc evOfD8rjLngWo+AlXOWO/2pRrjiBsgfO/IIWdJfQJ68k5qVKOpXGdaeiuhn/7VVlwWZC L2Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686042742; x=1688634742; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=r4AmdVwg4gjTsAxfk42+ya/xr1mTSRxxbVKQ3XrFUpQ=; b=LyLH0WPABmuZnCtg059rNMbd+PMfK0NF6aSSU7Z2ViGDtFlwxLvlJNhUjlGqqrSZkR RhfDl6ntKNdki1vPtRAPWBmatqtLTYXA6fyjoVlLKX92LydfZRNH5EfKt7UvzxqrnoAs jy/fD6BMWohshZyN8lr2JGAVtevQiVBatWxcegOvjNMvatPzxzQFDYWMNSLTRjkbufIJ 8K2u5xLF29bcfX6KbM8aE9GK8FSFb8ckqnuAK5HOIN5tyCDZWRKC7iTpFvfhUgn6atkJ vYmupbWu9CUFWxtluTAnOhhlTCPrY10Xl2ux97p3ayOS5Y+1bHtUcoStuG3Wok7HUOAX yzjw== X-Gm-Message-State: AC+VfDynKF3quUFRP8gZDq14sMrOx5cjHSKJslZaodF28XlY6t/UAinU abAfVguZHBQow4v/yjSG6A9+/Q== X-Google-Smtp-Source: ACHHUZ4ICG/LiMH48iJ6ITReWMZhhxEFrAzzKgQao53xyViRDfBvZqW8oHYQ9GVk/zBWdm4mgBP5YA== X-Received: by 2002:a17:907:94d4:b0:971:2eaf:556 with SMTP id dn20-20020a17090794d400b009712eaf0556mr1942718ejc.18.1686042741710; Tue, 06 Jun 2023 02:12:21 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id d12-20020a1709063ecc00b0096f03770be2sm5289135ejj.52.2023.06.06.02.12.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Jun 2023 02:12:21 -0700 (PDT) Message-ID: Date: Tue, 6 Jun 2023 11:12:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH 1/6] media: dt-bindings: mediatek,vcodec: Allow single clock for mt8183 Content-Language: en-US To: =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , Matthias Brugger , Hans Verkuil Cc: AngeloGioacchino Del Regno , kernel@collabora.com, Andrew-CT Chen , Conor Dooley , Krzysztof Kozlowski , Mauro Carvalho Chehab , Rob Herring , Tiffany Lin , Yunfei Dong , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org References: <20230605162030.274395-1-nfraprado@collabora.com> <20230605162030.274395-2-nfraprado@collabora.com> From: Krzysztof Kozlowski In-Reply-To: <20230605162030.274395-2-nfraprado@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/06/2023 18:20, Nícolas F. R. A. Prado wrote: > MT8173 and MT8183 have different clocks, and consequently clock-names. > Relax the number of clocks and set clock-names based on compatible. > > Signed-off-by: Nícolas F. R. A. Prado > > --- > > .../media/mediatek,vcodec-decoder.yaml | 29 +++++++++++++------ > 1 file changed, 20 insertions(+), 9 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-decoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-decoder.yaml > index fad59b486d5d..57d5ca776df0 100644 > --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-decoder.yaml > +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-decoder.yaml > @@ -27,18 +27,12 @@ properties: > maxItems: 1 > > clocks: > + minItems: 1 > maxItems: 8 > > clock-names: > - items: > - - const: vcodecpll > - - const: univpll_d2 > - - const: clk_cci400_sel > - - const: vdec_sel > - - const: vdecpll > - - const: vencpll > - - const: venc_lt_sel > - - const: vdec_bus_clk_src > + minItems: 1 > + maxItems: 8 > > assigned-clocks: true > > @@ -88,6 +82,11 @@ allOf: > required: > - mediatek,scp > > + properties: > + clock-names: > + items: > + - const: vdec You should constrain also clocks as they must be in sync with names. > + > - if: > properties: > compatible: > @@ -99,6 +98,18 @@ allOf: > required: > - mediatek,vpu > > + properties: > + clock-names: > + items: > + - const: vcodecpll > + - const: univpll_d2 > + - const: clk_cci400_sel > + - const: vdec_sel > + - const: vdecpll > + - const: vencpll > + - const: venc_lt_sel > + - const: vdec_bus_clk_src Ditto. Best regards, Krzysztof