From: John Garry <john.g.garry@oracle.com>
To: Caleb Sander Mateos <csander@purestorage.com>,
Jens Axboe <axboe@kernel.dk>
Cc: Keith Busch <kbusch@kernel.org>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block/merge: remove unnecessary min() with UINT_MAX
Date: Sat, 15 Feb 2025 07:33:02 +0000 [thread overview]
Message-ID: <b9c1655a-83c3-4ac7-a601-6f8161cf3c13@oracle.com> (raw)
In-Reply-To: <20250214193637.234702-1-csander@purestorage.com>
On 14/02/2025 19:36, Caleb Sander Mateos wrote:
> In bvec_split_segs(), max_bytes is an unsigned, so it must be less than
> or equal to UINT_MAX. Remove the unnecessary min().
>
> Prior to commit 67927d220150 ("block/merge: count bytes instead of
> sectors"), the min() was with UINT_MAX >> 9, so it did have an effect.
>
> Signed-off-by: Caleb Sander Mateos<csander@purestorage.com>
FWIW:
Reviewed-by: John Garry <john.g.garry@oracle.com>
next prev parent reply other threads:[~2025-02-15 7:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-14 19:36 Caleb Sander Mateos
2025-02-14 22:40 ` Jens Axboe
2025-02-15 7:33 ` John Garry [this message]
2025-02-15 11:51 ` David Laight
2025-02-16 22:09 ` Caleb Sander Mateos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9c1655a-83c3-4ac7-a601-6f8161cf3c13@oracle.com \
--to=john.g.garry@oracle.com \
--cc=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®