From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49CB12857F1; Wed, 25 Jun 2025 10:26:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750847187; cv=none; b=Y0MPRKnU92ekzaNUMIab+s2PY0AX0BbcqLVmDqOtvYh72nZa3j+m3bNm+fceiShh4Ck5sf93ri2PDQH09bBp9WRpVsPoiZ41JqP3Dn3KXpvcSOzFU8zGTjjJw4HBDdog7+ycwi+rHjJDa8fW9biroywCoFHlWhRXQDafYwpS9w8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750847187; c=relaxed/simple; bh=WAI+AvaW29sVFj8wNvdtZZGM9Oyc9J1oDfNXZu7CHks=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=E2Irx9Dxvk8Pg1p33I2Vfa/W6gVp+ssz8RGFUVXVhhphAJdgcQMGGxifELBFaeHwSCRJlLh2xFp9W/Pg/OfxRMtI51VtWwI3muFUW+pNPvh9F/cxbFpNvcT8scsJ7X/10PYSF/972FD17Xs65xzqwBh32hYrtZwfSoIVO3tVeh8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=m8xA7t6Q; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="m8xA7t6Q" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 469C1C4CEEA; Wed, 25 Jun 2025 10:26:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750847187; bh=WAI+AvaW29sVFj8wNvdtZZGM9Oyc9J1oDfNXZu7CHks=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=m8xA7t6QLs2AN3YcXLpvsFBPTnxmLQmqJuyJ61z/Er9cRURMQL4B9jRV7tFiCkjLV RUqVUdxcGKQgU5ZWlvu4oc8It+S6QrqKgsejHl6NujXLydMJ1ZS45ZKIHWA4axqUA6 0j1KZBt4MB0StJuTG/wfwNcGZOuUUP7NyUvaSmF/QSc0wyG6Ej+JN8KpArSpkoMZMw ftjiNfYEsQJGnnEixtWnH/zqCiQFqjxHzvaRpbwWoZfCl/tK0MEjsTPWNQRMsHu2cU 5WIeREUvGsR5sAsxD9UgW4KqAuhIsZOOrCOKVlRhQbn1WfO9G6ShO7t56SVrNwDnd0 zQ3sFcs6CX+2g== Message-ID: Date: Wed, 25 Jun 2025 12:26:21 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFT 2/6] gpio: mmio: get chip label and GPIO base from device properties To: Bartosz Golaszewski Cc: Bartosz Golaszewski , Linus Walleij , Lee Jones , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Russell King , Alim Akhtar , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, patches@opensource.cirrus.com, linux-samsung-soc@vger.kernel.org References: <20250624-gpio-mmio-pdata-v1-0-a58c72eb556a@linaro.org> <20250624-gpio-mmio-pdata-v1-2-a58c72eb556a@linaro.org> <6c64751d-67f6-4c30-a312-af289d9f432e@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 25/06/2025 12:23, Bartosz Golaszewski wrote: > On Wed, Jun 25, 2025 at 10:54 AM Krzysztof Kozlowski wrote: >> >> On 25/06/2025 09:35, Bartosz Golaszewski wrote: >>> On Tue, 24 Jun 2025 at 21:44, Linus Walleij wrote: >>>> >>>> On Tue, Jun 24, 2025 at 3:19 PM Bartosz Golaszewski wrote: >>>> >>>>> From: Bartosz Golaszewski >>>>> >>>>> Ahead of removing struct bgpio_pdata support from the gpio-mmio generic >>>>> module, let's add support for getting the relevant values from generic >>>>> device properties. "label" is a semi-standardized property in some GPIO >>>>> drivers so let's go with it. There's no standard "base" property, so >>>>> let's use the name "gpio-mmio,base" to tie it to this driver >>>>> specifically. The number of GPIOs will be retrieved using >>>>> gpiochip_get_ngpios() so there's no need to look it up in the software >>>>> node. >>>>> >>>>> Signed-off-by: Bartosz Golaszewski >>>> >>>> This works for me. >>>> I wouldn't be stoked to see device trees abusing the "gpio-mmio,base" >>>> property all of a sudden just because it now exists as a device >>>> property though... I kind of wish we had a way to opt out of exposing >>>> this to all the sub-property paths. But it seems tiresome, so: >>>> >>>> Reviewed-by: Linus Walleij >>>> >>>> Yours, >>>> Linus Walleij >>> >>> That's not a problem - this property is not in any DT bindings and as >>> such is not an allowed property in DT sources. For out-of-tree DTs? We >>> don't care about those. >> That's not true, we do care about implied ABI. Try changing/breaking >> this later, when users complain their out of tree DTS is affected, and >> explaining this all to Greg. >> > > Wait, seriously? I thought that the upstream bindings are the source > of truth for device-tree sources... They are, until they are not... ok, we don't really care that much about out of tree DTS, but in-tree DTS still could use these and don't care about bindings check, right? Best regards, Krzysztof