mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Will Whang <will@willwhang.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] media: i2c: imx585: Add Sony IMX585 image-sensor driver
Date: Sun, 17 Aug 2025 10:28:14 +0200	[thread overview]
Message-ID: <b9c8d571-e0ce-4703-8748-96f7ca4a59bf@kernel.org> (raw)
In-Reply-To: <CAFoNnrxT83nz0qxf8HTapqOXuEQ0Vh+RbxyqRGQy_sJp9nzpAg@mail.gmail.com>

On 17/08/2025 09:53, Will Whang wrote:
>>>
>>> And in all the examples I provided to you, this is the only IMX415
>>> that has the logic inverted.
>>
>> And? All other drivers, camera sensors, hwmon, iio, codecs and whatnot?
>>
> Are those Sony image sensors?
>>
>>> I can apply the same logic and say this is buggy and wrong.
>>
>> We are not going to talk imaginary things.
>>
> So you can imagine this code is buggy even though I tell you this is correct?
> Of course I tested it already.
> 
>>> Do you understand this is writing the GPIO directly and has nothing to
>>
>> It is not. Again, you are mixing logical level with line level. You
>> never responded to that part, you never used actual arguments except
>> some vague statements like above.
>>
>> You do not write GPIO directly.
>>
>> Each driver is supposed to use logical level.
>>
> hmm? Code in the tree disagree with you? Are you going to arguing that
> all the 90% of Sony image sensor drivers are old and buggy?


I checked now and both driver and all users of imx219 are wrong. Don't
ever use that as an example.

And you doing THE SAME as imx219 is also proof that your code is wrong.


Best regards,
Krzysztof

  parent reply	other threads:[~2025-08-17  8:28 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-16  5:54 [PATCH v3 0/2] media: Add Sony IMX585 image sensor support Will Whang
2025-08-16  5:54 ` [PATCH v3 1/2] dt-bindings: media: Add Sony IMX585 CMOS image sensor Will Whang
2025-08-16  8:04   ` Krzysztof Kozlowski
2025-08-16  5:54 ` [PATCH v3 2/2] media: i2c: imx585: Add Sony IMX585 image-sensor driver Will Whang
2025-08-16  8:03   ` Krzysztof Kozlowski
2025-08-16 19:58     ` Will Whang
2025-08-17  6:10       ` Krzysztof Kozlowski
2025-08-17  6:46         ` Will Whang
2025-08-17  7:02           ` Krzysztof Kozlowski
2025-08-17  7:15             ` Will Whang
2025-08-17  7:35               ` Krzysztof Kozlowski
2025-08-17  7:44                 ` Krzysztof Kozlowski
2025-08-17  7:53                 ` Will Whang
2025-08-17  8:20                   ` Krzysztof Kozlowski
2025-08-17  8:28                   ` Krzysztof Kozlowski [this message]
2025-08-18 11:14                   ` Sakari Ailus
2025-08-18 15:05       ` Nicolas Dufresne
2025-08-18  7:58   ` Kieran Bingham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b9c8d571-e0ce-4703-8748-96f7ca4a59bf@kernel.org \
    --to=krzk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=robh@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=will@willwhang.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®