From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938882AbcKLPtK (ORCPT ); Sat, 12 Nov 2016 10:49:10 -0500 Received: from mail-bl2nam02on0047.outbound.protection.outlook.com ([104.47.38.47]:9440 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934577AbcKLPtH (ORCPT ); Sat, 12 Nov 2016 10:49:07 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Thomas.Lendacky@amd.com; Subject: Re: Spurious code in commit 1bf40ada6290 ("amd-xgbe: Add support for clause 37 auto-negotiation" To: Marion & Christophe JAILLET , References: <80c6a7b3-4a03-e087-3638-7048adebbda8@wanadoo.fr> CC: , , Kernel Janitors From: Tom Lendacky Message-ID: Date: Sat, 12 Nov 2016 09:47:44 -0600 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <80c6a7b3-4a03-e087-3638-7048adebbda8@wanadoo.fr> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SN1PR07CA0008.namprd07.prod.outlook.com (10.162.170.146) To DM5PR12MB1146.namprd12.prod.outlook.com (10.168.236.141) X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1146;2:vpsTAZ9Wt7Za6AiBrTjq5cZRzeAelyC/AA0ZyyMtju0MAAed+g4DlUOYi+/bf3yHZX9PDdUKkGBzR847ur7CEgAREQ8R1VXWhD68aRdStOyPIflWaucZEXuuRcrh33BCC0sn5naGvwN1+2zJrZxgkKd8r/BjSdVtWg8LTkTwdE4=;3:xtsIjlQb7uTvezuLX9IGXgfZBR6U9KvaAjuAcLejxoJeR50bAvR8ELwUFQZzDzUB3zXqbnGNAvCDpZR74qyulvnFdgwZl8tLN8Oku3o93/s8ZrQ8aWQYN43hm6SY9d8WoLFfWGHNzicjNpPw0EEGDd6w/B+9dtg/zs8MpVtf9fI=;25:jKdmXdGJYVPBGz3g2L6pXUdzeqXVZFAA3zMoxqsViYfZcKZTpCt86FLRwYkdgv41rUiJb2M3l0Lz1Oj0PbTEXJTSEQmtirhC6eEC+yEhm6QCDlo+RHzUj1fkGgjbCBjxDE7j4WzsV6LJSodqPktKZIHRcePlIJVhIwDU4O66cgCAdhLnOzQ8bvIv01Cv/lc+a7izpXPXFaOp+z3Yy/twW7pCkmjtbgsqwkCG4HICyzBhnWfn+cT2/2ZgaB/l7U3ZO7FxrWRAVrdMnWuawfyqRXucH53CFilZiK6NL/5su7FPuZLMSYPyKdpIhFAZYEXK+JWO5nIEmMWPBP5Zq8XXNi+sX4oG8avv0JVZAH/wsKpzILo4fn1lCDqyddCZHsgCCiudIDu7heMf0Wf4JdrL9k/B/hs/nddovC/1jTb9DIh6eG/WC7Vz7Id8y778ssuK X-MS-Office365-Filtering-Correlation-Id: 31861df7-012b-4aad-e3e5-08d40b134fe6 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:DM5PR12MB1146; X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1146;31:I3Bb2/QV0f3+7Yz8CilJCypynvLd3kY+Q0Ax/oGDldA6YKufKs2D6qYK+1ypjptzP0D0vbUp8JYl1xMXh1t3DYFFRJtgMPZrqQJVNZ1NpP0p6Zhw1LPlPJ6I25wW8Brc4iXDnA1/3qdp0O0gm26EdjL5oOE2q6rmSDFGn3wWqo0K5DJNHXyJd0z+71R2yF4BtPEwsOvAdIkcm4fzqaIIagad3vFkVO3PeHAwmpjeb2l7jcwo1WOaFFwHnPNE7cG1Enda1b1wejthTYuOYkB38g==;20:2SlfYzAc90K58hT+d3VS5DOa8wpmQ79srS+GfvN1an7DRMrwnSP3uu6Dgv1KmwotOdiRt4yJp7BU5XJx2sBfC5r3ZmGzMpZ9qErukIRDVQ/ghsZQc2hJKbf6vHliIbIQS+RVaaKUAgAxbrWdzQXxFT1TGqDSUiZng7DBOHIkCQqgmwK7yamyPAH5Bh/mNw0AObshPXi6zV2C6iVhPNxsZcGvQWJuXWeS094xYUlQAR4dhBMr2nhPDB+Hn0aDn66ohIwEi2goTwGRX2eX7e5In1+cUkWOPqA3VY6ONb6luKTgeuZF6yGioXeDtSFRbStUXb0RPM2swcodE6cTtntpRnXttUvYh6IKp4tCXR7XilT99gy0rzoUXlS4xOgb2xwRW9xOQyw73KwA6CWQ+mgjgrcHoGfsWhGvM/gFCkie+4qjvvJ8x65itmf5+oc1gqDNnMIpaZ3DN+QFvQDwTPQOEHDhRs+bV5aOnXJVMs+0e0/NfwViobFxB78FGoilB60e X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026);SRVR:DM5PR12MB1146;BCL:0;PCL:0;RULEID:;SRVR:DM5PR12MB1146; X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1146;4:vwJuk9ilSUJdCrKx7SDHHAMsu6gW1tfUQmbBFuyu31Kkb+M0OnAUtM3wo0or2oxwf5lOTD9jokguZYzF5Sm9z9+smOcLkhOTqwRtBJu9sUgTf6sz5EACf5alO/dipFu2ClzGw6G2zxyc3/Ow+TRgIuRHHwNNxWiIWfs4OZI2mSmtQxsrqNoKKulZQNtxWblYVYZ54a3VciR6BZW0GBcZzJ+86MtngIPIaOSpcHnrDzvEGw6mbic5MZR7VOlaAozmhWzUgRGJahRiijU+ra2UrZqtM4sbQhLum7t39Nhb4NWUU1IGzPLRJxSqgNZQsvV6DzI1vPLAiIf/tqNONsjCqhbugQipyp5sDwAT/HveLHuGLDVzT2kv2wdgqN4oa8z0WvpoxyRVU6gdyK/FfZLVFSNL1pdE1NQDNongIo5oIkA= X-Forefront-PRVS: 01244308DF X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(7916002)(189002)(377454003)(24454002)(199003)(36756003)(66066001)(6666003)(65956001)(65806001)(92566002)(2950100002)(77096005)(47776003)(8676002)(81166006)(81156014)(83506001)(33646002)(65826007)(229853002)(31696002)(68736007)(5660300001)(64126003)(586003)(4001350100001)(189998001)(5001770100001)(2906002)(50986999)(4326007)(54356999)(76176999)(86362001)(7846002)(7736002)(31686004)(42186005)(105586002)(106356001)(230700001)(101416001)(23676002)(97736004)(3846002)(305945005)(6116002)(50466002);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR12MB1146;H:[10.236.64.222];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjEyTUIxMTQ2OzIzOkdlUFdzY3Q5Mnl5WVlqQ202aGZiZUhFNHNE?= =?utf-8?B?WTR2OFpsLzE0MHRmZ3VDUlM3MTMwWkt2QlZrN0IrekxsZmdZZU9EQWk4Nndt?= =?utf-8?B?djY0R29IdkIvY09uc3l1YnphZzZtdTVjZDdoUFZ2M2dPL2JFV296YjBDajQw?= =?utf-8?B?R2t0T0VHVExNNUl4N0xOQkQ5NjRTSk1HY0MwZWtGa1lncE9lUzlNY0FBdE44?= =?utf-8?B?L3QwZmlYeTZ2UjQzN0xTRGpLRmNVUmczbWpRU3Z3ZXVZTHpiVTdGdzA0bnJp?= =?utf-8?B?Lzh5VTRyU1pPSDQ1OHNNNG53Ty9wSlcycGFQTzZXcUR6K2o2MDR0Ri9ZajdQ?= =?utf-8?B?Zm81cGUrZ2JaUlo2RTErSkFHNmVHYlVHckZsbUF4TnpoM2t5RGVQbERqNGh2?= =?utf-8?B?cGRjcDdjVXQxbVduSWM3ZjF1dlVLYVdnUTVvNnRpdHF0NlpTMmc3ek1tRVJl?= =?utf-8?B?eUlVelFEM1NXY013UkMwaUU2QU1DclQ2NlVpc1dXN2ZXeXRVMUtGbGtxamtj?= =?utf-8?B?c1JuQk43NWxxemtZSGhrVE1OaDZ5RWtLM0puMzRBdm9PZnErbVdJeEQvOFRq?= =?utf-8?B?RXh1Yi82TS8waHZLWUNwckJpdCt4MVdLM09KMlF3M1NwL2d3TVJiRUFPRDNj?= =?utf-8?B?eXNMbTBYVjRLMmQ1alVhcTQ1MWFJcGtPZEZGWSttTUNGVEFBcnBRQmYrcVkw?= =?utf-8?B?bVZ4by9ZOTEyYlJaSytHTVJCb1dab0pxeHc0bVd2MHVaUGlqU2c3WlZ6d2RI?= =?utf-8?B?N2M3ZVUrUzJsby9WTzh6S29ZcTdhUFhPOU9MTklBR1hEV0JsNkwySmNJN0sx?= =?utf-8?B?MUJzNFp4QnVWSjExOXFaeGFvanN1a21CVnBVZzdveDRUVHZ1bW1ISUNZalQx?= =?utf-8?B?Y0dvaENwV2FFK1lueFlJY3VQajcxQjRWbU0xSEc3NGdmQU92SHZGTW1ZWnRa?= =?utf-8?B?b3pHdEp4M2s5NXZmL09OejUvQVJWdWR5YTZycXl2d2NESnlGak5tSWlVUFpv?= =?utf-8?B?bnR6cjJsbUJHalF1cnp3aisxeXY3bVlTMWMzSEVuUzNkSmFlL1ZFeFFlWktG?= =?utf-8?B?bTlyemV6Zlo1cVhtY0dncU5WMjIzTDIrVi9IV3VLNlExTUpBWEsyUTR6YXcv?= =?utf-8?B?Y3lka09QVHBrd25iSmw0ZFdiTFlXVnR0YnMxTUdPMVNVK2tHNkN3cEtqVmVX?= =?utf-8?B?dEJEWE5DOE1FYk5CcGdPeFlJbG01SjlMb3VON28wRDZnYWtUeHRCbm9QbVRu?= =?utf-8?B?WE9PRGZWbzkwVEVFL1hyUDBvU0J4cjgzd1RMVHNLNEo2ZHRhRUl3UStJaExu?= =?utf-8?B?K3AwbEs3M1E2QUhOZVJYaTVRSWxKYXdCSnd6bEZKS0Z5Q2o0UkR3ckJ6aENu?= =?utf-8?B?cm9xWDd1OGhTbENHUzE5aDVZcEZKYmFqRzRyaDZwaFB2Vk96Y2dtRHV0T3N5?= =?utf-8?B?amVkQytZSTJNY2NWNi84MUh6TGxFZ1ByZGF0WllUZ2pDY2JEOVFLdnk0Ulcz?= =?utf-8?B?MUNySkdZaFRyOXp5UTF1N0l0eTJydG1UMlJ5YjFOOGs0V2ViR0ExOE1jZ3c2?= =?utf-8?B?Q3dvQ0Jicm5WMEc1N2xmMUNhRE0vaHRWVEY3SFJZS1B3UFk4c2JXVWNqbnMx?= =?utf-8?B?R3kxdVJjazhzdVBseHBvRkthL3pzNHM1aHRtWGFwaHpCdktTK2RJQ3VVRzdF?= =?utf-8?B?dHVMblRLL3A4U2oxUzVQeEdTT2Qzc292L1hvMkk5cFc1alpKNVpsUThPaWMv?= =?utf-8?B?REZualM1c001NHhKZHN6dz09?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1146;6:T6ay8RoalQamGFZx9kpT1QbJQ36m3PX9x5wedlc+sDH4U+fOfgF3u0hhn301HUo7k6VjzKM9AwlkDscnAsGV3N7G0mXMAwc28jJBUcI/sc0LONa0IU6J7i127ewFJwWXLClD3OhfqgpXlF+nOekXzNIPZzcgB+ddacizAofob4dJWUMp386ijRWDWYxCoqk5TvlHiLUauuEfcjrD1hj8zHiWdiCYjt0PyQ9WmVcPQq0QDkMLYJcVA8Ea9t1eJAVSlbMZSSnKcCo4xjMadBY2ZYzuJGRQT1FZ2QbaWviOwiYZjWQc+Kgxl+bSqx4u9mjXCzfoAvJE1K/GfoNQyWl2UA==;5:odiAeB+F89hO21EdBzzLjyv7vV4fWHi3O8u+DfYgADmrvtZg4piNEIA17BjjiAFagQinQWmdojHjGjYZDOR5aOMucmX2OkP2N+1DzpPoFuH3rn+BLfhYy1Ppsaqezw5ySXpgQH0yI8+Yks/sNdjPng==;24:09jGTCT9D+NFdcEcqNDCf1b7dJjdLsBmHEfWOO7owA5rWMwoHYVGN1oDpQHWyfeRvhisZpOdfEOEsPyaK66LQwJfKCm1zk/2xu9jRwzt3FQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1146;7:HIBA/IV6vgCOl5kQw1KcgUb/eU4/ZWAgbvqbybaKorna8TBPs/QbEnmu1WL9wYbnu3X5Z006Rj0u30xk0eBiLiBSEPAgnWl9b0msOS3O6AR6DXhh2hxnJjCAmUEy+ev3Vtlf1tuqKgK18ACKB3wMZZWHyLaVUUduOnuoi3QZIB3eptfgzw12WzbaiK/FACYd/y/UtsxAUk6bqeQlnZpslIeWkmA2MA9zm0Xj2QL78M4fa349Jo0ZA9i9rbGDJd53hBy1YywwkwYGakmPrPgbDXCKo1z1McoWmYpIwNLbkSBok0cXPn+/HmowwY4xCYiN/wy9nrLqqAbAKXPJHMvNYCDnVX6/7NjUnAnOfBxDVtI=;20:5vvBfh9mTSOo14bzocuc36+RstDoDux8Q47og8m6epgukT+LsYileeu5lUhOLOvfUoS4c/DAyRUQzUVZMQDzR0zkNggMbK5MveRNfmhFWcSfspCJC9CAH6+ndkSUYQlV6L31GuHIi7IFFsfuWpIGkYyN2tCXqJMFkWtALKCS2H9kjIO4MQX7elf5JyVv02+diCIvNYifiBdsA8dQgMQencBYQLKN315OfGNWpuEPHskHdYYxyYveBHeJIt9w51km X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Nov 2016 15:48:13.5425 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1146 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/12/2016 8:34 AM, Marion & Christophe JAILLET wrote: > Hi, > > in commit 1bf40ada6290 ("amd-xgbe: Add support for clause 37 > auto-negotiation"), we can find: > > diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-common.h > b/drivers/net/ethernet/amd/xgbe/xgbe-common.h > index 695e982..8bcf4ef 100644 > --- a/drivers/net/ethernet/amd/xgbe/xgbe-common.h > +++ b/drivers/net/ethernet/amd/xgbe/xgbe-common.h > [...] > #define XGBE_AN_CL37_PCS_MODE_MASK 0x06 > #define XGBE_AN_CL37_PCS_MODE_BASEX 0x00 > #define XGBE_AN_CL37_PCS_MODE_SGMII 0x04 > #define XGBE_AN_CL37_TX_CONFIG_MASK 0x08 > [...] > > diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c > b/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c > index d5bfbe4..723eb90 100644 > --- a/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c > +++ b/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c > [...] > /* Set up the Control register */ > reg = XMDIO_READ(pdata, MDIO_MMD_VEND2, MDIO_VEND2_AN_CTRL); > reg &= XGBE_AN_CL37_TX_CONFIG_MASK; > reg &= XGBE_AN_CL37_PCS_MODE_MASK; > [...] > > the "reg &=" statements look spurious. The 2 constants being 0x06 and > 0x08, the current code is equivalent to "reg = 0" > > It is likely that "reg |=" (or "reg &= ~") was expected here. Yes, those should have been "reg &= ~". I didn't find this in my testing because the register is all zeroes after reset. I'll submit a patch to fix that. Thanks, Tom > > Best regards, > CJ >