From: "Rakib Mullick" <rakib.mullick@gmail.com>
To: "Ingo Molnar" <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org,
"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: [PATCH] kernel/cpu.c: Section mismatch warning fix.
Date: Sun, 2 Nov 2008 07:59:47 +0600 [thread overview]
Message-ID: <b9df5fa10811011859s48e2f8dnb80d4a76001e8e67@mail.gmail.com> (raw)
In-Reply-To: <20081030182601.GE14102@elte.hu>
On 10/31/08, Ingo Molnar <mingo@elte.hu> wrote:
>
> * Rakib Mullick <rakib.mullick@gmail.com> wrote:
>
>
> you've tested that on x86, right? Have you checked/reviewed all the
> non-x86 architecture codepaths:
>
> ./arch/m32r/kernel/smpboot.c: notify_cpu_starting(cpu_id);
> ./arch/cris/arch-v32/kernel/smp.c: notify_cpu_starting(cpu);
> ./arch/s390/kernel/smp.c: notify_cpu_starting(smp_processor_id());
> ./arch/x86/mach-voyager/voyager_smp.c: notify_cpu_starting(cpuid);
> ./arch/x86/kernel/smpboot.c: notify_cpu_starting(cpuid);
> ./arch/mips/kernel/smp.c: notify_cpu_starting(cpu);
> ./arch/sparc64/kernel/smp.c: notify_cpu_starting(cpuid);
> ./arch/ia64/kernel/smpboot.c: notify_cpu_starting(cpuid);
> ./arch/um/kernel/smp.c: notify_cpu_starting(cpu);
> ./arch/sparc/kernel/sun4d_smp.c: notify_cpu_starting(cpuid);
> ./arch/sparc/kernel/sun4m_smp.c: notify_cpu_starting(cpuid);
> ./arch/powerpc/kernel/smp.c: notify_cpu_starting(cpu);
> ./arch/alpha/kernel/smp.c: notify_cpu_starting(cpuid);
> ./arch/sh/kernel/smp.c: notify_cpu_starting(smp_processor_id());
> ./arch/arm/kernel/smp.c: notify_cpu_starting(cpu);
>
> to make sure that they never use this function after free_initmem()?
Above codepaths are basically called during initialization, where all
the CPU's are initiated.
When we complete the initial bootup then free_initmem is called. So,
If i'm not wrong they're not using this function after
free_initmem().And notify_cpu_started(cpuid) is declared when
CPU_HOTPLUG is not set. So, It's safe also from CPU hotpluging POV. Am
I missing anything?
Rakib
>
> Ingo
>
next prev parent reply other threads:[~2008-11-02 1:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-30 4:04 Rakib Mullick
2008-10-30 18:26 ` Ingo Molnar
2008-11-02 1:59 ` Rakib Mullick [this message]
2008-11-03 10:15 ` Ingo Molnar
2008-11-03 23:34 ` Andrew Morton
2008-11-04 9:48 ` Ingo Molnar
2008-11-04 10:09 ` Sam Ravnborg
2008-11-04 10:22 ` Ingo Molnar
2008-11-04 11:02 ` Sam Ravnborg
2008-11-04 13:06 ` James Bottomley
2008-11-04 13:22 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9df5fa10811011859s48e2f8dnb80d4a76001e8e67@mail.gmail.com \
--to=rakib.mullick@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®