From: "Rakib Mullick" <rakib.mullick@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: "Ingo Molnar" <mingo@elte.hu>,
"Andrew Morton" <akpm@linux-foundation.org>,
tglx@linutronix.de, hpa@zytor.com
Subject: [PATCH 2/2] x86: Fixing improper annotation.
Date: Tue, 11 Nov 2008 10:15:38 +0600 [thread overview]
Message-ID: <b9df5fa10811102015r21017451w43755bf0d97a9db4@mail.gmail.com> (raw)
After using __cpuinit in function 'init_thread_xstate(void)', the
following warning was generated.
WARNING: arch/x86/kernel/built-in.o(.cpuinit.text+0x29c): Section
mismatch in reference from the function init_thread_xstate() to the
function .init.text:xsave_cntxt_init()
The function __cpuinit init_thread_xstate() references
a function __init xsave_cntxt_init().
If xsave_cntxt_init is only used by init_thread_xstate then
annotate xsave_cntxt_init with a matching annotation.
WARNING: arch/x86/kernel/built-in.o(.cpuinit.text+0x233d): Section
mismatch in reference from the function cpu_init() to the function
.init.text:xsave_init()
The function __cpuinit cpu_init() references
a function __init xsave_init().
If xsave_init is only used by cpu_init then
annotate xsave_init with a matching annotation.
Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>
--- linux-2.6-orig/arch/x86/kernel/xsave.c 2008-11-10 13:28:18.000000000 +0600
+++ linux-2.6/arch/x86/kernel/xsave.c 2008-11-11 00:31:42.000000000 +0600
@@ -301,7 +301,7 @@ void __cpuinit xsave_init(void)
/*
* setup the xstate image representing the init state
*/
-static void __init setup_xstate_init(void)
+static void __cpuinit setup_xstate_init(void)
{
init_xstate_buf = alloc_bootmem(xstate_size);
init_xstate_buf->i387.mxcsr = MXCSR_DEFAULT;
@@ -310,7 +310,7 @@ static void __init setup_xstate_init(voi
/*
* Enable and initialize the xsave feature.
*/
-void __init xsave_cntxt_init(void)
+void __cpuinit xsave_cntxt_init(void)
{
unsigned int eax, ebx, ecx, edx;
reply other threads:[~2008-11-11 4:15 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9df5fa10811102015r21017451w43755bf0d97a9db4@mail.gmail.com \
--to=rakib.mullick@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®