From: "Rakib Mullick" <rakib.mullick@gmail.com>
To: "Linux-kernel Mailing List" <linux-kernel@vger.kernel.org>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Ingo Molnar" <mingo@elte.hu>
Subject: [PATCH ] x86 : Fix compilation warning on paravirt-spinlocks.c
Date: Mon, 8 Dec 2008 20:56:38 +0600 [thread overview]
Message-ID: <b9df5fa10812080656l21385db3ob08fc4f9ad3f1f76@mail.gmail.com> (raw)
Impact: Fix compilation warning.
CC arch/x86/kernel/paravirt-spinlocks.o
arch/x86/kernel/paravirt-spinlocks.c: In function `default_spin_lock_flags':
arch/x86/kernel/paravirt-spinlocks.c:12: warning: passing arg 1 of
`__raw_spin_lock' from incompatible pointer type
This patch fixes the above warning. __raw_spin_lock(lock) is declared
when CONFIG_SMP is defined. Thus, a call to __raw_spin_lock requires
checking CONFIG_SMP is defined or not.
Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>
--- linux-2.6-orig/arch/x86/kernel/paravirt-spinlocks.c 2008-12-05
19:53:15.000000000 +0600
+++ linux-2.6/arch/x86/kernel/paravirt-spinlocks.c 2008-12-07
23:52:59.000000000 +0600
@@ -9,7 +9,9 @@
static void default_spin_lock_flags(struct raw_spinlock *lock,
unsigned long flags)
{
+#ifdef CONFIG_SMP
__raw_spin_lock(lock);
+#endif
}
struct pv_lock_ops pv_lock_ops = {
next reply other threads:[~2008-12-08 14:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-08 14:56 Rakib Mullick [this message]
2008-12-08 15:09 ` Ingo Molnar
2008-12-10 6:28 ` Rakib Mullick
2008-12-12 11:11 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9df5fa10812080656l21385db3ob08fc4f9ad3f1f76@mail.gmail.com \
--to=rakib.mullick@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®