mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rakib Mullick <rakib.mullick@gmail.com>
To: acpi4asus-user@lists.sourceforge.net,
	LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: corentincj@iksaif.net
Subject: [PATCH] eeepc_laptop: Properly annote eeepc_enable_camera().
Date: Fri, 2 Oct 2009 11:31:51 +0600	[thread overview]
Message-ID: <b9df5fa10910012231u38f49eeeoe1d0bcc9eafd53d6@mail.gmail.com> (raw)

 Currenlty the annotation for function eeepc_enable_camera() is
__init, and refers to a function eeepc_hotk_add() which is non-init.
Use __devinit for both functions which is
 more appropriate and fixes a section mismatch warning.

 We were warned by the following warning:

  LD      drivers/platform/x86/built-in.o
WARNING: drivers/platform/x86/built-in.o(.text+0x12e1): Section
mismatch in reference from the function eeepc_hotk_add() to the
function .init.text:eeepc_enable_camera()
The function eeepc_hotk_add() references
the function __init eeepc_enable_camera().
This is often because eeepc_hotk_add lacks a __init
annotation or the annotation of eeepc_enable_camera is wrong.

----
Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>

--- linus/drivers/platform/x86/eeepc-laptop.c	2009-09-28
12:05:21.000000000 +0600
+++ rakib/drivers/platform/x86/eeepc-laptop.c	2009-09-29
23:40:00.000000000 +0600
@@ -350,7 +350,7 @@ static const struct rfkill_ops eeepc_rfk
 	.set_block = eeepc_rfkill_set,
 };

-static void __init eeepc_enable_camera(void)
+static void __devinit eeepc_enable_camera(void)
 {
 	/*
 	 * If the following call to set_acpi() fails, it's because there's no
@@ -1189,7 +1189,7 @@ static int eeepc_input_init(struct devic
 	return 0;
 }

-static int eeepc_hotk_add(struct acpi_device *device)
+static int __devinit eeepc_hotk_add(struct acpi_device *device)
 {
 	struct device *dev;
 	int result;

             reply	other threads:[~2009-10-02  5:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-02  5:31 Rakib Mullick [this message]
2009-10-02 13:35 ` Corentin Chary
2009-10-03  6:23   ` Rakib Mullick

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b9df5fa10910012231u38f49eeeoe1d0bcc9eafd53d6@mail.gmail.com \
    --to=rakib.mullick@gmail.com \
    --cc=acpi4asus-user@lists.sourceforge.net \
    --cc=akpm@linux-foundation.org \
    --cc=corentincj@iksaif.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®