mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rakib Mullick <rakib.mullick@gmail.com>
To: Alex Chiang <achiang@hp.com>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
	linux-pci@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] pci: Make pci_dev struct point to NULL.
Date: Sat, 5 Dec 2009 11:18:05 +0600	[thread overview]
Message-ID: <b9df5fa10912042118p733416ffwe21b79b1f8246f2f@mail.gmail.com> (raw)
In-Reply-To: <20091205043635.GA10777@ldl.fc.hp.com>

On 12/5/09, Alex Chiang <achiang@hp.com> wrote:
> * Rakib Mullick <rakib.mullick@gmail.com>:
>  > On 12/5/09, Alex Chiang <achiang@hp.com> wrote:
>  > > * Rakib Mullick <rakib.mullick@gmail.com>:
>
>
> Right, so what's the problem? If the slot is not enabled, we goto
>  err_exit and return, never touching dev.
>
>
> I must be slow, because I don't understand how we might reference
>  trash.
>
Since *pdev might be uninitialized. But if we are sure that it is not
uninitialized
then it is okay.

And yes - althrough we weren't warned by the compiler.

Thanks,

>
>  Thanks,
>
> /ac
>
>

  parent reply	other threads:[~2009-12-05  5:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-04 16:35 Rakib Mullick
2009-12-04 20:27 ` Alex Chiang
2009-12-05  1:53   ` Rakib Mullick
2009-12-05  4:36     ` Alex Chiang
2009-12-05  4:37       ` Alex Chiang
2009-12-05  5:18       ` Rakib Mullick [this message]
2009-12-05  5:28         ` Alex Chiang
2009-12-05  5:47           ` Rakib Mullick

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b9df5fa10912042118p733416ffwe21b79b1f8246f2f@mail.gmail.com \
    --to=rakib.mullick@gmail.com \
    --cc=achiang@hp.com \
    --cc=akpm@linux-foundation.org \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®