From: Tuo Li <islituo@gmail.com>
To: stas.yakovlev@gmail.com, kvalo@codeaurora.org,
davem@davemloft.net, kuba@kernel.org
Cc: "baijiaju1990@gmail.com" <baijiaju1990@gmail.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [BUG] ipw2x00: possible null-pointer dereference in libipw_wx_set_encode()
Date: Tue, 10 Aug 2021 21:50:26 +0800 [thread overview]
Message-ID: <b9e3b7c9-59e4-7b3d-45d0-89ca006d45fc@gmail.com> (raw)
Hello,
Our static analysis tool finds a possible null-pointer dereference in
the ipw2x00 driver in Linux 5.14.0-rc3:
The variable (*crypt)->ops is checked in:
360: if (*crypt != NULL && (*crypt)->ops != NULL &&
strcmp((*crypt)->ops->name, "WEP") != 0)
This indicates that (*crypt)->ops can be NULL. If so, some possible
null-pointer dereferences will occur:
407: (*crypt)->ops->set_key(sec.keys[key], len, NULL, (*crypt)->priv);
417: len = (*crypt)->ops->get_key(sec.keys[key], WEP_KEY_LEN, ...)
I am not quite sure whether these possible null-pointer dereferences are
real and how to fix them if they are real.
Any feedback would be appreciated, thanks!
Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
Best wishes,
Tuo Li
reply other threads:[~2021-08-10 13:50 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9e3b7c9-59e4-7b3d-45d0-89ca006d45fc@gmail.com \
--to=islituo@gmail.com \
--cc=baijiaju1990@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stas.yakovlev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®