From: Tvrtko Ursulin <tursulin@ursulin.net>
To: "Jonghyuk Kim(MalHyuk)" <malhyuk97@gmail.com>,
Matthew Brost <matthew.brost@intel.com>,
Danilo Krummrich <dakr@kernel.org>,
Philipp Stanner <phasta@kernel.org>
Cc: "Christian König" <ckoenig.leichtzumerken@gmail.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] drm/sched/tests: add a UAF regression test for get_timeline_name()
Date: Wed, 2 Sep 2026 11:04:29 +0100 [thread overview]
Message-ID: <b9fb4967-0fbd-4abb-8244-1b80c46fb1e0@ursulin.net> (raw)
In-Reply-To: <83d1cde658ad4c34080398ea89fc17dc1e87d5ae.1787928528.git.malhyuk97@gmail.com>
On 28/08/2026 15:57, Jonghyuk Kim(MalHyuk) wrote:
> Add a KUnit test that reproduces the use-after-free fixed by the previous
> patch. It holds a reference on a job's finished drm_sched_fence (standing
> in for a userspace sync_file), frees the mock scheduler, then calls
> get_timeline_name(). Before the fix this triggers a KASAN
> slab-use-after-free read of the freed scheduler; after it the test passes.
>
> The test needs no hardware - it exercises the drm_sched core through the
> existing mock scheduler under KASAN.
>
> Signed-off-by: Jonghyuk Kim(MalHyuk) <malhyuk97@gmail.com>
> ---
> drivers/gpu/drm/scheduler/tests/tests_basic.c | 65 ++++++++++++++++++-
> 1 file changed, 64 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/scheduler/tests/tests_basic.c b/drivers/gpu/drm/scheduler/tests/tests_basic.c
> index a5a5a35a87b0..2c6744b58f04 100644
> --- a/drivers/gpu/drm/scheduler/tests/tests_basic.c
> +++ b/drivers/gpu/drm/scheduler/tests/tests_basic.c
> @@ -555,9 +555,72 @@ static struct kunit_suite drm_sched_credits = {
> .test_cases = drm_sched_credits_tests,
> };
>
> +/*
> + * Reproduce the drm_sched_fence get_timeline_name() lifetime bug.
> + *
> + * drm_sched_fence_get_timeline_name() dereferences fence->sched->name, and the
> + * drm_sched_fence ops keep .release set, so the fence is NOT ops-detached on
> + * signal (unlike stub fences). A driver that frees a per-context
> + * drm_gpu_scheduler while userspace still holds the exported ->finished fence
> + * (via sync_file / drm_syncobj) leaves fence->sched dangling; reading the
> + * timeline name then touches freed slab memory (arbitrary-read once the slab is
> + * re-sprayed). Confirmed instances: amdxdna, nouveau, msm. Same class as
> + * CVE-2025-38703 (xe) and CVE-2025-71302 (panthor). KASAN reports a
> + * slab-use-after-free READ in drm_sched_fence_get_timeline_name.
> + */
> +static void drm_sched_fence_get_timeline_name_uaf(struct kunit *test)
> +{
> + struct drm_mock_sched_entity *entity;
> + struct drm_mock_scheduler *sched;
> + struct drm_mock_sched_job *job;
> + struct dma_fence *finished;
> + const char *name;
> + bool done;
> +
> + sched = drm_mock_sched_new(test, MAX_SCHEDULE_TIMEOUT);
> + entity = drm_mock_sched_entity_new(test, DRM_SCHED_PRIORITY_NORMAL,
> + sched);
> + job = drm_mock_sched_job_new(test, entity);
> +
> + /* Arm + submit first; the s_fence is only created by drm_sched_job_arm(). */
> + drm_mock_sched_job_submit(job);
> +
> + /* Independent reference on the finished fence == userspace sync_file. */
> + finished = dma_fence_get(&job->base.s_fence->finished);
> +
> + /* Let the job get picked up (hw_fence created), then signal + finish. */
> + done = drm_mock_sched_job_wait_scheduled(job, HZ);
> + KUNIT_ASSERT_TRUE(test, done);
> + drm_mock_sched_advance(sched, 1);
> + done = drm_mock_sched_job_wait_finished(job, HZ);
> + KUNIT_ASSERT_TRUE(test, done);
> +
> + /* Free the per-context scheduler while the finished fence is held. */
> + drm_mock_sched_entity_free(entity);
> + drm_mock_sched_fini(sched);
> + kunit_kfree(test, sched);
> +
> + /* UAF read: fence->sched->name is read from the freed scheduler. */
> + name = finished->ops->get_timeline_name(finished);
It would be better to use the API (dma_fence_timeline_name()). It should
still reproduce, no?
Bigger question is does this belong in the scheduler unit tests.
Strictly no, there is no requirement scheduler fences have to be
exported to userspace. De facto yes, most (all?) DRM scheduler users do
it so I guess pragmatic thing would be to allow it.
Perhaps not in tests_basic.c but chuck it to a new tests_integration.c
and call it drm-sched-dma-fence-uaf or something?
Regards,
Tvrtko
> + kunit_info(test, "get_timeline_name() on stale fence returned %p\n", name);
> +
> + dma_fence_put(finished);
> +}
> +
> +static struct kunit_case drm_sched_fence_uaf_tests[] = {
> + KUNIT_CASE(drm_sched_fence_get_timeline_name_uaf),
> + {}
> +};
> +
> +static struct kunit_suite drm_sched_fence_uaf = {
> + .name = "drm_sched_fence_uaf_tests",
> + .test_cases = drm_sched_fence_uaf_tests,
> +};
> +
> kunit_test_suites(&drm_sched_basic,
> &drm_sched_timeout,
> &drm_sched_cancel,
> &drm_sched_priority,
> &drm_sched_modify_sched,
> - &drm_sched_credits);
> + &drm_sched_credits,
> + &drm_sched_fence_uaf);
prev parent reply other threads:[~2026-09-02 10:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 14:57 [PATCH v1 0/2] drm/sched: fix a use-after-free in get_timeline_name() Jonghyuk Kim(MalHyuk)
2026-08-28 14:57 ` [PATCH v1 1/2] drm/sched: cache the timeline name to fix a use-after-free Jonghyuk Kim(MalHyuk)
2026-09-02 9:46 ` Tvrtko Ursulin
[not found] ` <CADQRuqtjBu7wR4kKVDcS42KLKQTr+7SBtRn24mgZ+ApettMr1A@mail.gmail.com>
2026-09-02 10:07 ` Philipp Stanner
2026-09-02 10:20 ` Tvrtko Ursulin
2026-09-02 11:39 ` Philipp Stanner
2026-09-02 13:38 ` Christian König
2026-08-28 14:57 ` [PATCH v1 2/2] drm/sched/tests: add a UAF regression test for get_timeline_name() Jonghyuk Kim(MalHyuk)
2026-09-02 10:04 ` Tvrtko Ursulin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9fb4967-0fbd-4abb-8244-1b80c46fb1e0@ursulin.net \
--to=tursulin@ursulin.net \
--cc=ckoenig.leichtzumerken@gmail.com \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=malhyuk97@gmail.com \
--cc=matthew.brost@intel.com \
--cc=phasta@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®