From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BA392F747A for ; Wed, 13 Aug 2025 12:09:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755086997; cv=none; b=ansn1k1ooeDn8MdmUJgZYuVCR89c2x4jwGBZEaLxMDsXgywUHIG3dF8ba7zz1jDUdnT2LCt472IatrjPalf1CzkvjkSYyP38C6HvT5Ue5/kI8XPTRvRvkK7x1V1fjUYdqxI9iv2rs3At1YllXeEW2uu2JeoaH1Dlt67p0cWT+Fk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755086997; c=relaxed/simple; bh=m/WznaXUGhuabfIHeviZG1YVniNSCGD1sgKRQRpDdGA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YRUXEahGugmu0GXqDZcSKq+N5NdRcwca5CHHCyCb7mUE9xIraXg6BF/1ly2ZL6qTTOonz8EfCIbJnuvrwySJxH2RSW3C9O7I1ULK0RNNuI8XSqqMuqg1igljv4N6hnTWt9CQXbYXEfwuETY/zIqsfP1tX7eIcR50f7+fCf/otx8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gg9+ssvl; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gg9+ssvl" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57DBMHNu012161 for ; Wed, 13 Aug 2025 12:09:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= psYFNtuDqahC04xkfR7SJEBA99hgf4unI++fgcrpz3E=; b=gg9+ssvlTsvev9Pv 3F7pGrGmezzHVy3/n9PlAE33ji77Wrs2Wtk3sarmqZfJ4/uGJ1eb+frZaGeSxsRy dEBE/AYFkK7MqSh1Z/l+ijyw+8BgtURn4MFUQlbmrNvWFsSCOThpVzmouQet96tx 6ACNERA1YQQqa2d4HODR0o1DZIqYcDUrJBdQbERe4FQL4JYYzYKx6SU1WfSEanf3 GVTCCTfI26wXd9tqG6naRqHf2lIBXKPH7YB50j1W0GZxiOca642cACCWgjjlPHy4 GtJPxW5xFvZa8EieLOT6nmuq56q2kI6PaJZ2DUfSrbUMsZu/E/X5Po5Qs1oy6u4F 33Te5Q== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48g9q9tsb2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 13 Aug 2025 12:09:55 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4b07b805068so14924381cf.3 for ; Wed, 13 Aug 2025 05:09:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755086994; x=1755691794; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=psYFNtuDqahC04xkfR7SJEBA99hgf4unI++fgcrpz3E=; b=i1ufok3pfbMggyMLd3d5qwzWn+lgzBmoNJLxG/0ET6nnU0swSvWp//WkBXnJ8jl1Y9 62z0qeVVOBk/2gkMaNopPls/dhxC9NMMVp2SKLrOkc7BfqVfLOtGm8RO89uXVLRx043F W7QuRKRnJZKWU1eq1Tj43uY2Lqp2+td8maH3cg6QhNLh9iacA0CtuN6gRkPTHXtP1w9B BOnn+qIz8a7tXkHtvHO+AX5wJeq+RkxnWt4MCRXhZbknsePIy3Glwo27nriQGZb9Ovbl 13jrn0gzaIoIDyzqLZwJCHGOsKZTVQLCaNT+rAedYPGqsWyIY/nUpp6zap+eQwyRFVgn Eo0w== X-Forwarded-Encrypted: i=1; AJvYcCXeHJQgUVyxQAJEPEa3GquLrJ5umrI4oy24hMUgUwWIeCIqL5812+OjAMZcLyyOCbIgtrns9nQe2sMIdf0=@vger.kernel.org X-Gm-Message-State: AOJu0YwFPlieFbKaB7JGLoiahZPjDlj26bClm3WMO57uB0HD7moJQzVN tHmPUAP+p9dAULqmYH8rGAHmOpuzYJHoF6EspK5rhY4Ohl+PK2x3L4DqqxGFfGrdKK+AptIUC2d zHxonYrCMGtQ+eMXR1Q2CuXvgSeS4mlF3VDwGnXLuq11ZNrob9y3/3bhFvCv1ddaWSww= X-Gm-Gg: ASbGncvTe8HouZYZ9X4ugQWN4nqCPfc0m+Q1bgFMD0wPcqXftcvGDmtrUE8699DJexb X2tBO1d8V80CrChC1qXqh7NUZEnAvgcl4287WsV/7cUCIRSFXWEtDp+HFgj8QLBEoiy0CTf7+i5 mPaU27Z0o5DEHk0O/djQBA6pSusMYWuCGQ3ny91yG4Ya+FnPyZGjUr+3gFjsFOnmDbqUVmTwm1V ZEBlOldlZ5w0CTYpUvrlAxdQvkZHHK5fQNAfBK8c6F27u6xdIxHI9MpJug5KA5T+03sayjkFZUM io8k8JIEjef0Wk2ZDTGa4cspL0k0N46Q0uwEIzNZGyvUF8YWHNp1alekHf7LyHZlPrXT+VBzwaS wklH74FwWQ70iPKHu8Q== X-Received: by 2002:a05:622a:1103:b0:4ae:dc5b:5fee with SMTP id d75a77b69052e-4b0fc4ab333mr16608381cf.0.1755086993764; Wed, 13 Aug 2025 05:09:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGiI87elj9RoCIsminvTx3/fiw69IXoVr3fAfA90qa00UcNNobX3kI5ozBR7Y0OFrUSdqLEeg== X-Received: by 2002:a05:622a:1103:b0:4ae:dc5b:5fee with SMTP id d75a77b69052e-4b0fc4ab333mr16608041cf.0.1755086993180; Wed, 13 Aug 2025 05:09:53 -0700 (PDT) Received: from [192.168.43.16] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-af91a219ecfsm2374415866b.94.2025.08.13.05.09.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Aug 2025 05:09:52 -0700 (PDT) Message-ID: Date: Wed, 13 Aug 2025 14:09:51 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] arm64: dts: qcom: x1e80100-romulus: Describe PCIe power supplies To: Stephan Gerhold , Konrad Dybcio Cc: Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Marijn Suijten , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250812-topic-romulus_wifi_pci-v1-0-2adbed1b1f1d@oss.qualcomm.com> <20250812-topic-romulus_wifi_pci-v1-1-2adbed1b1f1d@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=CNMqXQrD c=1 sm=1 tr=0 ts=689c8093 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=3iqLFfv8AAAA:8 a=EUspDBNiAAAA:8 a=J5sCG4akjCC_sdNGsZ8A:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 a=DXGsuw0cLJ7uQz9nXHMC:22 X-Proofpoint-GUID: oeU17oA5JyWFpWgvjlOOlVbAisUNCb1z X-Proofpoint-ORIG-GUID: oeU17oA5JyWFpWgvjlOOlVbAisUNCb1z X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODEyMDE2NCBTYWx0ZWRfX2US2uaXQ4q6L GLnebR9pnZixZvDltP4+AhoUXKVz0gqP5QudUJpEQYsVZDhnGn/XQrt8qTYnUNkKd8brMR3OmEI UNqd/yWdgQqhX4jUtJQgYmd22o6Jbuct5SuI8NfdIzq2wWGGuuBfJJRBAYLdPKMOYQmb/x1M13O LzCW4k+Ytv85kvVLDCV8ZrDapyRxAHfxeaQGpoR9bo+/16QWALF5RZPEgC+WmVj/x2etd572WPX GYzhMo9i0oZTI7Rx2jdMjLzp/c8Lo3gCz0wq4jS580+U6gRbiDUJG3OvJ191D8Nv4d4vtrwVpvz /VQSAQdRy7z9ZCKByTWJIqL1uqAORbER9F5n5JtPCWbBhHYGPxN9KE8aPCk72tovffC5BwJL8sl w0swhnfm X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-13_01,2025-08-11_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 phishscore=0 bulkscore=0 clxscore=1015 malwarescore=0 impostorscore=0 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508120164 On 8/12/25 5:45 PM, Stephan Gerhold wrote: > On Tue, Aug 12, 2025 at 03:47:23PM +0200, Konrad Dybcio wrote: >> From: Konrad Dybcio >> >> Describe the power plumbing to allow fully suspending the slot and the >> connected SD controller. >> >> Signed-off-by: Konrad Dybcio > > Are you sure these supplies really exist on the board? E.g. on the > x1e001de-devkit, Windows toggles all these GPIOs, but there doesn't seem > to be anything connected to two of them, the 12V supply is simply always > on. Unfortunately, I have no schematics for this board.. I did reverse the polarity (and removed enable-active-high from the vreg node) to no effect.. so it may be that they're actually unnecessary, i.e. so is this patch > > Even more importantly, for a laptop I would expect they use some part > that doesn't need a beefy 12V supply. I don't have the datasheet for > RTS5261, but e.g. in [1] this chip is explicitly advertised with 3.3V > power. > > I guess it's hard to be sure without schematics and it surely doesn't > hurt to toggle these GPIOs like on Windows, but perhaps a comment that > some of these likely don't exist would be good ... > > [1]: https://www.sdcard.org/cms/wp-content/uploads/2023/06/SDA_computex2023_Realtek.pdf > >> --- [...] >> + sde7_main_reg_en: sde7-main-reg-en-state { >> + pins = "gpio6"; >> + function = "normal"; >> + }; >> + >> + sde7_aux_reg_en: sde7-aux-reg-en-state { >> + pins = "gpio8"; >> + function = "normal"; >> + }; >> }; > > I think you should either do a full configuration (include power-source > and everything else essential as well) or omit this entirely, because > like this you will need the proper configuration from the boot firmware > anyway. 'function' alone is really important on PMIC GPIOs, fwiw Konrad