From: Chanwoo Choi <cw00.choi@samsung.com>
To: "H. Nikolaus Schaller" <hns@goldelico.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org,
kernel@pyra-handheld.com, linux-omap@vger.kernel.org
Subject: Re: [PATCH] extcon: palmas: hide error messages if gpio returns -EPROBE_DEFER
Date: Mon, 17 Feb 2020 19:15:42 +0900 [thread overview]
Message-ID: <b9fe52e9-0340-4204-ee85-44b6c1ea7f3b@samsung.com> (raw)
In-Reply-To: <f65ad0ef2866e7d5b6743e13579c1efe8c572b4f.1581929741.git.hns@goldelico.com>
Hi,
On 2/17/20 5:55 PM, H. Nikolaus Schaller wrote:
> If the gpios are probed after this driver (e.g. if they
> come from an i2c expander) there is no need to print an
> error message.
>
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> ---
> drivers/extcon/extcon-palmas.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
> index edc5016f46f1..9c6254c0531c 100644
> --- a/drivers/extcon/extcon-palmas.c
> +++ b/drivers/extcon/extcon-palmas.c
> @@ -206,14 +206,16 @@ static int palmas_usb_probe(struct platform_device *pdev)
> palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id",
> GPIOD_IN);
> if (IS_ERR(palmas_usb->id_gpiod)) {
> - dev_err(&pdev->dev, "failed to get id gpio\n");
> + if (PTR_ERR(palmas_usb->id_gpiod) != -EPROBE_DEFER)
> + dev_err(&pdev->dev, "failed to get id gpio\n");
> return PTR_ERR(palmas_usb->id_gpiod);
> }
>
> palmas_usb->vbus_gpiod = devm_gpiod_get_optional(&pdev->dev, "vbus",
> GPIOD_IN);
> if (IS_ERR(palmas_usb->vbus_gpiod)) {
> - dev_err(&pdev->dev, "failed to get vbus gpio\n");
> + if (PTR_ERR(palmas_usb->vbus_gpiod) != -EPROBE_DEFER)
> + dev_err(&pdev->dev, "failed to get vbus gpio\n");
> return PTR_ERR(palmas_usb->vbus_gpiod);
> }
>
>
Usually, gpio driver like pinctrl is very early probed
because almost device drivers should use gpio.
So, I have not any experience about this situation.
Do you meet this situation on any h/w board?
--
Best Regards,
Chanwoo Choi
Samsung Electronics
next prev parent reply other threads:[~2020-02-17 10:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200217085551epcas1p49113220d034155f8a78dc5e0767637a5@epcas1p4.samsung.com>
2020-02-17 8:55 ` H. Nikolaus Schaller
2020-02-17 10:15 ` Chanwoo Choi [this message]
2020-02-17 11:07 ` H. Nikolaus Schaller
2020-02-17 11:24 ` Chanwoo Choi
2020-02-17 12:21 ` H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9fe52e9-0340-4204-ee85-44b6c1ea7f3b@samsung.com \
--to=cw00.choi@samsung.com \
--cc=hns@goldelico.com \
--cc=kernel@pyra-handheld.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®