From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFF3F3D0C0B for ; Mon, 25 May 2026 09:24:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779701087; cv=none; b=TpBIFTehoOhcQv3g8tH0FGHMuwBg+uBOWyDhG4lfxBJbEFqFtynXcmFgzawq6sv5100dY4D6WdUlIqq1Cv8CmXgy9R5x5kwm0uZFiKb92T+GwHZzMOOPIHpowV7nRsazwF0UHWD9uyi5t73gQiuW0jsAn63hgvLc5RROpUrgk88= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779701087; c=relaxed/simple; bh=Usv9zpYi4do2lifC/zfE8nnMvp61yptX2XkYnVZEyU4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=stlage9Z5Izs9DmW8WnFljikg1kClaYVBYreZhxmNep0hNiNkweccbyg1HsIfpzvfZGMT1+wrYRgrzDsa4ukscpnprhEeRTGrcrF1ajCK+pcLujOiG1zP96211u99wiC8vywEliV9zRl5FBWEYSqGK2xI+DDtn/w9cwGU4AerV0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=GVaBy0+a; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="GVaBy0+a" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-44985f4ab0fso5176427f8f.0 for ; Mon, 25 May 2026 02:24:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1779701084; x=1780305884; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dXIop8scfYA59+iIi8F9PKH/sL+IWlJPcxqiOfC7myM=; b=GVaBy0+al/3PPx4qotsRTWKFITYfcIsLX9GnH91MlkDd+F5uUyBXskAyv9Z+pCrPbp WsDIheZgEkK4oIMUK+xU7hqwaFWEHTVZJxlo8H8wmZUBeKl/o6HlBWVJNBgSM3W++joU NG+qE3LCcnk5lpC7jDWvC0IQDSwFd/DadFbl16wYuLEOodshw/HKzOkOvW5lEeocAFUg y7Sb3MT64pW6sAdB3RrntmfgvGfIk1XdXsKfLTaENamM9bhWXZqdnTi/+4JisqaoWayR UpKJz3Ldt2uzmzN/WA0ALeDIbB4w76qzkmYffZnHX6wiWMbVjCZT66HWlhjBoZ166Nju qlfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779701084; x=1780305884; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dXIop8scfYA59+iIi8F9PKH/sL+IWlJPcxqiOfC7myM=; b=NcahO45WMfmPJFoQMKvJSc2w+s28/FNO5vex9GyNpD/lKaofhzHnjceaG4NvA/4ti2 YyFXP0Pvxce491I3RMo+tI/CswLPO0GMV4lvvmVNJF5gssyIw/+f4d90oXMmwy2lQG01 zaHBuNdQadBAATzaFYOttf22QXKEfQcf8e7s2h8GD3ZUUZsPRoMncHfD7JyMm6GkKqfO fSIPh0a4HkIuq9g4RhEyNPg/wKmGQy4l+VHBJx6VVkim/6kSVjufRdkQn14XMVH4I+kw 4uHoKQxKOJ6fOma3azOX8kAdI4MWzogvnw5R4vTZfpEIL95VLuyUCgTxniE47VXc3jc6 V6sw== X-Forwarded-Encrypted: i=1; AFNElJ9Tc7wD/3B8CUu/q7DJqiGhm9vxg39pFSfpSBz/rCoAPiXALEYjAGKOUkTE1QJVJbxHXAEr1Bx3cNhoLh0=@vger.kernel.org X-Gm-Message-State: AOJu0YwJP7Wu38W5GIDfL41ajwZQB+sbQG/g8Cz4dOlq3n9jJ3XAOZKN r4VZgGQpnN4XtcxJUT2hV6GcpXBxmJMJ+fJmQ8RZCfbOCGGMdS8YC5B4qWXOzxKV7KE= X-Gm-Gg: Acq92OGEVK9rfobQQlIQvbMfWGjR1fQmMQZPWIPdlq/okqjZ8HtwT11IDyVQzTugqlH 2JWVSQ9pz5efuc19y/Q0J3y7ZXQWOPJZD9Lly5RZdPY4ADiKG/rh5vLNMcNFNPBCUU12WCaSPox HbJ9xqmdYNEuIRHsE9GnhaVM3l+6hKZIRv01dICh3xhKSmZyWf1FrnELy/1RHqZchfLwe6hf+1w dwTKuBFtOAyIwY8SFu4BB1MTBzR3sOlrwr3nC7UubIHyU5e2pk+dI61FbJKfKHvg/EmpEp1HotB bIJHDQD/YH2kTKo62dqQdxCQZ0raGfzboSyR4GBrsV7+Y1MxDNzgubO2+/XXdDbScxYC+/rBTxp URmw+Jb8jmgvFsWd3h/ZVa5V6DnoWPnnuabmyBcj8tQKBa/UebqTxXn4WF8mRDgfgqx3Uu3Pp1i 6PG0IJB+f3qR4eEGDzd8Y/wThxUjri5BI1Dk9jJmGIJdMZUAsFrEle/5FOETIoRyF5F7sJzZQoc wbp5fO8O15xFQyQKbadYm6nsKaquruI5r+y5sKxHB2zzLyqyx+aUaVvnBzGkrcFhTDMdg== X-Received: by 2002:a05:6000:4b04:b0:45e:9420:ed16 with SMTP id ffacd0b85a97d-45eb38b0045mr22939460f8f.10.1779701084065; Mon, 25 May 2026 02:24:44 -0700 (PDT) Received: from ?IPV6:2a00:1028:838d:271e:8e3b:4aff:fe4c:a100? (dynamic-2a00-1028-838d-271e-8e3b-4aff-fe4c-a100.ipv6.o2.cz. [2a00:1028:838d:271e:8e3b:4aff:fe4c:a100]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45eb6c9f598sm26426853f8f.6.2026.05.25.02.24.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 May 2026 02:24:43 -0700 (PDT) Message-ID: Date: Mon, 25 May 2026 11:24:42 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 19/24] dyndbg,module: make proper substructs in _ddebug_info To: Jim Cromie Cc: Jonathan Corbet , Shuah Khan , Arnd Bergmann , Jason Baron , Luis Chamberlain , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Andrew Morton , Shuah Khan , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-modules@vger.kernel.org, linux-kselftest@vger.kernel.org, Louis Chauvet References: <20260523-dd-maint-2-v2-0-b937312aa083@gmail.com> <20260523-dd-maint-2-v2-19-b937312aa083@gmail.com> Content-Language: en-US From: Petr Pavlu In-Reply-To: <20260523-dd-maint-2-v2-19-b937312aa083@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/23/26 9:14 AM, Jim Cromie wrote: > recompose struct _ddebug_info, inserting proper sub-structs. > > The struct _ddebug_info has 2 pairs of _vec, num_##_vec fields, for > descs and classes respectively. for_subvec() makes walking these > vectors less cumbersome, now lets move those field pairs into their > own "vec" structs: _ddebug_descs & _ddebug_class_maps, and re-compose > struct _ddebug_info to contain them cleanly. This also lets us get > rid of for_subvec()'s num_##_vec paste-up. > > Also recompose struct ddebug_table to contain a _ddebug_info. This > reinforces its use as a cursor into relevant data for a builtin > module, and access to the full _ddebug state for modules. > > NOTES: > > Fixup names: Normalize all struct names to "struct _ddebug_*" > eliminating the minor/stupid variations created in classmaps-v1. > > Invariant: These vectors ref a contiguous subrange of __section memory > in builtin/DATA or in loadable modules via mod->dyndbg_info; with > guaranteed life-time for us. > > struct module contains a _ddebug_info field and module/main.c sets it > up, so that gets adjusted rather obviously. > > Signed-off-by: Jim Cromie > Reviewed-by: Louis Chauvet > --- > [...] > diff --git a/kernel/module/main.c b/kernel/module/main.c > index 46dd8d25a605..c2b6e70f2e77 100644 > --- a/kernel/module/main.c > +++ b/kernel/module/main.c > @@ -2774,12 +2774,12 @@ static int find_module_sections(struct module *mod, struct load_info *info) > pr_warn("%s: Ignoring obsolete parameters\n", mod->name); > > #ifdef CONFIG_DYNAMIC_DEBUG_CORE > - mod->dyndbg_info.descs = section_objs(info, "__dyndbg", > - sizeof(*mod->dyndbg_info.descs), > - &mod->dyndbg_info.num_descs); > - mod->dyndbg_info.classes = section_objs(info, "__dyndbg_classes", > - sizeof(*mod->dyndbg_info.classes), > - &mod->dyndbg_info.num_classes); > + mod->dyndbg_info.descs.start = section_objs(info, "__dyndbg_descriptors", > + sizeof(*mod->dyndbg_info.descs.start), > + &mod->dyndbg_info.descs.len); > + mod->dyndbg_info.maps.start = section_objs(info, "__dyndbg_class_maps", > + sizeof(*mod->dyndbg_info.maps.start), > + &mod->dyndbg_info.maps.len); > #endif > > return 0; The update changes the names of dyndbg sections that the module loader looks up. However, the actual rename is not done until patch 24. It would be good to clean this up to avoid potential bisection issues. -- Thanks, Petr