From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D59732877C3 for ; Wed, 22 Oct 2025 04:34:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761107659; cv=none; b=htX46lxcsNgaMzm7seLqOxtYj3MakeXLbVdNmPUnWQUbESmHNSyhv/2My0pJC2oN6JXifuE25/p766Kkn0BEOv+nimVpeKW8ErMw5rymW/5qsxIbZb4OvkJGl8wPQFHRPcoRsaMcl7aR+I1pODAaKjveplK/G5g1S6oFa8Z+Prc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761107659; c=relaxed/simple; bh=Ta3vLBQn3sKyycsd6zk6kL1yNYlGExTdBO+VCjlMbt0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Pjy18q6uTWNEeUpg5Xh9MkNlNRSuEmjMopHMtwAZTZ7Dmi/+Hm9VkSP5IMJn65r1KXNnuwxAaEyw7VakafczyjIMCcW84N5+Z6EAaXOudOorIZGJM58NM8Xqw81JY7N6iwQKsYs4wsS/k6DQk1fqpOqP6wjV03avtAJpw9fYgLU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b=eICJQYbe; arc=none smtp.client-ip=209.85.215.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b="eICJQYbe" Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-b4755f37c3eso5318306a12.3 for ; Tue, 21 Oct 2025 21:34:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20230601.gappssmtp.com; s=20230601; t=1761107657; x=1761712457; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ppwCPMx8V2Sf6deae1nCYy7pnPOnc4IDjA11Y0/2goo=; b=eICJQYbejhi+Edhn0HQlKs6ymsdpqS4weM5zk3/8ogTuaIZtgsTy4XqdM9ErgYlS7L XdWfRF9iHSXnc4eOREt1nh9EA7rX/Bh45ap1T6JAtAUSjkGoNB1GT6GniFsZ+OYfrJbC ZRfl9yq+D+fvJj6zkasVTRxPAHKMjTIYqhjh+Ur4K98WtV8PqEkIJRDS1w3cFOOxlRTS QVBLfAQAMUut1bR/6LF1N4ETkuCZIqyMR9+8c8652kYMbi8BXqdjzClgNqlkcJ57Wpbn fNeNRTLLlK/jGB8r09QDZK+9kAchioCe0FoAnWc+x50/TGfe7cH/fdZ1xz2A/CS4dFjL /PMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761107657; x=1761712457; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ppwCPMx8V2Sf6deae1nCYy7pnPOnc4IDjA11Y0/2goo=; b=BBKdm2qRE7gnm9Tz+l9wH+LDvrxgk78j1XmP+QRJEitexpt2NGM2JW3z2OJ85yEHyJ l+GWewObxMzKtOtaisdUmNLjUT6ek+pyLJhCpaY3Xpbs6JosagdQM6mIzxkbyAoH1b24 ARYbld1f5O2cZZTCHWHT9GnwB1RWh7UPORrVzBdozRE17hHOiDgo15l4OG+t/ffpyc4p kRlpL9ku1yNQyScNhfF9C1XqG/HxwpjH9DSSMcmrCF6tdf5LkP6m9sSd8wQQF6odBHGy KraSD7911lN5ahBi4i4ATkIUMFwhzFB0t3V+tg6bveiIm4RFL9iFavjHfqdYK10txEcS t8vw== X-Forwarded-Encrypted: i=1; AJvYcCWadIP6tCeKkzA0R1CNEt4k9oTjiBRSPd5Xn23jdu4vUu4nfFUpyy946N94Wg6mTdmLc/tPuBfFxEireDg=@vger.kernel.org X-Gm-Message-State: AOJu0YyAQiwm1jnCWCR1Wjxx9yYJhv8KVAwmtpSB2WpgF9I68xgnwQCb mYItHIZjEuOyPLWAA/T/B3i51GgBA/bOjgNKd7wmocN5CHrkMBNT2x+b2crB9Fq3+IQ= X-Gm-Gg: ASbGncvLAaZO9wAvWnycs+HBmIetmu+J+3cvuCZ1OtHoq/8NmlJ0eDgRGSFkzqtqK0r 1WWIdnUVqA3f/nHxe8r8dYIMmgQGqV/D7eQY0fy+gdeA1ZsVOf2MMqfQcKO1eoI0WjjhN/IRqBf 5U2wPwMin5IzJXwDo8BGmT9K0+AZJa0XryYiWSNiK7FXeyZyqd1REJXfCu8EquKL/WkHd/MaZb5 LhxQICqhDBbBl8IixsNYGzMDQiY41nZnz6aravCZZyjmVoSC2pV4oL75GJQD/EkxeMO5JK3+xo2 7vaxQKUrCc9DhWkmkba+RiV5fem11kq+8d2CFY/YTeKvZnxPFDAql+sF4QQgYTnXihDZCKu+rOv p2HQKEcNo2RPqlnVZ65BW3k4dv3XM1TmVsh87bC6K9iyJ7IPUdKrM5YIKiGzBer5SLVLvjLFnhs WgerLhjflG1cOK X-Google-Smtp-Source: AGHT+IGRbL8alcY98vwlpMmB68/E/fiZ8vvTYnBqywFldOw2mBZIi0C45CU+Ljv9QC55tUOEBjim+g== X-Received: by 2002:a17:903:1d1:b0:290:2a14:2ed5 with SMTP id d9443c01a7336-290c9c89fd2mr213302675ad.4.1761107657244; Tue, 21 Oct 2025 21:34:17 -0700 (PDT) Received: from [10.211.55.5] ([4.28.11.157]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-292471fe4cdsm126257025ad.97.2025.10.21.21.34.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Oct 2025 21:34:16 -0700 (PDT) Message-ID: Date: Tue, 21 Oct 2025 23:34:15 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/8] dt-bindings: spi: fsl-qspi: support SpacemiT K1 To: Conor Dooley , Mark Brown Cc: han.xu@nxp.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, dlan@gentoo.org, guodong@riscstar.com, devicetree@vger.kernel.org, linux-spi@vger.kernel.org, imx@lists.linux.dev, spacemit@lists.linux.dev, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org References: <20251020165152.666221-1-elder@riscstar.com> <20251020165152.666221-3-elder@riscstar.com> <20251020-blinked-primary-2b69cf37e9fe@spud> <710c36f2-3551-4738-a965-f1564416348c@sirena.org.uk> <20251020-florist-campus-a397bf94d129@spud> Content-Language: en-US From: Alex Elder In-Reply-To: <20251020-florist-campus-a397bf94d129@spud> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/20/25 1:39 PM, Conor Dooley wrote: > On Mon, Oct 20, 2025 at 07:26:17PM +0100, Mark Brown wrote: >> On Mon, Oct 20, 2025 at 01:06:46PM -0500, Alex Elder wrote: >>> On 10/20/25 12:39 PM, Conor Dooley wrote: >> >>>>> + - spacemit,k1-qspi >> >>>> Are the newly added resets mandatory for the spacemit platform? >> >>> This is interesting. I never even tried it without specifying them. >> >>> I just tried it, and at least on my system QSPI functioned without >>> defining these resets. I will ask SpacemiT about this. If they are >>> not needed I will omit the first patch (which added optional resets), >>> and won't use them. >> >> It might be safer to describe them, otherwise things are vulnerable to >> issues like the bootloader not leaving things in a predictable state. > > Yeah, if a linux driver requires that a bootloader set up a clock or > de-assert a reset etc, then the binding should mark them required since, > as you say, a bootloader change might do away with that de-assertion. > Additionally, the stage doing that de-assertion etc could be U-Boot > or barebox, which import devicetrees from Linux, so making sure that > the resets are present has that benefit too. OK, so the resets property (added in patch 1) will stay. It will be defined such that it is an optional property, and only when the compatible string includes "spacemit,k1-qspi". -Alex