From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2209637D128 for ; Mon, 25 May 2026 11:11:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779707462; cv=none; b=judJ6lovMkSVdQhyFVPvWAOKM2g2S50oKZRVrLHz91kY81ppGNYkHno+Gh96ZhBTTz5QCTU7vsFN+FNMDqif7K671D4G0kLf7VbwmHzPX57oGrg6lHd8C9B3zm0rujm/uNcWkBebBbluptjqBk0hmQR0JDV1w9LBSIBYXCYuk8Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779707462; c=relaxed/simple; bh=C7CxNZZJ37Fk2MC48BM2ref9I5ULxaqdo5KY9rRbaN0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DKrDYokCaozLqsrqq2+vuYELWlNJpGBVHKDg5GK8U7uwxzaL58vn4ihIVG++AMqJ+slVpFaVVxbjXjNUsSU5TN7aYi7qjtTgfxwk1uA4Lql7s3j6D6yH0R/hjDq0ANhW722YmIyEfr7DuwuYWLQsY9WPF3yyhqUhBjX1So42rh4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=F+iK/DyH; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Xb5WP7tI; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="F+iK/DyH"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Xb5WP7tI" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64P7rvCg2223196 for ; Mon, 25 May 2026 11:11:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Rpim49/9WdkusfcuWPLHC9wP0WlUFMokl1OdzIGRcNE=; b=F+iK/DyHgs9tF3/R xIgvMdE+uOa8maNLI2O5rZqGacAq1SQKCEkuofJGLatYr79Cl42YxJDQT3yFhmaG W1hxabQzGBzPNP+HXTz72nn9zmcgHFmv4u09VE6ZxJLeMYljt6yMoMn6wsk6OsH+ eZDzz8GLZkBE5Xt4JWRzrjfFdkGiQOt7Mq6C3c/UJ6tPEwBDCtysSATEcVJwiwdR fPU2wR/nfQSqSL33qi5J6EGVctxmuOIV5YNiblDEhAU74LEhUOUwrPid6qoRQNwf GqrTtZ2VhWlnJEQ68OSsYeQAS2Z5t6q3m12B5khvrMoB7hMJltkkFxJLL8BzhAlS eSDuHw== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eb4m7pccj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 25 May 2026 11:11:00 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-c82751074c8so14185203a12.0 for ; Mon, 25 May 2026 04:10:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779707459; x=1780312259; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Rpim49/9WdkusfcuWPLHC9wP0WlUFMokl1OdzIGRcNE=; b=Xb5WP7tICeuc54+PYHRAEq70NIYEkFOY8x1ANfsonw+v0EqAGxYRz0EghCEIYO26UD ijcMWUp49pU2qC1mcuNsjqgeWrkzdhwJOg1cfwlUB/Is3BHkCVM9kHXrKvQPrI0asXTT U3SCCfp17mHEt7d94+bZrVsFvf//PW/T07KPUdZDWnTcsSpo0ey2K8NzRFKi0DyDNUsl U07y00FsxcFv/yau6fXK+8KzmMNPe47WhhulCHRs/I5RsCZDO9c5c7vwFRfLbo5o7TFG +GMz1Nalsn/ExCcudVkoo8d7hCNTXHqKOyliP6YywHF8PAJPviYHv2MkUYr+AEObsxnU TQiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779707459; x=1780312259; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Rpim49/9WdkusfcuWPLHC9wP0WlUFMokl1OdzIGRcNE=; b=So+Dp7T76/p74eahWl7K6/41YQ/HDELi2B9biFGC2j/JQIimQnpz70HnWILYGi6lZx cg9E0a4mD3hR6HIaF/hORB6uDq8/w6ql/vGeTifh4KHuSQ1xZlrUCqSIzXnx2ajKmkrT FUwEK+lnTE7KDOBfNnGhCemloxdJnLVtoPyV0gMX0KEBihNjAWXcw02bL3BqUEW7fM/6 XVhzkgeJcwbs4MCmwR8yPBBaZA+pI77uaGH6ptC7I0n4x/O7vEBSmArOt4mkDEhYWn0C eCQFMJjM5Si2cMOWxwcMRCA5KwKTSmwr8ivIfevOQFKcC5vcwsU9c75GCrG6Agry1htT BkvA== X-Forwarded-Encrypted: i=1; AFNElJ8I/LHNfajepO+5ya38wK5rHyq6LyrU5nboTMCqCaCcYY4E/WdKsxgTsymhZmFl6yMjEkDfTFOBSXMsh84=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0DVxpiAr+7AQVULDXUInxy4MKaI+m4bvBIe+BN1JNarqtomac rpu2nVq0VtFxvru/vkCxzK/PL4leMp14LyKlqclafIaQkv9uMvomYMk66YZOIdtbYkXTGZ9H5eT t/lgJ+kFpe+tsD0m1oYfLj88J55khTv8CPDddFowr5R07MsUoz1VYyv6MRBu7K/2Nbgo= X-Gm-Gg: Acq92OHtSOut3E4+WQ7nQYyaNK0Jm5np1Q+qM41ca6U5YdI/yHVp5K+tCx0D9KZ2Zyw 7P4nf2q8RNbuPdb7FW8SD6lWpkF7wCxYdriVcMl6ufeNHSfkO6f8/X5D3ghf0X5uII9oK9a6IPR G6q97Egrxovqcc93W+5ycQbkvkKqS/JW2F17qL4Q9SFXpgjLPlgJvsVbPWp0zh0eWuQWFDR8ZdH WDmTFquT7f1qXY7wBXllGzb0jJf4X4gjwtxr9MizwVft27bPeagOwu64PPpoZ9cwYQ/kKCqMY8/ lbG/Jl5q6IoRQYAdfEFIsNIr5ublnO5pdxEHVlMBjfSohQX4G4+1Z3psqf4zvb/ob8PPS5UVPZo OdpjhxrbciIKvGptoG5KX8SpOKTzkwjK6TrLZ2dEpvtWuo0cyJVQ= X-Received: by 2002:a05:6a00:4c98:b0:83e:2c38:f5d5 with SMTP id d2e1a72fcca58-8415f32e0edmr13028184b3a.28.1779707459073; Mon, 25 May 2026 04:10:59 -0700 (PDT) X-Received: by 2002:a05:6a00:4c98:b0:83e:2c38:f5d5 with SMTP id d2e1a72fcca58-8415f32e0edmr13028147b3a.28.1779707458574; Mon, 25 May 2026 04:10:58 -0700 (PDT) Received: from [10.218.19.63] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84164e9e7a5sm11795662b3a.33.2026.05.25.04.10.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 May 2026 04:10:57 -0700 (PDT) Message-ID: Date: Mon, 25 May 2026 16:40:51 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] crypto: Delete Qualcomm crypto engine driver To: Dmitry Baryshkov Cc: Eric Biggers , Krzysztof Kozlowski , Demi Marie Obenour , Herbert Xu , "David S. Miller" , Thara Gopinath , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Russell King , linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-arm-msm@vger.kernel.org, Ard Biesheuvel , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20260523-delete-qce-v1-0-86105cd7f406@gmail.com> <20260523-delete-qce-v1-1-86105cd7f406@gmail.com> <7rgfuvv3hai7g4wt4accbkejtzdt5dnb6mkj6x7ox5sz35q4n2@h7j6rr7extuj> <66317f6a-645e-432b-ae11-8f40569d4117@gmail.com> <20260524204537.GB110177@quark> Content-Language: en-US From: Kuldeep Singh In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 7qrqX9PaUcFtIXM0LxksVb98HD-m6i0x X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTI1MDExMyBTYWx0ZWRfXye9wWtbvgpVO 6LvHHP4bHjaEaeipEn1Kcu+oLLKannbPSliAfEifSs8wl1/V8smAaU4moR4cAz7xjdZAF08Yf22 vRzcNRquGTbMFny78yYO0DP6OJNOV5mlennFzLXwIcP2SoQ9KOAQ1SM5Nhun3G3a73GDKRF4LhE zLw+thxflEgefK2NUxfllQdWBcUMGITvZq7HhKnpHDasqJRs2dsIrkPvYhdsWR7VOzwRs7oiXEr v9U19k0pIICcrj4wWFE6eM/J+TYSPosCEWEGM9W4opEpcWSzek2+owX8/+fMJfsE+XtLGvHNHWv dB9y9SOZYCjF839g8CrZGJZcNTLFvZnsYbugEqZGyqXTG83xb4qdem/IzwCxCuat2w8i7AxtEyI fA3OzozH69hWHH/PUsYYxpugFmup/r0w7BcVU+Gvtl3dC7M09P64iAnlnLXD2Sf5gPxWm01ZfKs C8+5O9tzAKZutlrzDOg== X-Authority-Analysis: v=2.4 cv=MrJiLWae c=1 sm=1 tr=0 ts=6a142e44 cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=qIDEVUpatm5GnGNPECcA:9 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-ORIG-GUID: 7qrqX9PaUcFtIXM0LxksVb98HD-m6i0x X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-25_03,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 phishscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 malwarescore=0 spamscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605250113 On 25-05-2026 13:41, Dmitry Baryshkov wrote: > On Mon, May 25, 2026 at 11:59:33AM +0530, Kuldeep Singh wrote: >>> This driver is more than an order of magnitude slower than the CPU for >>> both encryption and hashing. See: >>> >>> https://lore.kernel.org/r/20250704070322.20692-1-ebiggers@kernel.org/ >>> https://lore.kernel.org/r/20250615031807.GA81869@sol/ >>> >>> There are many examples of it having bugs as well, for example see the >>> second link above. >>> >>> That's why it had to be disabled via the cra_priority system. This >>> driver was actively making Linux worse. >>> >>> This isn't particularly unique to drivers/crypto/, of course. This one >>> we just have data on, so it's a bit clearer. >>> >>> I've yet to see any real reason to keep this driver. >> >> https://lore.kernel.org/all/c1697372-54ec-4f57-85d9-ad375ff1a44d@oss.qualcomm.com/ >> Kindly check my latest reply to the thread. There are numerous usecases >> like DRM(Digital rights management) coming up and qce driver is required >> for secure content. >> >>> Crypto drivers need to be held to a higher standard than other device >>> drivers, as well. The onus is on those who want to keep a particular >>> crypto driver to prove that it's worth keeping. >> Sure, I'll be working on stabilizing self_tests infra for qce. >> Kindly allow sometime to go over failures in crypto selftest and will >> submit fix if applicable. > > Why are not selftests a part of your default config? How are you testing > the driver? We are validating the driver probe and kcapi userspace tests while validating qce algos. Locally we update all 3 algo priority and then run kcapi_convinience.sh test suite to ensure it picks qce algos. Please note, previously were not aware need to run selftests suite too. Got to know about this once issue was reported. > >> So far, i am observing 2 ciphers failing(xts-aes-qce and ctr-aes-qce ) >> with CONFIG_CRYPTO_SELFTESTS enabled. > > Please make sure to run the tests on older platforms too, not just the > latest & greatest. Yes, will check on all the platforms. -- Regards Kuldeep