From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80428C433B4 for ; Tue, 11 May 2021 16:41:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4B60E613BE for ; Tue, 11 May 2021 16:41:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231589AbhEKQmG (ORCPT ); Tue, 11 May 2021 12:42:06 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:52664 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230435AbhEKQmF (ORCPT ); Tue, 11 May 2021 12:42:05 -0400 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 14BGeppc006708; Tue, 11 May 2021 11:40:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1620751251; bh=o0HigsdKBe5csPaBHc4l860DJcWkFyEglcaRFartKRc=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=oL2vUGClingUoyiqXnrYDLRmre7RZUPnK1FEB6DY7zeqj3/zyUV3rJn3sRrnyY/tQ BxXPy1C4EoVF0bYEHxkjkb7VCYw24J7P7X5TOpgRhfIsTwlGLHG1b8mAVi9JysA6ZV 2yjzDfzVPMbWWdikMTB96sRSU859iN1CivMSjK3Q= Received: from DFLE100.ent.ti.com (dfle100.ent.ti.com [10.64.6.21]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 14BGepT2036484 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 11 May 2021 11:40:51 -0500 Received: from DFLE108.ent.ti.com (10.64.6.29) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Tue, 11 May 2021 11:40:51 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE108.ent.ti.com (10.64.6.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Tue, 11 May 2021 11:40:51 -0500 Received: from [10.250.235.117] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 14BGehbM007316; Tue, 11 May 2021 11:40:45 -0500 Subject: Re: [PATCH v2] arm64: dts: ti: k3-am65: Add support for UHS-I modes in MMCSD1 subsystem To: Nishanth Menon , Jan Kiszka CC: Vignesh Raghavendra , Lokesh Vutla , Kishon Vijay Abraham I , Tero Kristo , Rob Herring , , , References: <20210511095339.16268-1-a-govindraju@ti.com> <200b5648-b2d9-b4c9-f81a-b39c3baf81f9@siemens.com> <7561137c-adf1-bf03-c442-ff8174b2f143@ti.com> <95539fea-8190-7a3d-05aa-90824eb03293@siemens.com> <20210511163357.2kp2jpg4uyk5nb5u@sizing> From: Aswath Govindraju Message-ID: Date: Tue, 11 May 2021 22:10:42 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210511163357.2kp2jpg4uyk5nb5u@sizing> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Nishanth, Jan, On 11/05/21 10:03 pm, Nishanth Menon wrote: > On 17:26-20210511, Jan Kiszka wrote: > [...] >>>>> +&sdhci1 { >>>>> + no-1-8-v; >>>>> +}; >>>>> + >>>> >>>> Let's move that to k3-am65-iot2050-common.dtsi, to avoid repeating >>>> yourself. There is already a sdhci1 extension. >>>> >>> >>> The reason why I added these tags in board dts and not in the common >>> dtsi is because if it was added in the common board then for all the iot >>> boards this will be applicable and in future if a different version of >>> iot boards use S.R. 2.0 then we might have to change it again. >> >> Yes, we will have to take care of the split-up for SR2.0-based variants. >> I didn't have the chance study their DTs yet but I strongly suspect that >> there will be more differences. Then we may add some >> k3-am65-iot2050-common-{SR1,SR2}.dtsi. >> >> So, I would not try to refactor when not all variables are on the table yet. > > > I agree with Jan. lets bring it in the current common.dtsi and see the > sr2 introduction separately. > okay, I'll post a respin of this patch making this change. Thanks, Aswath