From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F810433A7 for ; Fri, 9 Aug 2024 05:36:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723181767; cv=none; b=C0QyjiJ4I06Qzp0H/DVCF7egUDnkFN7gQ7klkCCARZdLJ6RbGTyZV0HmWsj1GQq5PBl797EFQ8rDaio+yKCEvO9g+iBKpf8qXBFSWQZ/8qk+9KRINvU9ypZTXMIDfaYp8QE+Pf/B8kKi/GV8erlfZ+eAWNoWP/akXa2sr+BJVbo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723181767; c=relaxed/simple; bh=YN+RKJ0/h6Vgx98OyJXkoce60kwJF3xcUQsAW5ygOqw=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=rSf2rrWvUJBIgcJ6zdcbHtD+gINMXhNZbOnDvl1k7unrWoA+0ubQfKOUFIhYt3Vo/f6Me1jqKvtOO8KQFLm9gFqbu9kQuKr9FiRStc4qABp1ZurDy8s+ysI7LV7DxMvgQqcmiyCtE++PrL5Oq+R4CxArWHbW2yB2c8wEkktBGYQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=LGWMVFQ4; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="LGWMVFQ4" Received: from pps.filterd (m0353723.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 478Cb3I8005727; Fri, 9 Aug 2024 05:35:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h= message-id:date:subject:to:cc:references:from:in-reply-to :content-type:content-transfer-encoding:mime-version; s=pp1; bh= ZKL8Q9qcvjVY5MH9IXvnciiyhYMEMZN0/x4DWSJkYTU=; b=LGWMVFQ44cMhD1G6 H8FirD6qcFLsFBZC3mdg1iP72C28Yqb4VEUo5FH+RnLDJRk6x2uywj1mkkAvyN0R wayXmEHdENljkC9LloEJSvrEYTWfoQN1VhjMShvnk/FXWrTPyn8f4YuHokPn5m3T oBc231Y3vl1szuMGxKx2O9sN/y1x/z+dJKlBc/nU3Qa7W13E1xqDiR9u/BFeQeJo W466GtrX8sCGw5vK2VeOaJe9z4PBnoBVQVx1il9oGhv8f4eVPXVQwUHJ0yguTGYw tcxhZ0nKsltNb0GF2NAm6Ny+OR3HMtQdSSLuwzSCl84UJVAHGfZEdF7Eg6ZUbZoY PxwwQQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 40vwkca1a8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 09 Aug 2024 05:35:50 +0000 (GMT) Received: from m0353723.ppops.net (m0353723.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 4795Zn9J030019; Fri, 9 Aug 2024 05:35:49 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 40vwkca1a6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 09 Aug 2024 05:35:49 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 4794DNjX006462; Fri, 9 Aug 2024 05:35:49 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 40t13mssc6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 09 Aug 2024 05:35:49 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 4795Zjlq18219434 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 9 Aug 2024 05:35:47 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 548BA20040; Fri, 9 Aug 2024 05:35:45 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C9D5A2004F; Fri, 9 Aug 2024 05:35:33 +0000 (GMT) Received: from [9.43.4.15] (unknown [9.43.4.15]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTP; Fri, 9 Aug 2024 05:35:33 +0000 (GMT) Message-ID: Date: Fri, 9 Aug 2024 11:05:28 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Document/kexec: Generalize crash hotplug description To: =?UTF-8?B?UGV0ciBUZXNhxZnDrWs=?= Cc: bhe@redhat.com, Hari Bathini , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org References: <20240805050829.297171-1-sourabhjain@linux.ibm.com> <20240808132423.0f313ffe@meshulam.tesarici.cz> Content-Language: en-US From: Sourabh Jain In-Reply-To: <20240808132423.0f313ffe@meshulam.tesarici.cz> Content-Type: text/plain; charset=UTF-8; format=flowed X-TM-AS-GCONF: 00 X-Proofpoint-GUID: HBp7JP1jjSSjsCq5NunZcsWQeKbk0vI8 X-Proofpoint-ORIG-GUID: kU2XRt0kb8RKUAbJXblqXveslvhGz5mj Content-Transfer-Encoding: 8bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-08-09_02,2024-08-07_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 impostorscore=0 suspectscore=0 phishscore=0 malwarescore=0 adultscore=0 spamscore=0 mlxlogscore=999 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2407110000 definitions=main-2408090041 Hello Petr, On 08/08/24 16:54, Petr Tesařík wrote: > Hi Sourabh, > > sorry for late reply, was on vacation and then catching up... > > On Mon, 5 Aug 2024 10:38:29 +0530 > Sourabh Jain wrote: > >> Commit 79365026f869 ("crash: add a new kexec flag for hotplug support") >> generalizes the crash hotplug support to allow architectures to update >> multiple kexec segments on CPU/Memory hotplug and not just elfcorehdr. >> Therefore, update the relevant kernel documentation to reflect the same. >> >> No functional change. >> >> Cc: Petr Tesarik >> Cc: Hari Bathini >> Cc: kexec@lists.infradead.org >> Cc: linux-kernel@vger.kernel.org >> Cc: linuxppc-dev@lists.ozlabs.org >> Cc: x86@kernel.org >> Signed-off-by: Sourabh Jain >> --- >> >> Discussion about the documentation update: >> https://lore.kernel.org/all/68d0328d-531a-4a2b-ab26-c97fd8a12e8b@linux.ibm.com/ >> >> --- >> .../ABI/testing/sysfs-devices-memory | 6 ++-- >> .../ABI/testing/sysfs-devices-system-cpu | 6 ++-- >> .../admin-guide/mm/memory-hotplug.rst | 5 ++-- >> Documentation/core-api/cpu_hotplug.rst | 10 ++++--- >> kernel/crash_core.c | 29 ++++++++++++------- >> 5 files changed, 33 insertions(+), 23 deletions(-) >> >> diff --git a/Documentation/ABI/testing/sysfs-devices-memory b/Documentation/ABI/testing/sysfs-devices-memory >> index a95e0f17c35a..421acc8e2c6b 100644 >> --- a/Documentation/ABI/testing/sysfs-devices-memory >> +++ b/Documentation/ABI/testing/sysfs-devices-memory >> @@ -115,6 +115,6 @@ What: /sys/devices/system/memory/crash_hotplug >> Date: Aug 2023 >> Contact: Linux kernel mailing list >> Description: >> - (RO) indicates whether or not the kernel directly supports >> - modifying the crash elfcorehdr for memory hot un/plug and/or >> - on/offline changes. >> + (RO) indicates whether or not the kernel update of kexec >> + segments on memory hot un/plug and/or on/offline events, >> + avoiding the need to reload kdump kernel. > This sentence somehow lacks a verb. My suggestion: > > (RO) indicates whether or not the kernel updates relevant kexec > segments on memory hot un/plug and/or on/offline events, avoiding the > need to reload kdump kernel. Thanks for the review. I will update the document as suggested. - Sourabh Jain > >> diff --git a/Documentation/ABI/testing/sysfs-devices-system-cpu b/Documentation/ABI/testing/sysfs-devices-system-cpu >> index 325873385b71..f4ada1cd2f96 100644 >> --- a/Documentation/ABI/testing/sysfs-devices-system-cpu >> +++ b/Documentation/ABI/testing/sysfs-devices-system-cpu >> @@ -703,9 +703,9 @@ What: /sys/devices/system/cpu/crash_hotplug >> Date: Aug 2023 >> Contact: Linux kernel mailing list >> Description: >> - (RO) indicates whether or not the kernel directly supports >> - modifying the crash elfcorehdr for CPU hot un/plug and/or >> - on/offline changes. >> + (RO) indicates whether or not the kernel update of kexec >> + segments on CPU hot un/plug and/or on/offline events, >> + avoiding the need to reload kdump kernel. > Same as above. > > Otherwise LGTM. > > Petr T